os-autoinst-distri-fedora/needles/gnome/next_button-startsetup-20200818.json

{
  "area": [
    {
      "height": 21,
      "ypos": 673,
      "xpos": 474,
      "width": 74,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "start_setup",
    "LANGUAGE-english"
  ]
}
Add a new not-really-a-Next-button needle for gnome-initial-setup In g-i-s 3.37.91, the first screen has a 'Start Setup' button rather than a 'Next' button. Easiest thing for us to do here is just to add a new needle which has the 'next_button' tag even though it's clearly not a 'Next' button, because then the code still works :) So do that, but give the file a suggestive name and explain the situation in a code comment. Signed-off-by: Adam Williamson <awilliam@redhat.com> 2020-08-18 19:23:09 +00:00			`{`
			`"area": [`
			`{`
			`"height": 21,`
			`"ypos": 673,`
			`"xpos": 474,`
			`"width": 74,`
			`"type": "match"`
			`}`
			`],`
			`"properties": [],`
			`"tags": [`
Make g-i-s Start Setup button needle its own thing There's a race issue with just treating it as a next button: it's not in the same place as a next button. Sometimes in the g-i-s code we actually get ahead of ourselves and click early, which isn't really a problem when the buttons are all in the same place, but if we click "Start Setup" in the middle of transition to the Privacy screen - as in https://openqa.fedoraproject.org/tests/745034#step/_graphical_wait_login/4 - the click effectively gets lost. So let's make it its own tag and have the initial assert look for it too. That way we won't match on it again in the main loop over "@nexts". Signed-off-by: Adam Williamson <awilliam@redhat.com> 2020-12-21 17:16:40 +00:00			`"start_setup",`
Add a new not-really-a-Next-button needle for gnome-initial-setup In g-i-s 3.37.91, the first screen has a 'Start Setup' button rather than a 'Next' button. Easiest thing for us to do here is just to add a new needle which has the 'next_button' tag even though it's clearly not a 'Next' button, because then the code still works :) So do that, but give the file a suggestive name and explain the situation in a code comment. Signed-off-by: Adam Williamson <awilliam@redhat.com> 2020-08-18 19:23:09 +00:00			`"LANGUAGE-english"`
			`]`
Make g-i-s Start Setup button needle its own thing There's a race issue with just treating it as a next button: it's not in the same place as a next button. Sometimes in the g-i-s code we actually get ahead of ourselves and click early, which isn't really a problem when the buttons are all in the same place, but if we click "Start Setup" in the middle of transition to the Privacy screen - as in https://openqa.fedoraproject.org/tests/745034#step/_graphical_wait_login/4 - the click effectively gets lost. So let's make it its own tag and have the initial assert look for it too. That way we won't match on it again in the main loop over "@nexts". Signed-off-by: Adam Williamson <awilliam@redhat.com> 2020-12-21 17:16:40 +00:00			`}`