srbala/os-autoinst-distri-fedora
1
0
Fork 0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-12-11 13:53:08 +00:00
Code Issues Releases Activity
6c861c033e
os-autoinst-distri-fedora/tests/disk_custom_software_raid.pm

31 lines
685 B
Perl
Raw Normal View History

small fix
2015-08-06 11:53:43 +00:00
use base "anacondatest";
revise storage: better test loading, shared disk selection Summary: This contains several tweaks to storage handling. It adds a method for disk selection which all the storage tests can share. It sets up a more extensible approach for main.pm to run the storage tests, instead of an ever-growing forest of 'else' clauses. Finally it sets up a couple of methods for changing partitioning schemes on the custom part screen and uses one of them in the software RAID test; the other will be used for other custom storage tests. This kills the two_disks needle. I could keep it and work it into select_disks, but it doesn't fit naturally and I really just don't see the point of the needle. The only thing we lose is we don't check that anaconda actually sees two disks in the 'attach two disks, only install to one' test (that's server_sata_multi), but the other multi-disk tests will serve to catch that case failing for some reason. What I actually intended to do was add some more tests for different custom part storage types, but it seemed a good idea to do some of this cleanup so that can be implemented efficiently. I'll have followups for that. Test Plan: Run all tests and ensure they work exactly as before (not just that they still pass, but that the correct test steps are actually scheduled in each case.) Reviewers: garretraziel, jskladan Reviewed By: garretraziel, jskladan Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D475
2015-07-31 08:31:27 +00:00
use strict;
use testapi;
Move all remaining utility functions into exporter modules Summary: This adds a couple of new exporter modules, renames main_common to utils (this is a better name: openSUSE's main_common is functions used in main.pm, utils is what they call their module full of miscellaneous commonly-used functions), and moves a bunch of utility functions that were previously needlessly implemented as instance methods in base classes into the exporter modules. That means we can get rid of all the annoying $self-> syntax for calling them. We get rid of `fedorabase` entirely, as it's no longer useful for anything. Other base classes keep the 'standard' methods (like `post_fail_hook`) and methods which actually need to be methods (like `root_console`, whose behaviour is different in anacondatest and installedtest). Test Plan: Do a full test suite run and check everything lines up. There should be no functional differences from before at all, this is just a re-org. Reviewers: jskladan, garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Reviewed By: garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Subscribers: tflink Differential Revision: https://phab.qa.fedoraproject.org/D1080
2017-01-18 07:15:44 +00:00
use anaconda;
revise storage: better test loading, shared disk selection Summary: This contains several tweaks to storage handling. It adds a method for disk selection which all the storage tests can share. It sets up a more extensible approach for main.pm to run the storage tests, instead of an ever-growing forest of 'else' clauses. Finally it sets up a couple of methods for changing partitioning schemes on the custom part screen and uses one of them in the software RAID test; the other will be used for other custom storage tests. This kills the two_disks needle. I could keep it and work it into select_disks, but it doesn't fit naturally and I really just don't see the point of the needle. The only thing we lose is we don't check that anaconda actually sees two disks in the 'attach two disks, only install to one' test (that's server_sata_multi), but the other multi-disk tests will serve to catch that case failing for some reason. What I actually intended to do was add some more tests for different custom part storage types, but it seemed a good idea to do some of this cleanup so that can be implemented efficiently. I'll have followups for that. Test Plan: Run all tests and ensure they work exactly as before (not just that they still pass, but that the correct test steps are actually scheduled in each case.) Reviewers: garretraziel, jskladan Reviewed By: garretraziel, jskladan Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D475
2015-07-31 08:31:27 +00:00
sub run {
my $self = shift;
# Go to INSTALLATION DESTINATION and ensure two disks are selected.
add ext3, btrfs and LVM thin tests, tweaks to custom methods Summary: This adds three new custom storage tests and some needles to support them, and tweaks the custom storage methods a bit to address some things that cropped up in writing the tests. A new method is added for changing the filesystem, as that's a distinct operation from changing the device type. This also restores the previous behaviour of select_disks() where it handled selecting custom partitioning when needed. Turns out it's pretty common to use regex'es in perl! Who'd'a thought. A corresponding commit to add the tests to openqa_fedora_tools is coming. There's no post-install step for the tests yet; I'll try and write those up and add them soon. Test Plan: Do a full run, including the new tests, on Alpha RC2 and check all are scheduled correctly and run correctly. The LVM thinp test is expected to fail as it catches a genuine bug. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D490
2015-08-10 18:01:12 +00:00
# Because PARTITIONING starts with 'custom_', this will select custom.
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
select_disks(disks => 2);
revise storage: better test loading, shared disk selection Summary: This contains several tweaks to storage handling. It adds a method for disk selection which all the storage tests can share. It sets up a more extensible approach for main.pm to run the storage tests, instead of an ever-growing forest of 'else' clauses. Finally it sets up a couple of methods for changing partitioning schemes on the custom part screen and uses one of them in the software RAID test; the other will be used for other custom storage tests. This kills the two_disks needle. I could keep it and work it into select_disks, but it doesn't fit naturally and I really just don't see the point of the needle. The only thing we lose is we don't check that anaconda actually sees two disks in the 'attach two disks, only install to one' test (that's server_sata_multi), but the other multi-disk tests will serve to catch that case failing for some reason. What I actually intended to do was add some more tests for different custom part storage types, but it seemed a good idea to do some of this cleanup so that can be implemented efficiently. I'll have followups for that. Test Plan: Run all tests and ensure they work exactly as before (not just that they still pass, but that the correct test steps are actually scheduled in each case.) Reviewers: garretraziel, jskladan Reviewed By: garretraziel, jskladan Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D475
2015-07-31 08:31:27 +00:00
assert_and_click "anaconda_spoke_done";
# Manual partitioning spoke should be displayed
assert_and_click "anaconda_part_automatic";
Move all remaining utility functions into exporter modules Summary: This adds a couple of new exporter modules, renames main_common to utils (this is a better name: openSUSE's main_common is functions used in main.pm, utils is what they call their module full of miscellaneous commonly-used functions), and moves a bunch of utility functions that were previously needlessly implemented as instance methods in base classes into the exporter modules. That means we can get rid of all the annoying $self-> syntax for calling them. We get rid of `fedorabase` entirely, as it's no longer useful for anything. Other base classes keep the 'standard' methods (like `post_fail_hook`) and methods which actually need to be methods (like `root_console`, whose behaviour is different in anacondatest and installedtest). Test Plan: Do a full test suite run and check everything lines up. There should be no functional differences from before at all, this is just a re-org. Reviewers: jskladan, garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Reviewed By: garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Subscribers: tflink Differential Revision: https://phab.qa.fedoraproject.org/D1080
2017-01-18 07:15:44 +00:00
custom_change_type("raid");
revise storage: better test loading, shared disk selection Summary: This contains several tweaks to storage handling. It adds a method for disk selection which all the storage tests can share. It sets up a more extensible approach for main.pm to run the storage tests, instead of an ever-growing forest of 'else' clauses. Finally it sets up a couple of methods for changing partitioning schemes on the custom part screen and uses one of them in the software RAID test; the other will be used for other custom storage tests. This kills the two_disks needle. I could keep it and work it into select_disks, but it doesn't fit naturally and I really just don't see the point of the needle. The only thing we lose is we don't check that anaconda actually sees two disks in the 'attach two disks, only install to one' test (that's server_sata_multi), but the other multi-disk tests will serve to catch that case failing for some reason. What I actually intended to do was add some more tests for different custom part storage types, but it seemed a good idea to do some of this cleanup so that can be implemented efficiently. I'll have followups for that. Test Plan: Run all tests and ensure they work exactly as before (not just that they still pass, but that the correct test steps are actually scheduled in each case.) Reviewers: garretraziel, jskladan Reviewed By: garretraziel, jskladan Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D475
2015-07-31 08:31:27 +00:00
assert_and_click "anaconda_spoke_done";
assert_and_click "anaconda_part_accept_changes";
# Anaconda hub
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
assert_screen "anaconda_main_hub", 300;
revise storage: better test loading, shared disk selection Summary: This contains several tweaks to storage handling. It adds a method for disk selection which all the storage tests can share. It sets up a more extensible approach for main.pm to run the storage tests, instead of an ever-growing forest of 'else' clauses. Finally it sets up a couple of methods for changing partitioning schemes on the custom part screen and uses one of them in the software RAID test; the other will be used for other custom storage tests. This kills the two_disks needle. I could keep it and work it into select_disks, but it doesn't fit naturally and I really just don't see the point of the needle. The only thing we lose is we don't check that anaconda actually sees two disks in the 'attach two disks, only install to one' test (that's server_sata_multi), but the other multi-disk tests will serve to catch that case failing for some reason. What I actually intended to do was add some more tests for different custom part storage types, but it seemed a good idea to do some of this cleanup so that can be implemented efficiently. I'll have followups for that. Test Plan: Run all tests and ensure they work exactly as before (not just that they still pass, but that the correct test steps are actually scheduled in each case.) Reviewers: garretraziel, jskladan Reviewed By: garretraziel, jskladan Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D475
2015-07-31 08:31:27 +00:00
}
sub test_flags {
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
return {fatal => 1};
revise storage: better test loading, shared disk selection Summary: This contains several tweaks to storage handling. It adds a method for disk selection which all the storage tests can share. It sets up a more extensible approach for main.pm to run the storage tests, instead of an ever-growing forest of 'else' clauses. Finally it sets up a couple of methods for changing partitioning schemes on the custom part screen and uses one of them in the software RAID test; the other will be used for other custom storage tests. This kills the two_disks needle. I could keep it and work it into select_disks, but it doesn't fit naturally and I really just don't see the point of the needle. The only thing we lose is we don't check that anaconda actually sees two disks in the 'attach two disks, only install to one' test (that's server_sata_multi), but the other multi-disk tests will serve to catch that case failing for some reason. What I actually intended to do was add some more tests for different custom part storage types, but it seemed a good idea to do some of this cleanup so that can be implemented efficiently. I'll have followups for that. Test Plan: Run all tests and ensure they work exactly as before (not just that they still pass, but that the correct test steps are actually scheduled in each case.) Reviewers: garretraziel, jskladan Reviewed By: garretraziel, jskladan Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D475
2015-07-31 08:31:27 +00:00
}
1;
# vim: set sw=4 et:
Reference in New Issue Copy Permalink