srbala/os-autoinst-distri-fedora
1
0
Fork 0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-11-16 03:33:08 +00:00
Code Issues Releases Activity
32a7798037
os-autoinst-distri-fedora/tests/disk_custom_iscsi.pm

34 lines
925 B
Perl
Raw Normal View History

add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
use base "anacondatest";
use strict;
use testapi;
Move all remaining utility functions into exporter modules Summary: This adds a couple of new exporter modules, renames main_common to utils (this is a better name: openSUSE's main_common is functions used in main.pm, utils is what they call their module full of miscellaneous commonly-used functions), and moves a bunch of utility functions that were previously needlessly implemented as instance methods in base classes into the exporter modules. That means we can get rid of all the annoying $self-> syntax for calling them. We get rid of `fedorabase` entirely, as it's no longer useful for anything. Other base classes keep the 'standard' methods (like `post_fail_hook`) and methods which actually need to be methods (like `root_console`, whose behaviour is different in anacondatest and installedtest). Test Plan: Do a full test suite run and check everything lines up. There should be no functional differences from before at all, this is just a re-org. Reviewers: jskladan, garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Reviewed By: garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Subscribers: tflink Differential Revision: https://phab.qa.fedoraproject.org/D1080
2017-01-18 07:15:44 +00:00
use anaconda;
add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
sub run {
my $self = shift;
# iscsi config hash
my %iscsi;
Move most 'universal' tests to Server-dvd-iso The 'universal' flavor has been kinda pointless for some time now. It dates back to the earliest days of openQA, before Pungi 4 was a thing, when composes were very different; we only built a boot.iso and some live images nightly for Rawhide, these weren't even formally grouped as a 'compose' at all (fedfind had to invent the concept). The TCs/RCs had DVD installer images (not *Server* DVD, at the time, just a universal DVD installer). We wanted to run some tests on the DVD image if it was available, but we still wanted to run them for the nightlies, so we invented a whole mechanism for that - this 'universal' flavor, with some complicated logic in fedora_openqa which schedules universal on the 'best available' image it can find in the compose. All this is functionally obsolete now. All composes we test are now run through Pungi (except the live respins, but they aren't relevant here). In current config, the Server DVD is non-failable on x86_64 and aarch64, which means it will *always be there* - if it fails to build, the compose itself fails, so we won't test it. It's failable for ppc64le, but we don't care that much about ppc64le; I'm fine with these tests just not running if the Server DVD happens to fail in a ppc64le compose. As a cherry on top, some of the 'universal' tests aren't really universal anyway, they fail if you run them on a netinst (off the top of my head, all the NFS install tests are like this, as we use the ISO to populate the NFS share on the server end). So let's just move all the tests that actually need an installer image to the Server-dvd-iso flavor. Left over in the 'universal' flavor are upgrade tests, which don't need an ISO at all - they boot from hard disk images and run an upgrade using repos. We can change the scheduler logic to be more simple for these, and just always schedule them, with no ISO attached. We could even rename this flavor 'upgrade', but it might not be worth it. One slight complication is that the split happened to be helping us avoid too many tests in a single support_server cluster; we have a cluster of five support_server tests on Server-dvd-iso and five support_server tests on universal. I try to avoid the clusters getting too big as you need as many worker instances on at least one worker host as your largest cluster; if you don't have that many, the cluster's tests simply never get scheduled. Requiring folks to have at least ten worker instances on one host to run these tests is a bit of a big ask. So, to handle that, we create a support_server_2 and have the former universal tests use that one instead, so we'll have two separate clusters on Server-dvd-iso now. Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-03 20:45:52 +00:00
$iscsi{'iqn.2016-06.local.domain:support.target1'} = ['172.16.2.120', 'test', 'weakpassword'];
add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
# Anaconda hub
# Go to INSTALLATION DESTINATION and ensure one regular disk
# and the iscsi target are selected.
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
select_disks(iscsi => \%iscsi);
add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
assert_and_click "anaconda_spoke_done";
# now we're at custom part. let's use standard partitioning for
# simplicity
Move all remaining utility functions into exporter modules Summary: This adds a couple of new exporter modules, renames main_common to utils (this is a better name: openSUSE's main_common is functions used in main.pm, utils is what they call their module full of miscellaneous commonly-used functions), and moves a bunch of utility functions that were previously needlessly implemented as instance methods in base classes into the exporter modules. That means we can get rid of all the annoying $self-> syntax for calling them. We get rid of `fedorabase` entirely, as it's no longer useful for anything. Other base classes keep the 'standard' methods (like `post_fail_hook`) and methods which actually need to be methods (like `root_console`, whose behaviour is different in anacondatest and installedtest). Test Plan: Do a full test suite run and check everything lines up. There should be no functional differences from before at all, this is just a re-org. Reviewers: jskladan, garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Reviewed By: garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Subscribers: tflink Differential Revision: https://phab.qa.fedoraproject.org/D1080
2017-01-18 07:15:44 +00:00
custom_scheme_select("standard");
add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
# Do 'automatic' partition creation
assert_and_click "anaconda_part_automatic";
# Make sure / is on the iSCSI target (which appears as sda)
Move all remaining utility functions into exporter modules Summary: This adds a couple of new exporter modules, renames main_common to utils (this is a better name: openSUSE's main_common is functions used in main.pm, utils is what they call their module full of miscellaneous commonly-used functions), and moves a bunch of utility functions that were previously needlessly implemented as instance methods in base classes into the exporter modules. That means we can get rid of all the annoying $self-> syntax for calling them. We get rid of `fedorabase` entirely, as it's no longer useful for anything. Other base classes keep the 'standard' methods (like `post_fail_hook`) and methods which actually need to be methods (like `root_console`, whose behaviour is different in anacondatest and installedtest). Test Plan: Do a full test suite run and check everything lines up. There should be no functional differences from before at all, this is just a re-org. Reviewers: jskladan, garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Reviewed By: garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Subscribers: tflink Differential Revision: https://phab.qa.fedoraproject.org/D1080
2017-01-18 07:15:44 +00:00
custom_change_device("root", "sda");
add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
assert_and_click "anaconda_spoke_done";
assert_and_click "anaconda_part_accept_changes";
}
sub test_flags {
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
return {fatal => 1};
add an iscsi test, and a support_server test to support it Summary: this is following a SUSE model for tests where we need a server end but don't want setting up the server to constitute a real test in itself, we want it to be stable. The 'support_server' test just boots a pre-built (by createhdds) disk image, sets up networking, and runs the iSCSI server. To run the iSCSI test we need to handle networking config in anaconda (or we would need to set the support server up as a DHCP server, which may be worth considering), so this adds that. We also need to be able to specify the target device for a volume in custom partitioning, so this adds that too. Test Plan: Build the necessary support server disk image (use D883), then run the test and make sure it works. Also make sure all other tests continue to work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 15:43:46 +00:00
}
1;
# vim: set sw=4 et:
Reference in New Issue Copy Permalink