It's not obvious that merely a non-zero exit code from a command is
enough to fail a scriptlet. There are commands in the %pre scriptlet
that have been returning with non-zero exit codes for a long time
without ever failing the build [1].
It's possible that the rules are different for the %pre and %post
scriptlets, or that it's the exit code of the last command that
determines the status of the scriptlet [2]. Even if that's the case,
they are both very flimsy situations. If new tests are added, then only
one of them is going to be the last one.
Therefore, it's better to make things as obvious as possible.
The test originally came from the Container/Dockerfile equivalent of the
fedora-toolbox OCI images [3], where false(1) was used in a RUN
instruction, and it lacked any ambiguity.
[1] Commit
|
||
|---|---|---|
| custom | ||
| l10n | ||
| snippets | ||
| templates | ||
| tools | ||
| .gitignore | ||
| AUTHORS | ||
| COPYING | ||
| fedora-budgie-common.ks | ||
| fedora-cinnamon-common.ks | ||
| fedora-cloud-base-azure.ks | ||
| fedora-cloud-base-gcp.ks | ||
| fedora-cloud-base-vagrant.ks | ||
| fedora-cloud-base.ks | ||
| fedora-comp-neuro-common.ks | ||
| fedora-container-base-minimal.ks | ||
| fedora-container-base.ks | ||
| fedora-container-common.ks | ||
| fedora-container-toolbox.ks | ||
| fedora-design-suite-common.ks | ||
| fedora-disk-base.ks | ||
| fedora-disk-budgie.ks | ||
| fedora-disk-kde.ks | ||
| fedora-disk-lxqt.ks | ||
| fedora-disk-minimal.ks | ||
| fedora-disk-phosh.ks | ||
| fedora-disk-python-classroom.ks | ||
| fedora-disk-server.ks | ||
| fedora-disk-soas.ks | ||
| fedora-disk-workstation.ks | ||
| fedora-disk-xbase.ks | ||
| fedora-disk-xfce.ks | ||
| fedora-eln-container-base.ks | ||
| fedora-eln-guest.ks | ||
| fedora-i3-common.ks | ||
| fedora-iot.ks | ||
| fedora-kde-common.ks | ||
| fedora-live-astronomy_kde.ks | ||
| fedora-live-base.ks | ||
| fedora-live-budgie.ks | ||
| fedora-live-cinnamon.ks | ||
| fedora-live-comp_neuro.ks | ||
| fedora-live-design_suite.ks | ||
| fedora-live-games.ks | ||
| fedora-live-i3.ks | ||
| fedora-live-jam_kde.ks | ||
| fedora-live-kde-base.ks | ||
| fedora-live-kde.ks | ||
| fedora-live-lxde.ks | ||
| fedora-live-lxqt.ks | ||
| fedora-live-mate_compiz.ks | ||
| fedora-live-minimization.ks | ||
| fedora-live-python-classroom.ks | ||
| fedora-live-robotics.ks | ||
| fedora-live-scientific_kde.ks | ||
| fedora-live-security.ks | ||
| fedora-live-soas.ks | ||
| fedora-live-sway.ks | ||
| fedora-live-workstation.ks | ||
| fedora-live-xfce.ks | ||
| fedora-lxde-common.ks | ||
| fedora-lxqt-common.ks | ||
| fedora-mate-common.ks | ||
| fedora-minimal-common.ks | ||
| fedora-modular-disk-minimal.ks | ||
| fedora-neuro-gnome-common.ks | ||
| fedora-phosh-common.ks | ||
| fedora-python-classroom-common.ks | ||
| fedora-python-classroom-gnome-common.ks | ||
| fedora-python-classroom-vagrant.ks | ||
| fedora-repo-not-rawhide.ks | ||
| fedora-repo-rawhide.ks | ||
| fedora-repo.ks | ||
| fedora-scientific-common.ks | ||
| fedora-scientific-vagrant.ks | ||
| fedora-server-vm-full.ks | ||
| fedora-soas-common.ks | ||
| fedora-sway-common.ks | ||
| fedora-workstation-common.ks | ||
| fedora-xfce-common.ks | ||
| maintainers.toml | ||
| Makefile | ||
| README.md | ||
fedora-kickstarts
This project is used to manage the Fedora kickstart files used in composing Fedora release images.
The master branch is used by rawhide and each release branch is used by that release.
All changes should be made via the PR workflow.
This project is packaged in Fedora as the spin-kickstarts package allowing users to see and modify the kickstart files for their local needs.
Maintainers for each image are listed in the maintainers.toml file.
To make a release
git clone ssh://git@pagure.io/fedora-kickstarts.git fedora-kickstarts
cd fedora-kickstarts
# If you need a specific branch other than master:
git checkout BRANCHNAME
# No tag has been added yet tag HEAD with
git tag VERSION
git push --tags
make
# Publish the released tar ball
make publish
# Clean up the generated files:
make clean
Build logs
To see build logs go to
https://koji.fedoraproject.org/koji
"Packages" tab, and filter by Fedora-Workstation-Live for example.
Technical info about the officialy released images can be found at
https://kojipkgs.fedoraproject.org/compose/
bug reports
Bugs should be reported to the spin-kickstarts bugzilla component:
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&component=spin-kickstarts