Commit Graph

58 Commits

Author SHA1 Message Date
Adam Williamson fe87f40d94 Hack to avoid F33 KDE image using Wayland (#1960458)
This is a bit ugly but offhand can't think of a better way. We
are dropping plasma-workspace-wayland from the F33 KDE image to
try and avoid it using Plasma-on-Wayland as the default session,
which is #1960458.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-13 16:29:27 -07:00
Adam Williamson 5d6842d146 Add current minimal-uefi for aarch64, stop allowing "current"
"current" is just a synonym for "-1" but made the code more
complex. Let's ditch it and just note in a comment that -1 is
CURRREL and -2 is PREVREL. We need minimal-uefi for aarch64 as
install_blivet_btrfs_preserve_home_uefi uses it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-19 11:29:25 -08:00
Michel Normand 5732bf97be Revert "Work around RHBZ #1769600 on ppc64"
This reverts commit 8f53b9f5f8.

similar revert already done since a while in os-autoinst-distri-fedora
"e020b87  Drop the pseries-4.0 workaround for ppc64le"
2020-11-09 17:55:27 +01:00
Adam Williamson e03456491b Enable virt-install debug logging when we are at debug log level
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-09 09:13:19 -07:00
Adam Williamson c9ce6b5d0a Tweak get_virtinstall_images to not include dupes
Some of the version config directives make it possible to wind
up with dupes - for instance, our config for the 'minimal' image
can result in multiple instances of VirtInstallImage for F31
appearing in the list, meaning we'll build the same image two
or more times in the same run. That's silly! Let's not do that.
Using a dict keyed on the release number and arch we wind up with
after interpreting the config file should avoid it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-06 16:04:19 -07:00
Adam Williamson 05b418b796 Add aarch64 as a valid choice for CLI arch arg
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-18 15:15:04 -07:00
Lukáš Růžička e63e8314f4 Add support for setting the GUID of the partition to set
its correct type.

Previously, it was not possible to set the type of the partition via
the specific GUID. This commit adds support for adding the GUID into
the gtp_type of the partition description in hdds.json and this field
will be utilized in to code.
2019-11-14 10:22:18 +01:00
Lukáš Růžička a01d22f6ef Enable booting the VM as UEFI and provide record for a UEFI machine.
This commit adds support for boot options, that can be passed
from `hdds.json` to control the creation of the virtual
machines, such as enabling of EFI based machines, boot order
control, etc. It also adds EFI based machine to `hdds.json`
and adds a kickstart file for such machine.
2019-11-13 20:19:44 +01:00
Adam Williamson 8f53b9f5f8 Work around RHBZ #1769600 on ppc64
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-07 13:36:17 -08:00
Adam Williamson 53ef72b734 Drop some old release-based workarounds, no longer needed
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-06 11:58:18 -08:00
Adam Williamson c9da58b0b0 Move i686 F31+ filter, drop ppc64 F29+ one
We previously did a filter like the one for 'i686 on F31+' for
'ppc64 on F29+', only in a different place which was actually a
better place. That filter is now unneeded as F28 went EOL, so
drop it...but move the i686 F31+ filter into the same place, as
it's better done there than in create().

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-05 12:40:02 -08:00
Adam Williamson 8e6136ee20 Don't allow creation of i686 images for Fedora 31+
This just isn't possible any more, we no longer produce all
the necessary bits to generate images for i686.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-29 14:31:27 -07:00
Adam Williamson 74c28b5557 Now fix it harder I hate software where's my yak farm
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-27 08:18:09 -07:00
Adam Williamson 6134a088f1 Sigh, fix previous commit
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-27 08:17:31 -07:00
Adam Williamson 5113761cbb From F31 onwards we have to build Workstation out of Everything
Conspiracy theory: everything releng does is intended to make
this code more awful

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-27 08:16:29 -07:00
Michel Normand 14c2af9332 Revert "Disable plymouth for PowerPC release >f27"
This reverts commit 3f9cbd27d4.

I verified that related bug#1571860 is not present anymore on f29.

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2019-05-29 10:11:49 +02:00
Michel Normand 99022bda48 keep variant setting removed by previous commit
to avoid error like:
===
$~/createhdds/createhdds.py  support
...
Traceback (most recent call last):
  File "/root/createhdds/createhdds.py", line 821, in <module>
    main()
  File "/root/createhdds/createhdds.py", line 811, in main
    args.func(args, hdds)
  File "/root/createhdds/createhdds.py", line 701, in cli_image
    img.create(args.textinst)
  File "/root/createhdds/createhdds.py", line 291, in create
    loctmp.format(fedoradir, str(self.release), variant, arch), "--name", "createhdds",
NameError: name 'variant' is not defined
===

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2019-02-06 09:31:59 +01:00
Adam Williamson 9523510d43 Few misc updates for old things
Archive now has up to F27, we're not testing ppc64 any more, and
the old workaround is no longer needed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-02-01 10:51:09 +00:00
Adam Williamson c1b0ddc39e Don't produce ppc64 images for Fedora > 28
ppc64 (as opposed to ppc64le) was retired in Fedora 29. Tweaking
hdds.json to reflect this now is a bit awkward, so instead let's
leave it as-is, but add code to createhdds to not really include
a ppc64 image in the expected list if it's for F29 or later.
Once F28 goes EOL we can just drop all ppc64 from hdds.json and
lose this code.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-11-13 13:29:03 -08:00
Adam Williamson c0a92bfd73 Maybe it's right this time...
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-08-08 11:09:47 -07:00
Adam Williamson 4c46794638 Fix an error in previous commit
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-08-07 16:34:53 -07:00
Adam Williamson 9aeb8841c5 Try and deal with F26 being archived *already*
Grumble mumble.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-08-07 16:33:46 -07:00
Michel Normand 3f9cbd27d4 Disable plymouth for PowerPC release >f27
as bypass for pending bug
https://bugzilla.redhat.com/show_bug.cgi?id=1571860

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2018-05-04 11:05:29 +02:00
Adam Williamson 46d78228e9 Correct cross-arch info message again
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-15 10:37:37 -07:00
Adam Williamson 14abb9b3e1 libvirt: Undefine NVRAM when undefining domain
This is apparently necessary on aarch64, we get an error from
libvirt otherwise.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-14 13:42:01 -07:00
Adam Williamson a886b9f4a9 Handle aarch64 being secondary for releases < 28
Sigh, this mini-fedfind is so much fun.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-14 12:24:37 -07:00
Adam Williamson 450efb8bb5 Add aarch64 support and images
We're bootstrapping aarch64 into openQA, so we need this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-06 09:06:58 -08:00
Adam Williamson 498cc306f8 Update README, make 'wrong arch' log message less scary
README was badly outdated, so give it a coat of paint. A person
trying to get up to speed on openQA was misled by the current
message into thinking something was wrong.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-06 08:54:35 -08:00
Adam Williamson ed7fcd75e4 Don't list images for other arches as 'missing'
...But also be careful not to treat them as 'unknown' either.
This avoids the ansible plays regenerating outdated images (we
try to avoid that and just have the cron job do it).
2017-10-16 09:51:56 -07:00
Adam Williamson 7c32272cc8 Include arch in branched virt-install URL
...*this* should be right.
2017-09-15 19:56:35 -07:00
Adam Williamson 4e2df1104d Don't include fedoradir twice in virt-install branched URL
...oops.
2017-09-15 19:53:13 -07:00
Adam Williamson b0fd971916 Sigh, force to str when appropriate... 2017-09-04 16:08:18 -07:00
Adam Williamson d87bafb15e Bit more rejigging, fix i386 secondary case
Broke the i386 secondary case with the previous rejig (by moving
where we fix i686 to be i386). This fixes that and again makes
readability better.
2017-09-04 16:06:44 -07:00
Adam Williamson 7e5db6a426 Re-order `VirtInstallImage.create()` a bit to avoid bugs
Various things were being set in odd orders and not used right
later on, this is a general clean-up that solves that and makes
things a bit easier to read (I hope).
2017-09-04 12:19:59 -07:00
Adam Williamson 12e3a050b7 Get the domain again before cleaning it up, catch errors
Whoops, that last commit just wasn't very good. We need to
re-open the libvirt connection and re-get the domain object,
and also we should catch errors while destroying and undefining
the domain...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-08-31 17:29:00 -04:00
Adam Williamson ba1dd56896 Ensure domain is taken down when we exhaust retries
This was just an oversight - we don't destroy and undefine the
'createhdds' domain on the path where the final retry to create
an image times out, we just wipe the temp file and exit. So we
leave a qemu process sitting around until createhdds runs again
(and, on openQA production, exhausting swap space).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-08-30 17:33:03 -04:00
Adam Williamson e112047296 Rejig supported arch stuff to avoid incorrect deletions
The way this was done, when we ran `all` on a ppc host it wiped
all the x86_64 and i686 virt-install images, and when we ran
`all` on an x86_64 host it wiped all the ppc64 virt-install
images. Doing it this way avoids that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-08-17 17:42:43 -07:00
Michel Normand 1f39c80d2b Increase memory size from 2048 to 4096 for PowerPC
as today seems to be required to avoid createhdds to hang
on creation of disk_f25_minimal_2_ppc64le.img.tmp ...[13/22]
Trying to VNC connect, show anaconda menu stuck on
"Performing post-installation setup tasks"

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2017-08-11 07:24:03 -04:00
Michel Normand eec1f1ae6e Add PowerPC support in createhdds script and json
Assumption createhdds executed on a PowerPC ppc64le host
to create the PowerPC specific images.

Detect current CPU arch of host machine to create virt-install images
only for supported architectures. (hardcoded lists)

hdds.json specific changes for PowerPC
* no desktop or kde images

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2017-08-10 07:48:14 -04:00
Adam Williamson 658e082418 Allow 'stable' and 'current' as release for virt-install images
'stable' means 'all current stable releases', and is used for
desktop and server as we need to ensure we have those images
available for all stable releases (including the '-3' release
while it's not EOL) for update testing. (Currently, F24 update
tests are all failing as the images are missing).

'current' means 'the current stable release' - it's the same as
'-1', but just easier to understand. It's used for support.
2017-07-27 12:56:26 -07:00
Adam Williamson 6d997b2f80 Different fix for F26 Workstation: use Everything tree
It seems like the installer images (in os/images) for the F26
Workstation tree somehow come from the OStree installer compose
rather than the network installer compose; install.img and
boot.iso are far larger than they should be, and match the size
of the OStree installer .iso . So instead of using those images
and bumping up the memory size to 4GiB, use the Everything tree
for F26 Workstation image builds and go back to 2GiB.
2017-07-20 11:56:25 -07:00
Adam Williamson f476e00bd6 We need 4GiB of RAM in virt-install, for F26, it seems
Running with 2GiB causes the Workstation image builds to fail.
2017-07-19 15:18:54 -07:00
Adam Williamson d1a2869cc0 Correct fedora-secondary path 2017-07-19 13:10:04 -07:00
Adam Williamson 2f55cbede3 Handle i686 install tree location moving in F26 2017-07-19 13:08:31 -07:00
Adam Williamson e1254ba397 Remove #1439388 workaround
The updates.img is broken with current F26, and Radek claims the
bug is fixed. Let's see. Unfortunately I don't remember what I
put in the updates.img, so if I have to recreate it things could
get fun...
2017-07-19 11:22:15 -07:00
Adam Williamson bcc1f265e3 Workaround RHBZ #1439388 for F26 (with an updates.img)
This bug is causing havoc with image creation on openqa01, so
use an updates.img for F26 image builds until it's fixed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-04-07 20:14:33 -07:00
Adam Williamson 2d09aa6ef5 Fix recursive `create()` call on timeout
It wasn't passing textinst, so it'd crash on the first retry.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-04-07 10:55:20 -07:00
Adam Williamson 9fe9b2281f Fix (hopefully) Branched base image location detection
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-03-06 17:18:16 -08:00
Adam Williamson 2940891d8f Allow logged text installs, Branched and Rawhide
This is an attempt to add features desirable for creating
Taskotron base images. It extends the 'release' handling for
virt-install images in several ways to allow requesting of
'branched' and 'rawhide' image creation. It also adds an arg
to request virt-install image creation run in text mode, not
graphical mode. Graphical mode is what we always want for
openQA (so the installed OS doesn't have kernel params intended
for serial console interaction), but for Taskotron purposes,
we want the install run in text mode.

This also adds 'branched' to the default JSON file for minimal
and desktop, as we will want branched versions of these images
for the critpath update testing workflow to work on Branched
after Bodhi activation.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2017-02-28 15:47:53 -08:00
Adam Williamson 7a206b473c createhdds: use user-mode networking for now
There's been an annoying bug on the production openQA server
for a while now: createhdds runs to refresh the upgrade base
images don't actually work most of the time, each attempt to
run virt-install fails. I finally got time to debug this a bit
today and it seems to be some kind of network issue: the VM has
no network access so the install doesn't work. I've no idea why
that's happening, but using user-mode networking seems to work
around it for now and shouldn't have any terrible side effects
even for openQA servers not affected by this problem. So let's
do this until we can pin down the real bug.
2016-10-21 16:54:03 -07:00