rpms/yelp
5
0
Fork 0
Code Issues Pull Requests Releases Activity

Don't create empty /usr/share/gnome/help directory

Browse Source 
As per the current packaging guidelines, this should be owned by
individual packages that install files in there:

https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

Removing this directory from yelp makes sure that packagers won't add a
dep on yelp just because they notice that it happens to own the empty
directory, as happened in:

http://pkgs.fedoraproject.org/cgit/grilo-plugins.git/commit/?id=c24254c4
https://bugzilla.redhat.com/show_bug.cgi?id=964421
This commit is contained in:
Kalev Lember 2013-05-25 12:37:43 +02:00
parent 7b36698e43
commit 1d93858f55
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
yelp.spec
View File

@ -81,8 +81,6 @@ make install DESTDIR=$RPM_BUILD_ROOT
rm $RPM_BUILD_ROOT%{_libdir}/libyelp.a
rm $RPM_BUILD_ROOT%{_libdir}/libyelp.la
mkdir -p -m 755 $RPM_BUILD_ROOT/%{_datadir}/gnome/help
%find_lang %{name}
%check
@ -112,7 +110,6 @@ gtk-update-icon-cache %{_datadir}icons/hicolor &> /dev/null || :
%doc ChangeLog AUTHORS COPYING MAINTAINERS NEWS README
%{_bindir}/*
%{_datadir}/applications/yelp.desktop
%dir %{_datadir}/gnome/help
%{_datadir}/yelp
%{_datadir}/glib-2.0/schemas/org.gnome.yelp.gschema.xml
%{_datadir}/yelp-xsl/xslt/common/domains/yelp.xml
@ -129,6 +126,8 @@ gtk-update-icon-cache %{_datadir}icons/hicolor &> /dev/null || :
%changelog
* Sat May 25 2013 Kalev Lember <kalevlember@gmail.com> - 1:3.8.1-3
- Make yelp-libs dep arch-specific, thanks to Michael Schwendt (#967180)
- Don't create empty /usr/share/gnome/help directory: this should be owned by
individual packages that install files in there (#964421)
* Sat May 18 2013 Peter Robinson <pbrobinson@fedoraproject.org> 1:3.8.1-2
- yelp should depend on yelp-libs not the other way around