From bb3859b9e76b31a71c74c88791abc5ccb1776a01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Thu, 15 Aug 2019 17:03:37 +0200 Subject: [PATCH virt-viewer] ovirt-foreign-menu: Fix warnings on Rawhide MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb': ovirt-foreign-menu.c:721:9: error: format not a string literal and no format arguments [-Werror=format-security] 721 | g_debug(msg); | ^~~~~~~ ovirt-foreign-menu.c:722:9: error: format not a string literal and no format arguments [-Werror=format-security] 722 | g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg); | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors gmake[3]: *** [Makefile:963: libvirt_viewer_la-ovirt-foreign-menu.lo] Error 1 gmake[2]: *** [Makefile:647: all] Error 2 gmake[1]: *** [Makefile:482: all-recursive] Error 1 make: *** [Makefile:410: all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.f14Lmj (%build) Errors have been caught by https://ci.centos.org/job/virt-viewer-rpm/systems=libvirt-fedora-rawhide/589/ Signed-off-by: Fabiano Fidêncio Acked-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index cbb0e88..cdf9879 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign-menu.c @@ -715,8 +715,8 @@ static void storage_domains_fetched_cb(GObject *source_object, const char *msg = domain_valid ? "Could not find ISO file collection" : "Could not find valid ISO storage domain"; - g_debug(msg); - g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg); + g_debug("%s", msg); + g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s", msg); g_object_unref(task); } } -- 2.21.0