From 8676750b73bda178cfe0f278e76547711910f71d Mon Sep 17 00:00:00 2001 Message-Id: <8676750b73bda178cfe0f278e76547711910f71d@dist-git> From: Pavel Hrdina Date: Thu, 25 Jul 2019 14:09:53 +0200 Subject: [PATCH] virt-install: Use minutes instead of seconds on get_time_string() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Fabiano Fidêncio get_time_string() currently uses self._wait_secs, while it should use self._wait_mins, resulting on confusing messages when using `--wait` option, as shown below: fidencio@laerte ~/src/upstream/virt-manager $ ./virt-install --install fedora30 --unattended --wait 20 ... Waiting 1200 minutes for installation to complete. Reviewed-by: Cole Robinson Signed-off-by: Fabiano Fidêncio (cherry picked from commit 414ffa5ef82548d502a4de98d40228a68bdb29c1) Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1777664 Signed-off-by: Pavel Hrdina --- virt-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt-install b/virt-install index 009d03e1..022f947d 100755 --- a/virt-install +++ b/virt-install @@ -614,7 +614,7 @@ class WaitHandler: self._start_time = time.time() def get_time_string(self): - timestr = _(" %d minutes") % self._wait_secs + timestr = _(" %d minutes") % self._wait_mins if self._wait_forever: timestr = "" ret = _("Waiting%(time_string)s for installation to complete.") % { -- 2.26.2