From 082ac77cee8141494f1185a0debf958694639e4f Mon Sep 17 00:00:00 2001 Message-Id: <082ac77cee8141494f1185a0debf958694639e4f@dist-git> From: Pavel Hrdina Date: Tue, 21 Jul 2020 12:33:56 +0200 Subject: [PATCH] details: fix detection of firmware auto-selection Commit <15a9502b7b7a263c4d66ff2b3f31c209f58fe0b4> fixed firmware detection but incorrectly. It will always show only "UEFI" even if the firmware auto-selection is not used because the function is_uefi() checks both the old style and the new auto-selection. We have to check only for the auto-selection option. Signed-off-by: Pavel Hrdina (cherry picked from commit e8bf16b983558010cc9645e09eb36117e9e4fba4) Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1857069 Signed-off-by: Pavel Hrdina --- virtManager/details/details.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtManager/details/details.py b/virtManager/details/details.py index 7b0a501f..4d67d8b1 100644 --- a/virtManager/details/details.py +++ b/virtManager/details/details.py @@ -2017,7 +2017,7 @@ class vmmDetails(vmmGObjectUI): # Firmware domcaps = self.vm.get_domain_capabilities() - if self.vm.get_xmlobj().is_uefi(): + if self.vm.get_xmlobj().os.firmware == "efi": firmware = 'UEFI' else: firmware = domcaps.label_for_firmware_path( -- 2.26.2