From a63ad78ed31e36dbdf3a9cd28071dcdbefce7d19 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 31 Aug 2022 12:01:54 +0100 Subject: [PATCH] patch 9.0.0339: no check if the return value of XChangeGC() is NULL Problem: No check if the return value of XChangeGC() is NULL. Solution: Only use the return value when it is not NULL. (closes #11020) --- src/gui_x11.c | 10 +++++++--- src/version.c | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gui_x11.c b/src/gui_x11.c index 6e3e903be..7293ac490 100644 --- a/src/gui_x11.c +++ b/src/gui_x11.c @@ -2231,10 +2231,14 @@ gui_x11_create_blank_mouse(void) { Pixmap blank_pixmap = XCreatePixmap(gui.dpy, gui.wid, 1, 1, 1); GC gc = XCreateGC(gui.dpy, blank_pixmap, (unsigned long)0, (XGCValues*)0); - XDrawPoint(gui.dpy, blank_pixmap, gc, 0, 0); - XFreeGC(gui.dpy, gc); + + if (gc != NULL) + { + XDrawPoint(gui.dpy, blank_pixmap, gc, 0, 0); + XFreeGC(gui.dpy, gc); + } return XCreatePixmapCursor(gui.dpy, blank_pixmap, blank_pixmap, - (XColor*)&gui.norm_pixel, (XColor*)&gui.norm_pixel, 0, 0); + (XColor*)&gui.norm_pixel, (XColor*)&gui.norm_pixel, 0, 0); } /* -- 2.39.1