From b5098060f4acae4dac3203130278c948d670a3d5 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 7 Jul 2021 19:26:19 +0200 Subject: [PATCH] patch 8.2.3115: Coverity complains about free_wininfo() use Problem: Coverity complains about free_wininfo() use. Solution: Add a condition that "wip2" is not equal to "wip". (Neovim #14996) --- src/version.c | 2 ++ src/window.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/window.c b/src/window.c index 09067b081..cc9c217b4 100644 --- a/src/window.c +++ b/src/window.c @@ -5057,8 +5057,9 @@ win_free( // If there already is an entry with "wi_win" set to NULL it // must be removed, it would never be used. + // Skip "wip" itself, otherwise Coverity complains. for (wip2 = buf->b_wininfo; wip2 != NULL; wip2 = wip2->wi_next) - if (wip2->wi_win == NULL) + if (wip2 != wip && wip2->wi_win == NULL) { if (wip2->wi_next != NULL) wip2->wi_next->wi_prev = wip2->wi_prev; -- 2.31.1