CVE-2026-47167 vim: Code Injection in cucumber filetype plugin

Resolves: RHEL-185864
This commit is contained in:
Zdenek Dohnal 2026-07-16 15:24:07 +02:00
parent 82edcac8aa
commit f938f4060d
2 changed files with 61 additions and 1 deletions

View File

@ -0,0 +1,52 @@
diff -up vim91/runtime/ftplugin/cucumber.vim.cucumber-code-inject vim91/runtime/ftplugin/cucumber.vim
--- vim91/runtime/ftplugin/cucumber.vim.cucumber-code-inject 2024-02-09 06:33:54.000000000 +0100
+++ vim91/runtime/ftplugin/cucumber.vim 2026-06-30 15:39:27.581293444 +0200
@@ -96,7 +96,8 @@ function! s:stepmatch(receiver,target)
catch
endtry
if has("ruby") && pattern !~ '\\\@<!#{'
- ruby VIM.command("return #{if (begin; Kernel.eval('/'+VIM.evaluate('pattern')+'/'); rescue SyntaxError; end) === VIM.evaluate('a:target') then 1 else 0 end}")
+ " Use Regexp.new, so the pattern stays untrusted data and cannot inject Ruby
+ ruby VIM.command("return #{if (begin; Regexp.new(VIM.evaluate('pattern')); rescue RegexpError; end) === VIM.evaluate('a:target') then 1 else 0 end}")
else
return 0
endif
diff -up vim91/src/testdir/test_filetype.vim.cucumber-code-inject vim91/src/testdir/test_filetype.vim
--- vim91/src/testdir/test_filetype.vim.cucumber-code-inject 2024-02-09 06:33:54.000000000 +0100
+++ vim91/src/testdir/test_filetype.vim 2026-06-30 15:39:58.032115889 +0200
@@ -2413,4 +2413,35 @@ func Test_def_file()
filetype off
endfunc
+func Test_cucumber_code_injection()
+ source check.vim
+ CheckFeature ruby
+ filetype plugin on
+
+ call mkdir('Xcucu/features/step_definitions', 'pR')
+ call writefile([
+ \ 'Feature: demo',
+ \ ' Scenario: trigger',
+ \ ' Given xyzzy',
+ \ ], 'Xcucu/features/test.feature')
+ let marker = getcwd() . '/Xcucu/MARKER'
+ " Malicious step: terminates the regex literal, injects Ruby system(),
+ " comments the trailing slash. With the fix, the pattern is passed to
+ " Regexp.new() instead of Kernel.eval() and the payload is inert.
+ call writefile([
+ \ 'Given /xyzzy/; system("touch ' . marker . '"); #/ do',
+ \ 'end',
+ \ ], 'Xcucu/features/step_definitions/poc.rb')
+
+ new Xcucu/features/test.feature
+ call assert_equal('cucumber', &filetype)
+ call cursor(3, 1)
+ " Triggers s:jump -> s:steps -> s:stepmatch on every discovered step,
+ " including the malicious one. Suppress preview and error messages.
+ silent! normal [d
+ call assert_false(filereadable(marker), 'Ruby injection executed')
+ bwipe!
+ filetype plugin off
+endfunc
+
" vim: shiftwidth=2 sts=2 expandtab

View File

@ -51,7 +51,7 @@ Summary: The VIM editor
URL: http://www.vim.org/
Name: vim
Version: %{baseversion}.%{patchlevel}
Release: 14%{?dist}
Release: 15%{?dist}
Epoch: 2
# swift.vim contains Apache 2.0 with runtime library exception:
# which is taken as Apache-2.0 WITH Swift-exception - reported to legal as https://gitlab.com/fedora/legal/fedora-license-data/-/issues/188
@ -155,6 +155,10 @@ Patch3022: 0001-patch-9.2.0277-tests-test_modeline.vim-fails.patch
# https://redhat.atlassian.net/browse/RHEL-178241
# https://github.com/vim/vim/commit/3fb5e58fbc63d86a3e65f1a141b0d67af2aa38a1
Patch3023: 0001-patch-9.2.0479-security-runtime-tar-command-injectio.patch
# RHEL-185864 CVE-2026-47167 vim: Code Injection in cucumber filetype plugin
# https://redhat.atlassian.net/browse/RHEL-185864
# https://github.com/vim/vim/commit/a65a52d684bc58535ad28a4ae824d22e76399934
Patch3024: 0001-patch-9.2.0496-security-Code-Injection-in-cucumber-f.patch
# uses autoconf in spec file
@ -496,6 +500,7 @@ perl -pi -e "s,bin/nawk,bin/awk,g" runtime/tools/mve.awk
%patch -P 3021 -p1 -b .modeline-bypass
%patch -P 3022 -p1 -b .modeline-tests
%patch -P 3023 -p1 -b .tar-cmd-inject
%patch -P 3024 -p1 -b .cucumber-code-inject
%build
cd src
@ -1126,6 +1131,9 @@ touch %{buildroot}/%{_datadir}/%{name}/vimfiles/doc/tags
%changelog
* Thu Jul 16 2026 Zdenek Dohnal <zdohnal@redhat.com> - 2:9.1.083-15
- RHEL-185864 CVE-2026-47167 vim: Code Injection in cucumber filetype plugin
* Thu Jul 16 2026 Zdenek Dohnal <zdohnal@redhat.com> - 2:9.1.083-14
- RHEL-178241 CVE-2026-46483 vim: command injection in tar plugin