From 8cbdb24e2b3b4e8acdc99ee9bf7f282c3228a1e6 Mon Sep 17 00:00:00 2001 From: Yaakov Selkowitz Date: Sun, 24 Dec 2023 15:14:28 -0500 Subject: [PATCH] Fix for https://fedoraproject.org/wiki/Changes/PortingToModernC https://github.com/vhostmd/vhostmd/pull/13 --- 0020-implicit-function-declarations.patch | 74 +++++++++++++++++++++++ vhostmd.spec | 2 + 2 files changed, 76 insertions(+) create mode 100644 0020-implicit-function-declarations.patch diff --git a/0020-implicit-function-declarations.patch b/0020-implicit-function-declarations.patch new file mode 100644 index 0000000..37d0272 --- /dev/null +++ b/0020-implicit-function-declarations.patch @@ -0,0 +1,74 @@ +From cf555d3bf079ff60b363dba4dc48a349dce5d3b4 Mon Sep 17 00:00:00 2001 +From: Yaakov Selkowitz +Date: Sun, 24 Dec 2023 14:54:09 -0500 +Subject: [PATCH] Fix implicit declarations +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Errors raised in Fedora rawhide and ELN which have added the +-Werror=implicit-function-declaration flag for C: + +virt-util.c:96:9: error: implicit declaration of function ‘calloc’ +virt-util.c:129:10: error: implicit declaration of function ‘free’ + +virtio.c:160:9: error: implicit declaration of function ‘free’ +virtio.c:254:31: error: implicit declaration of function ‘bsearch’ +virtio.c:259:13: error: implicit declaration of function ‘qsort’ +virtio.c:586:33: error: implicit declaration of function ‘calloc’ + +libmetrics.c:136:28: error: implicit declaration of function 'atoi' +libmetrics.c:142:29: error: implicit declaration of function 'atoll' +libmetrics.c:148:28: error: implicit declaration of function 'atof' +libmetrics.c:170:12: error: implicit declaration of function 'calloc' +libmetrics.c:189:12: error: implicit declaration of function 'free' +libmetrics.c:311:7: error: implicit declaration of function 'posix_memalign' +libmetrics.c:385:26: error: implicit declaration of function 'malloc' +libmetrics.c:848:28: error: implicit declaration of function 'realloc' + +Signed-off-by: Yaakov Selkowitz +--- + libmetrics/libmetrics.c | 1 + + vhostmd/virt-util.c | 1 + + vhostmd/virtio.c | 1 + + 3 files changed, 3 insertions(+) + +diff --git a/libmetrics/libmetrics.c b/libmetrics/libmetrics.c +index 8819074..c83fd03 100644 +--- a/libmetrics/libmetrics.c ++++ b/libmetrics/libmetrics.c +@@ -21,6 +21,7 @@ + #include + + #include ++#include + #include + #include + #include +diff --git a/vhostmd/virt-util.c b/vhostmd/virt-util.c +index a94cccd..40765c3 100644 +--- a/vhostmd/virt-util.c ++++ b/vhostmd/virt-util.c +@@ -21,6 +21,7 @@ + #include + + #include ++#include + #include + #include + +diff --git a/vhostmd/virtio.c b/vhostmd/virtio.c +index a6c2515..98340ce 100644 +--- a/vhostmd/virtio.c ++++ b/vhostmd/virtio.c +@@ -30,6 +30,7 @@ + #include + #include + #include ++#include + #include + + #include "util.h" +-- +2.43.0 + diff --git a/vhostmd.spec b/vhostmd.spec index 95f39a4..d5db983 100644 --- a/vhostmd.spec +++ b/vhostmd.spec @@ -33,6 +33,8 @@ Patch0016: 0016-vhostmd-Check-return-value-of-file-functions.patch Patch0017: 0017-vhostmd-Check-for-valide-file-handle-before-calling-.patch Patch0018: 0018-vhostmd-Fix-memory-leak-in-vhostmd_run.patch Patch0019: 0019-virtio-Fix-strncpy-length-parameter.patch +# https://github.com/vhostmd/vhostmd/pull/13 +Patch0020: 0020-implicit-function-declarations.patch BuildRequires: make BuildRequires: gcc