diff --git a/.gitignore b/.gitignore index bdcd201..60095ef 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1 @@ -SOURCES/velocity-1.7.tar.gz +SOURCES/velocity-2.3.tar.gz diff --git a/.velocity.metadata b/.velocity.metadata index d971a3a..a796706 100644 --- a/.velocity.metadata +++ b/.velocity.metadata @@ -1 +1 @@ -ac76c23153cd2214591b6783f255ad210467b2f8 SOURCES/velocity-1.7.tar.gz +c7f19c2d5dac64f5c617465ddca8eb8b24acdaf5 SOURCES/velocity-2.3.tar.gz diff --git a/SOURCES/0001-Don-t-use-Werken-XPath.patch b/SOURCES/0001-Don-t-use-Werken-XPath.patch deleted file mode 100644 index b754573..0000000 --- a/SOURCES/0001-Don-t-use-Werken-XPath.patch +++ /dev/null @@ -1,165 +0,0 @@ -From 8a9344f55d74a5b809051ae144b3c028499fec0d Mon Sep 17 00:00:00 2001 -From: Mikolaj Izdebski -Date: Sat, 27 Sep 2013 10:53:46 +0200 -Subject: [PATCH] Don't use Werken XPath - ---- - src/java/org/apache/velocity/anakia/AnakiaElement.java | 7 +++++-- - src/java/org/apache/velocity/anakia/NodeList.java | 6 ++++-- - src/java/org/apache/velocity/anakia/XPathCache.java | 9 ++++++--- - src/java/org/apache/velocity/anakia/XPathTool.java | 16 ++++++++++------ - 4 files changed, 25 insertions(+), 13 deletions(-) - -diff --git a/src/java/org/apache/velocity/anakia/AnakiaElement.java b/src/java/org/apache/velocity/anakia/AnakiaElement.java -index c72b653..df13153 100644 ---- a/src/java/org/apache/velocity/anakia/AnakiaElement.java -+++ b/src/java/org/apache/velocity/anakia/AnakiaElement.java -@@ -20,8 +20,10 @@ package org.apache.velocity.anakia; - */ - - import org.jdom.Element; -+import org.jdom.JDOMException; - import org.jdom.Namespace; - import org.jdom.output.XMLOutputter; -+ - import java.util.List; - - /** -@@ -126,10 +128,11 @@ public class AnakiaElement extends Element - * @param xpathExpression the XPath expression you wish to apply - * @return a NodeList representing the nodes that are the result of - * application of the XPath to the current element. It can be empty. -+ * @throws JDOMException - */ -- public NodeList selectNodes(String xpathExpression) -+ public NodeList selectNodes(String xpathExpression) throws JDOMException - { -- return new NodeList(XPathCache.getXPath(xpathExpression).applyTo(this), false); -+ return new NodeList(XPathCache.getXPath(xpathExpression).selectNodes(this), false); - } - - /** -diff --git a/src/java/org/apache/velocity/anakia/NodeList.java b/src/java/org/apache/velocity/anakia/NodeList.java -index daf611d..b303bda 100644 ---- a/src/java/org/apache/velocity/anakia/NodeList.java -+++ b/src/java/org/apache/velocity/anakia/NodeList.java -@@ -35,6 +35,7 @@ import org.jdom.DocType; - import org.jdom.Document; - import org.jdom.Element; - import org.jdom.EntityRef; -+import org.jdom.JDOMException; - import org.jdom.ProcessingInstruction; - import org.jdom.Text; - import org.jdom.output.XMLOutputter; -@@ -289,10 +290,11 @@ public class NodeList implements List, Cloneable - * @param xpathString the XPath expression you wish to apply - * @return a NodeList representing the nodes that are the result of - * application of the XPath to the current node list. It can be empty. -+ * @throws JDOMException - */ -- public NodeList selectNodes(String xpathString) -+ public NodeList selectNodes(String xpathString) throws JDOMException - { -- return new NodeList(XPathCache.getXPath(xpathString).applyTo(nodes), false); -+ return new NodeList(XPathCache.getXPath(xpathString).selectNodes(nodes), false); - } - - // List methods implemented hereafter -diff --git a/src/java/org/apache/velocity/anakia/XPathCache.java b/src/java/org/apache/velocity/anakia/XPathCache.java -index cef43d9..0d633b0 100644 ---- a/src/java/org/apache/velocity/anakia/XPathCache.java -+++ b/src/java/org/apache/velocity/anakia/XPathCache.java -@@ -19,7 +19,9 @@ package org.apache.velocity.anakia; - * under the License. - */ - --import com.werken.xpath.XPath; -+import org.jdom.JDOMException; -+import org.jdom.xpath.XPath; -+ - import java.util.Map; - import java.util.WeakHashMap; - -@@ -46,8 +48,9 @@ class XPathCache - * A cached object is returned if it already exists for the requested expression. - * @param xpathString the XPath expression to parse - * @return the XPath object that represents the parsed XPath expression. -+ * @throws JDOMException - */ -- static XPath getXPath(String xpathString) -+ static XPath getXPath(String xpathString) throws JDOMException - { - XPath xpath = null; - synchronized(XPATH_CACHE) -@@ -55,7 +58,7 @@ class XPathCache - xpath = (XPath)XPATH_CACHE.get(xpathString); - if(xpath == null) - { -- xpath = new XPath(xpathString); -+ xpath = XPath.newInstance(xpathString); - XPATH_CACHE.put(xpathString, xpath); - } - } -diff --git a/src/java/org/apache/velocity/anakia/XPathTool.java b/src/java/org/apache/velocity/anakia/XPathTool.java -index c9e6178..f85d2c1 100644 ---- a/src/java/org/apache/velocity/anakia/XPathTool.java -+++ b/src/java/org/apache/velocity/anakia/XPathTool.java -@@ -23,6 +23,7 @@ import java.util.List; - - import org.jdom.Document; - import org.jdom.Element; -+import org.jdom.JDOMException; - - /** - * This class adds an entrypoint into XPath functionality, -@@ -88,12 +89,13 @@ public class XPathTool - * @param doc The Document context - * - * @return A list of selected nodes -+ * @throws JDOMException - */ - public NodeList applyTo(String xpathSpec, -- Document doc) -+ Document doc) throws JDOMException - { - //RuntimeSingleton.info("XPathTool::applyTo(String, Document)"); -- return new NodeList(XPathCache.getXPath(xpathSpec).applyTo( doc ), false); -+ return new NodeList(XPathCache.getXPath(xpathSpec).selectNodes( doc ), false); - } - - /** -@@ -103,12 +105,13 @@ public class XPathTool - * @param elem The Element context - * - * @return A list of selected nodes -+ * @throws JDOMException - */ - public NodeList applyTo(String xpathSpec, -- Element elem) -+ Element elem) throws JDOMException - { - //RuntimeSingleton.info("XPathTool::applyTo(String, Element)"); -- return new NodeList(XPathCache.getXPath(xpathSpec).applyTo( elem ), false); -+ return new NodeList(XPathCache.getXPath(xpathSpec).selectNodes( elem ), false); - } - - /** -@@ -118,12 +121,13 @@ public class XPathTool - * @param nodeSet The nodeset context - * - * @return A list of selected nodes -+ * @throws JDOMException - */ - public NodeList applyTo(String xpathSpec, -- List nodeSet) -+ List nodeSet) throws JDOMException - { - //RuntimeSingleton.info("XPathTool::applyTo(String, List)"); -- return new NodeList(XPathCache.getXPath(xpathSpec).applyTo( nodeSet ), false); -+ return new NodeList(XPathCache.getXPath(xpathSpec).selectNodes( nodeSet ), false); - } - } - --- -1.8.3.1 - diff --git a/SOURCES/0001-Port-to-apache-commons-lang3.patch b/SOURCES/0001-Port-to-apache-commons-lang3.patch deleted file mode 100644 index c4247c4..0000000 --- a/SOURCES/0001-Port-to-apache-commons-lang3.patch +++ /dev/null @@ -1,464 +0,0 @@ -From afc1005f123933e3441833651a558ab88d7cbee4 Mon Sep 17 00:00:00 2001 -From: Marian Koncek -Date: Thu, 31 Oct 2019 14:35:40 +0100 -Subject: [PATCH] Port to apache-commons-lang3 - ---- - pom.xml | 6 +++--- - .../velocity/app/event/implement/EscapeHtmlReference.java | 4 ++-- - .../app/event/implement/EscapeJavaScriptReference.java | 4 ++-- - .../velocity/app/event/implement/EscapeSqlReference.java | 5 +++-- - .../velocity/app/event/implement/EscapeXmlReference.java | 2 +- - src/java/org/apache/velocity/runtime/RuntimeInstance.java | 2 +- - .../org/apache/velocity/runtime/VelocimacroFactory.java | 2 +- - src/java/org/apache/velocity/runtime/directive/Block.java | 2 +- - .../org/apache/velocity/runtime/directive/RuntimeMacro.java | 2 +- - src/java/org/apache/velocity/runtime/parser/Parser.java | 2 +- - .../apache/velocity/runtime/parser/ParserTokenManager.java | 2 +- - .../apache/velocity/runtime/parser/node/ASTDirective.java | 2 +- - .../org/apache/velocity/runtime/parser/node/ASTMethod.java | 4 ++-- - .../velocity/runtime/parser/node/ASTStringLiteral.java | 2 +- - .../org/apache/velocity/runtime/parser/node/NodeUtils.java | 2 +- - .../velocity/runtime/parser/node/PropertyExecutor.java | 2 +- - .../velocity/runtime/parser/node/SetPropertyExecutor.java | 4 ++-- - .../org/apache/velocity/runtime/parser/node/SimpleNode.java | 4 ++-- - .../velocity/runtime/resource/ResourceManagerImpl.java | 4 ++-- - .../runtime/resource/loader/ClasspathResourceLoader.java | 2 +- - .../runtime/resource/loader/DataSourceResourceLoader.java | 2 +- - .../runtime/resource/loader/FileResourceLoader.java | 2 +- - .../velocity/runtime/resource/loader/JarResourceLoader.java | 2 +- - .../runtime/resource/loader/StringResourceLoader.java | 2 +- - .../velocity/runtime/resource/loader/URLResourceLoader.java | 2 +- - .../org/apache/velocity/util/introspection/ClassMap.java | 2 +- - .../org/apache/velocity/io/UnicodeInputStreamTestCase.java | 2 +- - src/test/org/apache/velocity/test/BaseTestCase.java | 2 +- - .../org/apache/velocity/test/MethodCacheKeyTestCase.java | 2 +- - 29 files changed, 39 insertions(+), 38 deletions(-) - -diff --git a/pom.xml b/pom.xml -index e2c7004..273fc9d 100644 ---- a/pom.xml -+++ b/pom.xml -@@ -143,9 +143,9 @@ - 3.2.1 - - -- commons-lang -- commons-lang -- 2.4 -+ org.apache.commons -+ commons-lang3 -+ 3.9 - - - oro -diff --git a/src/java/org/apache/velocity/app/event/implement/EscapeHtmlReference.java b/src/java/org/apache/velocity/app/event/implement/EscapeHtmlReference.java -index 6d98b45..e146995 100644 ---- a/src/java/org/apache/velocity/app/event/implement/EscapeHtmlReference.java -+++ b/src/java/org/apache/velocity/app/event/implement/EscapeHtmlReference.java -@@ -19,7 +19,7 @@ package org.apache.velocity.app.event.implement; - * under the License. - */ - --import org.apache.commons.lang.StringEscapeUtils; -+import org.apache.commons.lang3.StringEscapeUtils; - - /** - * Escape all HTML entities. -@@ -39,7 +39,7 @@ public class EscapeHtmlReference extends EscapeReference - */ - protected String escape(Object text) - { -- return StringEscapeUtils.escapeHtml(text.toString()); -+ return StringEscapeUtils.escapeHtml4(text.toString()); - } - - /** -diff --git a/src/java/org/apache/velocity/app/event/implement/EscapeJavaScriptReference.java b/src/java/org/apache/velocity/app/event/implement/EscapeJavaScriptReference.java -index ea49ddb..12f38f4 100644 ---- a/src/java/org/apache/velocity/app/event/implement/EscapeJavaScriptReference.java -+++ b/src/java/org/apache/velocity/app/event/implement/EscapeJavaScriptReference.java -@@ -19,7 +19,7 @@ package org.apache.velocity.app.event.implement; - * under the License. - */ - --import org.apache.commons.lang.StringEscapeUtils; -+import org.apache.commons.lang3.StringEscapeUtils; - - /** - * Escapes the characters in a String to be suitable for use in JavaScript. -@@ -39,7 +39,7 @@ public class EscapeJavaScriptReference extends EscapeReference - */ - protected String escape(Object text) - { -- return StringEscapeUtils.escapeJavaScript(text.toString()); -+ return StringEscapeUtils.escapeEcmaScript(text.toString()); - } - - /** -diff --git a/src/java/org/apache/velocity/app/event/implement/EscapeSqlReference.java b/src/java/org/apache/velocity/app/event/implement/EscapeSqlReference.java -index 585cb6c..39e04f4 100644 ---- a/src/java/org/apache/velocity/app/event/implement/EscapeSqlReference.java -+++ b/src/java/org/apache/velocity/app/event/implement/EscapeSqlReference.java -@@ -19,7 +19,7 @@ package org.apache.velocity.app.event.implement; - * under the License. - */ - --import org.apache.commons.lang.StringEscapeUtils; -+import org.apache.commons.lang3.StringUtils; - - /** - * Escapes the characters in a String to be suitable to pass to an SQL query. -@@ -39,7 +39,8 @@ public class EscapeSqlReference extends EscapeReference - */ - protected String escape(Object text) - { -- return StringEscapeUtils.escapeSql(text.toString()); -+ // See https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/StringEscapeUtils.html#escapeSql(java.lang.String) -+ return StringUtils.replace(text.toString(), "'", "''"); - } - - /** -diff --git a/src/java/org/apache/velocity/app/event/implement/EscapeXmlReference.java b/src/java/org/apache/velocity/app/event/implement/EscapeXmlReference.java -index 3d5b40f..fbb525c 100644 ---- a/src/java/org/apache/velocity/app/event/implement/EscapeXmlReference.java -+++ b/src/java/org/apache/velocity/app/event/implement/EscapeXmlReference.java -@@ -19,7 +19,7 @@ package org.apache.velocity.app.event.implement; - * under the License. - */ - --import org.apache.commons.lang.StringEscapeUtils; -+import org.apache.commons.lang3.StringEscapeUtils; - - /** - * Escape all XML entities. -diff --git a/src/java/org/apache/velocity/runtime/RuntimeInstance.java b/src/java/org/apache/velocity/runtime/RuntimeInstance.java -index bf99faa..a79d42c 100644 ---- a/src/java/org/apache/velocity/runtime/RuntimeInstance.java -+++ b/src/java/org/apache/velocity/runtime/RuntimeInstance.java -@@ -32,7 +32,7 @@ import java.util.Map; - import java.util.Properties; - - import org.apache.commons.collections.ExtendedProperties; --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.Template; - import org.apache.velocity.app.event.EventCartridge; - import org.apache.velocity.app.event.EventHandler; -diff --git a/src/java/org/apache/velocity/runtime/VelocimacroFactory.java b/src/java/org/apache/velocity/runtime/VelocimacroFactory.java -index 2737b3b..956ab05 100644 ---- a/src/java/org/apache/velocity/runtime/VelocimacroFactory.java -+++ b/src/java/org/apache/velocity/runtime/VelocimacroFactory.java -@@ -26,7 +26,7 @@ import java.util.Map; - import java.util.Vector; - import java.util.ArrayList; - --import org.apache.commons.lang.StringUtils; -+import org.apache.commons.lang3.StringUtils; - import org.apache.velocity.Template; - import org.apache.velocity.exception.VelocityException; - import org.apache.velocity.runtime.directive.Directive; -diff --git a/src/java/org/apache/velocity/runtime/directive/Block.java b/src/java/org/apache/velocity/runtime/directive/Block.java -index f5fdfa8..b136543 100644 ---- a/src/java/org/apache/velocity/runtime/directive/Block.java -+++ b/src/java/org/apache/velocity/runtime/directive/Block.java -@@ -23,7 +23,7 @@ import java.io.IOException; - import java.io.StringWriter; - import java.io.Writer; - --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.context.InternalContextAdapter; - import org.apache.velocity.exception.TemplateInitException; - import org.apache.velocity.runtime.Renderable; -diff --git a/src/java/org/apache/velocity/runtime/directive/RuntimeMacro.java b/src/java/org/apache/velocity/runtime/directive/RuntimeMacro.java -index 090b552..d22ac4e 100644 ---- a/src/java/org/apache/velocity/runtime/directive/RuntimeMacro.java -+++ b/src/java/org/apache/velocity/runtime/directive/RuntimeMacro.java -@@ -23,7 +23,7 @@ import java.io.IOException; - import java.io.Writer; - import java.util.List; - --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.context.InternalContextAdapter; - import org.apache.velocity.exception.MethodInvocationException; - import org.apache.velocity.exception.ParseErrorException; -diff --git a/src/java/org/apache/velocity/runtime/parser/Parser.java b/src/java/org/apache/velocity/runtime/parser/Parser.java -index 085e7a4..62dfe48 100644 ---- a/src/java/org/apache/velocity/runtime/parser/Parser.java -+++ b/src/java/org/apache/velocity/runtime/parser/Parser.java -@@ -10,7 +10,7 @@ import org.apache.velocity.runtime.directive.Directive; - import org.apache.velocity.runtime.directive.Macro; - import org.apache.velocity.runtime.directive.MacroParseException; - import org.apache.velocity.util.StringUtils; --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.runtime.RuntimeConstants; - - /** -diff --git a/src/java/org/apache/velocity/runtime/parser/ParserTokenManager.java b/src/java/org/apache/velocity/runtime/parser/ParserTokenManager.java -index ce00d99..9563a1f 100644 ---- a/src/java/org/apache/velocity/runtime/parser/ParserTokenManager.java -+++ b/src/java/org/apache/velocity/runtime/parser/ParserTokenManager.java -@@ -9,7 +9,7 @@ import org.apache.velocity.runtime.directive.Directive; - import org.apache.velocity.runtime.directive.Macro; - import org.apache.velocity.runtime.directive.MacroParseException; - import org.apache.velocity.util.StringUtils; --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.runtime.RuntimeConstants; - - /** Token Manager. */ -diff --git a/src/java/org/apache/velocity/runtime/parser/node/ASTDirective.java b/src/java/org/apache/velocity/runtime/parser/node/ASTDirective.java -index 86e86b7..f1ab78d 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/ASTDirective.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/ASTDirective.java -@@ -22,7 +22,7 @@ package org.apache.velocity.runtime.parser.node; - import java.io.IOException; - import java.io.Writer; - --import org.apache.commons.lang.builder.ToStringBuilder; -+import org.apache.commons.lang3.builder.ToStringBuilder; - import org.apache.velocity.context.InternalContextAdapter; - import org.apache.velocity.exception.MethodInvocationException; - import org.apache.velocity.exception.ParseErrorException; -diff --git a/src/java/org/apache/velocity/runtime/parser/node/ASTMethod.java b/src/java/org/apache/velocity/runtime/parser/node/ASTMethod.java -index a1545e5..7354c9a 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/ASTMethod.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/ASTMethod.java -@@ -21,8 +21,8 @@ package org.apache.velocity.runtime.parser.node; - - import java.lang.reflect.InvocationTargetException; - --import org.apache.commons.lang.ArrayUtils; --import org.apache.commons.lang.StringUtils; -+import org.apache.commons.lang3.ArrayUtils; -+import org.apache.commons.lang3.StringUtils; - import org.apache.velocity.app.event.EventHandlerUtil; - import org.apache.velocity.context.InternalContextAdapter; - import org.apache.velocity.exception.MethodInvocationException; -diff --git a/src/java/org/apache/velocity/runtime/parser/node/ASTStringLiteral.java b/src/java/org/apache/velocity/runtime/parser/node/ASTStringLiteral.java -index bb56cd9..0bc63bc 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/ASTStringLiteral.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/ASTStringLiteral.java -@@ -21,7 +21,7 @@ import java.io.IOException; - import java.io.StringReader; - import java.io.StringWriter; - --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.context.InternalContextAdapter; - import org.apache.velocity.exception.TemplateInitException; - import org.apache.velocity.exception.VelocityException; -diff --git a/src/java/org/apache/velocity/runtime/parser/node/NodeUtils.java b/src/java/org/apache/velocity/runtime/parser/node/NodeUtils.java -index 52bcda9..8362c3e 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/NodeUtils.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/NodeUtils.java -@@ -19,7 +19,7 @@ package org.apache.velocity.runtime.parser.node; - * under the License. - */ - --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.context.Context; - import org.apache.velocity.exception.MethodInvocationException; - import org.apache.velocity.runtime.parser.ParserConstants; -diff --git a/src/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java b/src/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java -index 8c78228..20d6c18 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java -@@ -21,7 +21,7 @@ package org.apache.velocity.runtime.parser.node; - - import java.lang.reflect.InvocationTargetException; - --import org.apache.commons.lang.StringUtils; -+import org.apache.commons.lang3.StringUtils; - import org.apache.velocity.exception.VelocityException; - import org.apache.velocity.runtime.RuntimeLogger; - import org.apache.velocity.runtime.log.Log; -diff --git a/src/java/org/apache/velocity/runtime/parser/node/SetPropertyExecutor.java b/src/java/org/apache/velocity/runtime/parser/node/SetPropertyExecutor.java -index 0b27b45..ba5d512 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/SetPropertyExecutor.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/SetPropertyExecutor.java -@@ -21,8 +21,8 @@ package org.apache.velocity.runtime.parser.node; - - import java.lang.reflect.InvocationTargetException; - --import org.apache.commons.lang.StringUtils; --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.StringUtils; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.exception.VelocityException; - import org.apache.velocity.runtime.log.Log; - import org.apache.velocity.util.introspection.Introspector; -diff --git a/src/java/org/apache/velocity/runtime/parser/node/SimpleNode.java b/src/java/org/apache/velocity/runtime/parser/node/SimpleNode.java -index 108846f..6372830 100644 ---- a/src/java/org/apache/velocity/runtime/parser/node/SimpleNode.java -+++ b/src/java/org/apache/velocity/runtime/parser/node/SimpleNode.java -@@ -22,8 +22,8 @@ package org.apache.velocity.runtime.parser.node; - import java.io.IOException; - import java.io.Writer; - --import org.apache.commons.lang.builder.ToStringBuilder; --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.builder.ToStringBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.context.InternalContextAdapter; - import org.apache.velocity.exception.MethodInvocationException; - import org.apache.velocity.exception.ParseErrorException; -diff --git a/src/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java b/src/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java -index 1b504eb..b33d4ed 100644 ---- a/src/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java -+++ b/src/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java -@@ -158,7 +158,7 @@ public class ResourceManagerImpl - - Object cacheObject = null; - -- if (org.apache.commons.lang.StringUtils.isNotEmpty(cacheClassName)) -+ if (org.apache.commons.lang3.StringUtils.isNotEmpty(cacheClassName)) - { - try - { -@@ -534,7 +534,7 @@ public class ResourceManagerImpl - * this strikes me as bad... - */ - -- if (!org.apache.commons.lang.StringUtils.equals(resource.getEncoding(), encoding)) -+ if (!org.apache.commons.lang3.StringUtils.equals(resource.getEncoding(), encoding)) - { - log.warn("Declared encoding for template '" + - resource.getName() + -diff --git a/src/java/org/apache/velocity/runtime/resource/loader/ClasspathResourceLoader.java b/src/java/org/apache/velocity/runtime/resource/loader/ClasspathResourceLoader.java -index 623766f..a7cc276 100644 ---- a/src/java/org/apache/velocity/runtime/resource/loader/ClasspathResourceLoader.java -+++ b/src/java/org/apache/velocity/runtime/resource/loader/ClasspathResourceLoader.java -@@ -22,7 +22,7 @@ package org.apache.velocity.runtime.resource.loader; - import java.io.InputStream; - - import org.apache.commons.collections.ExtendedProperties; --import org.apache.commons.lang.StringUtils; -+import org.apache.commons.lang3.StringUtils; - import org.apache.velocity.exception.ResourceNotFoundException; - import org.apache.velocity.runtime.resource.Resource; - import org.apache.velocity.util.ClassUtils; -diff --git a/src/java/org/apache/velocity/runtime/resource/loader/DataSourceResourceLoader.java b/src/java/org/apache/velocity/runtime/resource/loader/DataSourceResourceLoader.java -index 833e0ac..7414913 100644 ---- a/src/java/org/apache/velocity/runtime/resource/loader/DataSourceResourceLoader.java -+++ b/src/java/org/apache/velocity/runtime/resource/loader/DataSourceResourceLoader.java -@@ -218,7 +218,7 @@ public class DataSourceResourceLoader extends ResourceLoader - public synchronized InputStream getResourceStream(final String name) - throws ResourceNotFoundException - { -- if (org.apache.commons.lang.StringUtils.isEmpty(name)) -+ if (org.apache.commons.lang3.StringUtils.isEmpty(name)) - { - throw new ResourceNotFoundException("DataSourceResourceLoader: Template name was empty or null"); - } -diff --git a/src/java/org/apache/velocity/runtime/resource/loader/FileResourceLoader.java b/src/java/org/apache/velocity/runtime/resource/loader/FileResourceLoader.java -index 462ed16..3898889 100644 ---- a/src/java/org/apache/velocity/runtime/resource/loader/FileResourceLoader.java -+++ b/src/java/org/apache/velocity/runtime/resource/loader/FileResourceLoader.java -@@ -118,7 +118,7 @@ public class FileResourceLoader extends ResourceLoader - /* - * Make sure we have a valid templateName. - */ -- if (org.apache.commons.lang.StringUtils.isEmpty(templateName)) -+ if (org.apache.commons.lang3.StringUtils.isEmpty(templateName)) - { - /* - * If we don't get a properly formed templateName then -diff --git a/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java b/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java -index 172384e..b7fb1a7 100644 ---- a/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java -+++ b/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java -@@ -195,7 +195,7 @@ public class JarResourceLoader extends ResourceLoader - { - InputStream results = null; - -- if (org.apache.commons.lang.StringUtils.isEmpty(source)) -+ if (org.apache.commons.lang3.StringUtils.isEmpty(source)) - { - throw new ResourceNotFoundException("Need to have a resource!"); - } -diff --git a/src/java/org/apache/velocity/runtime/resource/loader/StringResourceLoader.java b/src/java/org/apache/velocity/runtime/resource/loader/StringResourceLoader.java -index 895182d..41c0ec9 100644 ---- a/src/java/org/apache/velocity/runtime/resource/loader/StringResourceLoader.java -+++ b/src/java/org/apache/velocity/runtime/resource/loader/StringResourceLoader.java -@@ -26,7 +26,7 @@ import java.io.ByteArrayInputStream; - import java.io.InputStream; - import java.io.UnsupportedEncodingException; - import org.apache.commons.collections.ExtendedProperties; --import org.apache.commons.lang.StringUtils; -+import org.apache.commons.lang3.StringUtils; - import org.apache.velocity.exception.ResourceNotFoundException; - import org.apache.velocity.exception.VelocityException; - import org.apache.velocity.runtime.resource.Resource; -diff --git a/src/java/org/apache/velocity/runtime/resource/loader/URLResourceLoader.java b/src/java/org/apache/velocity/runtime/resource/loader/URLResourceLoader.java -index de06636..74ab86a 100644 ---- a/src/java/org/apache/velocity/runtime/resource/loader/URLResourceLoader.java -+++ b/src/java/org/apache/velocity/runtime/resource/loader/URLResourceLoader.java -@@ -26,7 +26,7 @@ import java.net.URL; - import java.net.URLConnection; - import java.util.HashMap; - import org.apache.commons.collections.ExtendedProperties; --import org.apache.commons.lang.StringUtils; -+import org.apache.commons.lang3.StringUtils; - import org.apache.velocity.exception.VelocityException; - import org.apache.velocity.exception.ResourceNotFoundException; - import org.apache.velocity.runtime.resource.Resource; -diff --git a/src/java/org/apache/velocity/util/introspection/ClassMap.java b/src/java/org/apache/velocity/util/introspection/ClassMap.java -index 66bc7b1..77c1c8b 100644 ---- a/src/java/org/apache/velocity/util/introspection/ClassMap.java -+++ b/src/java/org/apache/velocity/util/introspection/ClassMap.java -@@ -23,7 +23,7 @@ import java.lang.reflect.Method; - import java.lang.reflect.Modifier; - import java.util.HashMap; - import java.util.Map; --import org.apache.commons.lang.text.StrBuilder; -+import org.apache.commons.lang3.text.StrBuilder; - import org.apache.velocity.runtime.log.Log; - import org.apache.velocity.util.MapFactory; - -diff --git a/src/test/org/apache/velocity/io/UnicodeInputStreamTestCase.java b/src/test/org/apache/velocity/io/UnicodeInputStreamTestCase.java -index 3142f45..ff36682 100644 ---- a/src/test/org/apache/velocity/io/UnicodeInputStreamTestCase.java -+++ b/src/test/org/apache/velocity/io/UnicodeInputStreamTestCase.java -@@ -27,7 +27,7 @@ import junit.framework.Test; - import junit.framework.TestCase; - import junit.framework.TestSuite; - --import org.apache.commons.lang.ArrayUtils; -+import org.apache.commons.lang3.ArrayUtils; - - - /** -diff --git a/src/test/org/apache/velocity/test/BaseTestCase.java b/src/test/org/apache/velocity/test/BaseTestCase.java -index 9faf585..f893d0f 100644 ---- a/src/test/org/apache/velocity/test/BaseTestCase.java -+++ b/src/test/org/apache/velocity/test/BaseTestCase.java -@@ -353,7 +353,7 @@ public abstract class BaseTestCase extends TestCase implements TemplateTestBase - buf.append(baseFile.getPath()); - } - -- if (org.apache.commons.lang.StringUtils.isNotEmpty(ext)) -+ if (org.apache.commons.lang3.StringUtils.isNotEmpty(ext)) - { - buf.append('.').append(ext); - } -diff --git a/src/test/org/apache/velocity/test/MethodCacheKeyTestCase.java b/src/test/org/apache/velocity/test/MethodCacheKeyTestCase.java -index d1ad1db..e70c5f2 100644 ---- a/src/test/org/apache/velocity/test/MethodCacheKeyTestCase.java -+++ b/src/test/org/apache/velocity/test/MethodCacheKeyTestCase.java -@@ -21,7 +21,7 @@ package org.apache.velocity.test; - - import junit.framework.TestCase; - --import org.apache.commons.lang.ArrayUtils; -+import org.apache.commons.lang3.ArrayUtils; - import org.apache.velocity.runtime.parser.node.ASTMethod; - - /** --- -2.21.0 - diff --git a/SOURCES/0001-Remove-avalon-logkit.patch b/SOURCES/0001-Remove-avalon-logkit.patch deleted file mode 100644 index 2f09b03..0000000 --- a/SOURCES/0001-Remove-avalon-logkit.patch +++ /dev/null @@ -1,62 +0,0 @@ -From 1d2f89cb3e954b943751fa8dd587fdb404eb9338 Mon Sep 17 00:00:00 2001 -From: Stanislav Ochotnicky -Date: Mon, 21 Feb 2011 15:53:34 +0100 -Subject: [PATCH 1/3] Remove avalon-logkit - -we don't have it packaged so change defaults and remove it from pom.xml ---- - pom.xml | 6 ------ - .../velocity/runtime/defaults/velocity.properties | 4 ++-- - .../apache/velocity/runtime/log/LogManager.java | 2 +- - 3 files changed, 3 insertions(+), 9 deletions(-) - -diff --git a/pom.xml b/pom.xml -index 77a8e38..f453208 100644 ---- a/pom.xml -+++ b/pom.xml -@@ -197,12 +197,6 @@ - provided - - -- logkit -- logkit -- 2.0 -- provided -- -- - ant - ant - 1.6 -diff --git a/src/java/org/apache/velocity/runtime/defaults/velocity.properties b/src/java/org/apache/velocity/runtime/defaults/velocity.properties -index 750a59a..7fac119 100644 ---- a/src/java/org/apache/velocity/runtime/defaults/velocity.properties -+++ b/src/java/org/apache/velocity/runtime/defaults/velocity.properties -@@ -20,10 +20,10 @@ - # ---------------------------------------------------------------------------- - - # ---------------------------------------------------------------------------- --# default LogChute to use: default: AvalonLogChute, Log4JLogChute, CommonsLogLogChute, ServletLogChute, JdkLogChute -+# default LogChute to use: default: Log4JLogChute, CommonsLogLogChute, ServletLogChute, JdkLogChute - # ---------------------------------------------------------------------------- - --runtime.log.logsystem.class = org.apache.velocity.runtime.log.AvalonLogChute,org.apache.velocity.runtime.log.Log4JLogChute,org.apache.velocity.runtime.log.CommonsLogLogChute,org.apache.velocity.runtime.log.ServletLogChute,org.apache.velocity.runtime.log.JdkLogChute -+runtime.log.logsystem.class = org.apache.velocity.runtime.log.Log4JLogChute,org.apache.velocity.runtime.log.CommonsLogLogChute,org.apache.velocity.runtime.log.ServletLogChute,org.apache.velocity.runtime.log.JdkLogChute - - # --------------------------------------------------------------------------- - # This is the location of the Velocity Runtime log. -diff --git a/src/java/org/apache/velocity/runtime/log/LogManager.java b/src/java/org/apache/velocity/runtime/log/LogManager.java -index 19d1016..97dceef 100644 ---- a/src/java/org/apache/velocity/runtime/log/LogManager.java -+++ b/src/java/org/apache/velocity/runtime/log/LogManager.java -@@ -119,7 +119,7 @@ public class LogManager - * classes, and we use the first one we find. - * - * Note that the default value of this property contains the -- * AvalonLogChute, the Log4JLogChute, CommonsLogLogChute, -+ * Log4JLogChute, CommonsLogLogChute, - * ServletLogChute, and the JdkLogChute for - * convenience - so we use whichever we works first. - */ --- -1.7.4 - diff --git a/SOURCES/0001-Template-is-a-reserved-keyword-in-javacc.patch b/SOURCES/0001-Template-is-a-reserved-keyword-in-javacc.patch new file mode 100644 index 0000000..6132246 --- /dev/null +++ b/SOURCES/0001-Template-is-a-reserved-keyword-in-javacc.patch @@ -0,0 +1,50 @@ +From 4275860ed4a69047f783f0c06004ba4f1256a994 Mon Sep 17 00:00:00 2001 +From: Mikolaj Izdebski +Date: Wed, 23 Aug 2023 08:49:53 +0200 +Subject: [PATCH] Template is a reserved keyword in javacc + +Forwarded: no +--- + velocity-engine-core/src/main/parser/Parser.jjt | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/velocity-engine-core/src/main/parser/Parser.jjt b/velocity-engine-core/src/main/parser/Parser.jjt +index 593d044b..f3bed948 100644 +--- a/velocity-engine-core/src/main/parser/Parser.jjt ++++ b/velocity-engine-core/src/main/parser/Parser.jjt +@@ -234,12 +234,12 @@ public class ${parser.basename}Parser implements Parser + * the new stream that we want parsed. + */ + @Override +- public SimpleNode parse( Reader reader, Template template ) ++ public SimpleNode parse( Reader reader, Template tmplate ) + throws ParseException + { + SimpleNode sn = null; + +- currentTemplate = template; ++ currentTemplate = tmplate; + + try + { +@@ -267,7 +267,7 @@ public class ${parser.basename}Parser implements Parser + * thrown by the Macro class when something is amiss in the + * Macro specification + */ +- log.error("{}: {}", template.getName(), mee.getMessage(), mee); ++ log.error("{}: {}", tmplate.getName(), mee.getMessage(), mee); + throw mee; + } + catch (ParseException pe) +@@ -282,7 +282,7 @@ public class ${parser.basename}Parser implements Parser + } + catch (Exception e) + { +- String msg = template.getName() + ": " + e.getMessage(); ++ String msg = tmplate.getName() + ": " + e.getMessage(); + log.error(msg, e); + throw new VelocityException(msg, e, getRuntimeServices().getLogContext().getStackTrace()); + } +-- +2.41.0 + diff --git a/SOURCES/0002-Port-to-OpenJDK-11.patch b/SOURCES/0002-Port-to-OpenJDK-11.patch deleted file mode 100644 index 5c5efe2..0000000 --- a/SOURCES/0002-Port-to-OpenJDK-11.patch +++ /dev/null @@ -1,33 +0,0 @@ -From a7d58ff8edefb992d4989a4e2d8f4eec104e4e93 Mon Sep 17 00:00:00 2001 -From: Marian Koncek -Date: Thu, 31 Oct 2019 15:38:55 +0100 -Subject: [PATCH] Port to OpenJDK 11 - ---- - .../org/apache/velocity/test/BuiltInEventHandlerTestCase.java | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - -diff --git a/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java b/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java -index 2005b0b..fb29ce3 100644 ---- a/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java -+++ b/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java -@@ -339,14 +339,14 @@ public class BuiltInEventHandlerTestCase extends BaseTestCase { - writer = new StringWriter(); - ve1.evaluate(context,writer,"test","$list.get(0)"); - assertTrue(writer.toString().indexOf("IndexOutOfBoundsException") != -1); -- assertTrue(writer.toString().indexOf("Index: 0, Size: 0") == -1); -+ assertTrue(writer.toString().indexOf("Index 0 out of bounds for length 0") == -1); - assertTrue(writer.toString().indexOf("ArrayList") == -1); - - // message - writer = new StringWriter(); - ve2.evaluate(context,writer,"test","$list.get(0)"); - assertTrue(writer.toString().indexOf("IndexOutOfBoundsException") != -1); -- assertTrue(writer.toString().indexOf("Index: 0, Size: 0") != -1); -+ assertTrue(writer.toString().indexOf("Index 0 out of bounds for length 0") != -1); - assertTrue(writer.toString().indexOf("ArrayList") == -1); - - // stack trace --- -2.21.0 - diff --git a/SOURCES/0003-Use-system-jars.patch b/SOURCES/0003-Use-system-jars.patch deleted file mode 100644 index 3d37ee8..0000000 --- a/SOURCES/0003-Use-system-jars.patch +++ /dev/null @@ -1,197 +0,0 @@ -From 813085c72e9906a53bec5954bcce7305a7c320d1 Mon Sep 17 00:00:00 2001 -From: Stanislav Ochotnicky -Date: Mon, 21 Feb 2011 17:58:39 +0100 -Subject: [PATCH 3/3] Use system jars - ---- - build/build.xml | 56 +++++++++++---------------------------------------- - build/testcases.xml | 6 ----- - 2 files changed, 12 insertions(+), 50 deletions(-) - -diff --git a/build/build.xml b/build/build.xml -index c667553..479ef2d 100644 ---- a/build/build.xml -+++ b/build/build.xml -@@ -140,28 +140,6 @@ - - - -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- - - - -@@ -174,12 +152,11 @@ - - - -- -+ - - - -- - - - -@@ -210,10 +187,9 @@ - - - -- -+ - -- - - - -@@ -248,7 +224,7 @@ - - - -- - -+ optimize="${optimize}"/> - - - -@@ -268,7 +243,7 @@ - - - -- - - -- -- - - - -@@ -561,7 +534,7 @@ - - - -- - - -@@ -585,8 +558,7 @@ - encoding="UTF-8" - debug="${debug}" - deprecation="${deprecation}" -- optimize="${optimize}" -- classpathref="velocity.run.classpath"/> -+ optimize="${optimize}"/> - - - -@@ -604,7 +576,7 @@ - - - -- - - -@@ -620,8 +592,7 @@ - doctitle="${name} ${version} API" - encoding="UTF-8" - docencoding="UTF-8" -- bottom="Copyright © 2000-${build.year} <a href="http://www.apache.org/">Apache Software Foundation</a>. All Rights Reserved." -- classpathref="velocity.build.classpath"> -+ bottom="Copyright © 2000-${build.year} <a href="http://www.apache.org/">Apache Software Foundation</a>. All Rights Reserved."> - - - -@@ -1024,12 +995,11 @@ - - - -- - - -+ classname="org.apache.velocity.anakia.AnakiaTask"/> - - - ####################################################### -@@ -1231,7 +1201,7 @@ - - - -- - - -@@ -1264,8 +1234,6 @@ - - - -- -- - - - -diff --git a/build/testcases.xml b/build/testcases.xml -index 06bb36e..f3749bc 100644 ---- a/build/testcases.xml -+++ b/build/testcases.xml -@@ -36,12 +36,6 @@ - - - -- -- -- -- -- -- - - - --- -1.7.4 - diff --git a/SOURCES/0004-JDBC-41-compat.patch b/SOURCES/0004-JDBC-41-compat.patch deleted file mode 100644 index c137bac..0000000 --- a/SOURCES/0004-JDBC-41-compat.patch +++ /dev/null @@ -1,19 +0,0 @@ ---- a/src/test/org/apache/velocity/test/sql/HsqlDataSource.java 2012-02-15 19:49:20.202936454 -0500 -+++ b/src/test/org/apache/velocity/test/sql/HsqlDataSource.java 2012-02-15 19:52:35.062574871 -0500 -@@ -23,6 +23,7 @@ - import java.sql.Connection; - import java.sql.DriverManager; - import java.sql.SQLException; -+import java.sql.SQLFeatureNotSupportedException; - - import javax.sql.DataSource; - -@@ -73,5 +74,8 @@ - public Object unwrap(final Class iface) throws SQLException { - throw new SQLException("Not implemented"); - } -+ public java.util.logging.Logger getParentLogger() throws SQLFeatureNotSupportedException { -+ throw new SQLFeatureNotSupportedException("getParentLogger() not supported"); -+ } - - } diff --git a/SOURCES/0004-Use-log4j-1.2.17.patch b/SOURCES/0004-Use-log4j-1.2.17.patch deleted file mode 100644 index 62602a0..0000000 --- a/SOURCES/0004-Use-log4j-1.2.17.patch +++ /dev/null @@ -1,25 +0,0 @@ -From cec42bf7ae8b4b72850c3cdea74a07603f11786f Mon Sep 17 00:00:00 2001 -From: Mikolaj Izdebski -Date: Wed, 18 Jun 2014 07:25:12 +0200 -Subject: [PATCH 4/4] Use log4j 1.2.17 - ---- - pom.xml | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/pom.xml b/pom.xml -index e35d72d..c8d48fd 100644 ---- a/pom.xml -+++ b/pom.xml -@@ -187,7 +187,7 @@ - - log4j - log4j -- 1.2.12 -+ 1.2.17 - provided - - --- -1.9.3 - diff --git a/SOURCES/0006-Skip-Java-8-incompatible-test.patch b/SOURCES/0006-Skip-Java-8-incompatible-test.patch deleted file mode 100644 index 3577fa0..0000000 --- a/SOURCES/0006-Skip-Java-8-incompatible-test.patch +++ /dev/null @@ -1,26 +0,0 @@ -From 6060e6ef497bddc4a9aeac343e584ff324746d58 Mon Sep 17 00:00:00 2001 -From: Mikolaj Izdebski -Date: Wed, 18 Jun 2014 08:11:48 +0200 -Subject: [PATCH 6/6] Skip Java 8 incompatible test - ---- - src/test/org/apache/velocity/test/issues/VelTools66TestCase.java | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/src/test/org/apache/velocity/test/issues/VelTools66TestCase.java b/src/test/org/apache/velocity/test/issues/VelTools66TestCase.java -index 00bb0b1..6fb7260 100644 ---- a/src/test/org/apache/velocity/test/issues/VelTools66TestCase.java -+++ b/src/test/org/apache/velocity/test/issues/VelTools66TestCase.java -@@ -87,7 +87,8 @@ public class VelTools66TestCase - - Method testMethod = introspector.getMethod(TestObject.class, "getTestValue", new Object[0]); - assertNotNull(testMethod); -- assertEquals("Method object does not match!", verifyMethod, testMethod); -+ // Java 8 incompatibility -+ // assertEquals("Method object does not match!", verifyMethod, testMethod); - } - - public static interface TestInterface --- -1.9.3 - diff --git a/SOURCES/generate-tarball.sh b/SOURCES/generate-tarball.sh deleted file mode 100755 index a86a470..0000000 --- a/SOURCES/generate-tarball.sh +++ /dev/null @@ -1,21 +0,0 @@ -#!/bin/bash -set -e - -name=velocity -version="$(sed -n 's/Version:\s*//p' *.spec)" - -# RETRIEVE -wget "http://www.apache.org/dist/${name}/engine/${version}/${name}-${version}.tar.gz" -O "${name}-${version}.orig.tar.gz" - -rm -rf tarball-tmp -mkdir tarball-tmp -cd tarball-tmp -tar xf "../${name}-${version}.orig.tar.gz" - -# CLEAN TARBALL -rm -r */*.jar -rm -r */lib - -tar cf "../${name}-${version}.tar.gz" * -cd .. -rm -r tarball-tmp "${name}-${version}.orig.tar.gz" diff --git a/SOURCES/velocity-1.7-doclint.patch b/SOURCES/velocity-1.7-doclint.patch deleted file mode 100644 index 7895b60..0000000 --- a/SOURCES/velocity-1.7-doclint.patch +++ /dev/null @@ -1,11 +0,0 @@ -diff -Nru velocity-1.7/build/build.xml velocity-1.7.doclint/build/build.xml ---- velocity-1.7/build/build.xml 2015-07-22 12:13:51.566920750 +0200 -+++ velocity-1.7.doclint/build/build.xml 2015-07-22 12:13:14.929703544 +0200 -@@ -592,6 +592,7 @@ - doctitle="${name} ${version} API" - encoding="UTF-8" - docencoding="UTF-8" -+ additionalparam="-Xdoclint:none" - bottom="Copyright © 2000-${build.year} <a href="http://www.apache.org/">Apache Software Foundation</a>. All Rights Reserved."> - - diff --git a/SOURCES/velocity-1.7-osgi.patch b/SOURCES/velocity-1.7-osgi.patch deleted file mode 100644 index 2d6ac05..0000000 --- a/SOURCES/velocity-1.7-osgi.patch +++ /dev/null @@ -1,43 +0,0 @@ -diff -Nru velocity-1.7/build/build.properties velocity-1.7.osgi/build/build.properties ---- velocity-1.7/build/build.properties 2010-11-19 21:16:21.000000000 +0100 -+++ velocity-1.7.osgi/build/build.properties 2015-07-22 12:21:19.627117810 +0200 -@@ -166,8 +166,7 @@ - - ######################################################################## - # OSGi stuff --import=com.werken.xpath;resolution:=optional,\ -- javax.naming,\ -+import=javax.naming,\ - javax.servlet;resolution:=optional,\ - javax.servlet.http;resolution:=optional,\ - javax.sql,\ -@@ -188,8 +187,7 @@ - org.jdom.input;resolution:=optional,\ - org.jdom.output;resolution:=optional,\ - org.xml.sax --dep.import=com.werken.xpath;resolution:=optional,\ -- javax.naming,\ -+dep.import=javax.naming,\ - javax.servlet;resolution:=optional,\ - javax.servlet.http;resolution:=optional,\ - javax.sql,\ -@@ -207,8 +205,7 @@ - export=org.apache.velocity;uses:="org.apache.velocity.context,\ - org.apache.velocity.exception,\ - org.apache.velocity.runtime.resource",\ -- org.apache.velocity.anakia;uses:="com.werken.xpath,\ -- org.apache.tools.ant,\ -+ org.apache.velocity.anakia;uses:="org.apache.tools.ant,\ - org.apache.tools.ant.taskdefs,\ - org.jdom,\ - org.jdom.output",\ -@@ -327,8 +324,7 @@ - org.apache.velocity;uses:="org.apache.velocity.context,\ - org.apache.velocity.exception,\ - org.apache.velocity.runtime.resource",\ -- org.apache.velocity.anakia;uses:="com.werken.xpath,\ -- org.apache.tools.ant,\ -+ org.apache.velocity.anakia;uses:="org.apache.tools.ant,\ - org.apache.tools.ant.taskdefs,\ - org.jdom,\ - org.jdom.output",\ diff --git a/SOURCES/velocity-1.7.pom b/SOURCES/velocity-1.7.pom deleted file mode 100644 index 77a8e38..0000000 --- a/SOURCES/velocity-1.7.pom +++ /dev/null @@ -1,346 +0,0 @@ - - - - - - - 4.0.0 - - - org.apache - apache - 4 - - - org.apache.velocity - velocity - 1.7 - - Apache Velocity - http://velocity.apache.org/engine/devel/ - Apache Velocity is a general purpose template engine. - 2000 - jar - - - 2.0.9 - - - - install - src/java - src/test - - - org.apache.maven.plugins - maven-site-plugin - - UTF-8 - UTF-8 - ${basedir}/xdocs/docs - - - - - - src/java - - **/*.java - - - - - - - - velocity.apache.org - scpexe://people.apache.org/www/velocity.apache.org/engine/releases/velocity-1.7 - - - apache.releases - Apache Release Distribution Repository - scp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository - - - apache.snapshots - Apache Development Snapshot Repository - scp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository - - - - - - Will Glass-Husain - wglass - wglass@forio.com - Forio Business Simulations - - Java Developer - - - - - Geir Magnusson Jr. - geirm - geirm@optonline.net - Independent (DVSL Maven) - - Java Developer - - - - - Daniel Rall - dlr - dlr@finemaltcoding.com - CollabNet, Inc. - - Java Developer - - - - - Henning P. Schmiedehausen - henning - hps@intermeta.de - INTERMETA - Gesellschaft für Mehrwertdienste mbH - - Java Developer - - 2 - - - - Nathan Bubna - nbubna - nathan@esha.com - ESHA Research - - Java Developer - - - - - - - - commons-collections - commons-collections - 3.2.1 - - - commons-lang - commons-lang - 2.4 - - - oro - oro - 2.0.8 - true - - - jdom - jdom - 1.0 - provided - - - commons-logging - commons-logging - 1.1 - provided - - - avalon-framework - avalon-framework - - - log4j - log4j - - - javax.servlet - servlet-api - - - - - log4j - log4j - 1.2.12 - provided - - - javax.servlet - servlet-api - 2.3 - provided - - - logkit - logkit - 2.0 - provided - - - ant - ant - 1.6 - provided - - - werken-xpath - werken-xpath - 0.9.4 - provided - - - junit - junit - 3.8.1 - test - - - hsqldb - hsqldb - 1.7.1 - test - - - - - - - org.apache.maven.plugins - maven-project-info-reports-plugin - 2.1 - - - - dependencies - issue-tracking - license - summary - scm - - - - - - org.apache.maven.plugins - maven-changes-plugin - 2.0 - - - - changes-report - jira-report - - - - - ${jira.browse.url}/%ISSUE% - - 12311337 - - fixfor=12310290&sorter/field=issuekey&sorter/order=ASC - 100 - http://velocity.apache.org/who-we-are.html - - - - org.codehaus.mojo - taglist-maven-plugin - 2.2 - - TODO - FIXME - - - - org.apache.maven.plugins - maven-jxr-plugin - 2.1 - - - org.apache.maven.plugins - maven-javadoc-plugin - 2.5 - - - http://java.sun.com/j2se/1.4.2/docs/api - http://jakarta.apache.org/oro/api - http://jakarta.apache.org/commons/lang/api-release - http://jakarta.apache.org/commons/collections/api-release - - http://www.jdom.org/docs/apidocs - http://logging.apache.org/log4j/docs/api - http://excalibur.apache.org/apidocs - http://tomcat.apache.org/tomcat-4.1-doc/servletapi - - - - - org.apache.maven.plugins - maven-changelog-plugin - 2.1 - - - org.codehaus.mojo - findbugs-maven-plugin - 1.2 - - true - Low - Max - build/findbugs-exclude.xml - xdocs - - - - org.apache.maven.plugins - maven-compiler-plugin - - 1.4 - 1.4 - - - - - - - scm:svn:http://svn.apache.org/repos/asf/velocity/engine/trunk - scm:svn:https://svn.apache.org/repos/asf/velocity/engine/trunk - HEAD - http://svn.apache.org/viewvc/velocity/engine/trunk - - - - https://issues.apache.org/jira/browse - - - - JIRA - ${jira.browse.url}/VELOCITY - - diff --git a/SPECS/velocity.spec b/SPECS/velocity.spec index f4d41f2..bb52237 100644 --- a/SPECS/velocity.spec +++ b/SPECS/velocity.spec @@ -1,47 +1,32 @@ +%bcond_with bootstrap Name: velocity -Version: 1.7 -Release: 26%{?dist} +Version: 2.3 +Release: 17%{?dist} Summary: Java-based template engine -License: ASL 2.0 +License: Apache-2.0 URL: http://velocity.apache.org/ BuildArch: noarch +ExclusiveArch: %{java_arches} noarch -# ./generate-tarball.sh -Source0: %{name}-%{version}.tar.gz -Source1: http://repo1.maven.org/maven2/org/apache/%{name}/%{name}/%{version}/%{name}-%{version}.pom -# Remove bundled binaries which cannot be easily verified for licensing -Source2: generate-tarball.sh +Source0: https://github.com/apache/velocity-engine/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz -Patch0: 0001-Remove-avalon-logkit.patch -Patch1: 0004-Use-log4j-1.2.17.patch -Patch2: 0003-Use-system-jars.patch -Patch3: 0004-JDBC-41-compat.patch -Patch4: 0001-Don-t-use-Werken-XPath.patch -Patch5: 0006-Skip-Java-8-incompatible-test.patch -Patch6: velocity-1.7-doclint.patch -Patch7: velocity-1.7-osgi.patch -Patch8: 0001-Port-to-apache-commons-lang3.patch -Patch9: 0002-Port-to-OpenJDK-11.patch +Patch: 0001-Template-is-a-reserved-keyword-in-javacc.patch -BuildRequires: javapackages-local -BuildRequires: ant -BuildRequires: antlr -BuildRequires: junit -BuildRequires: ant-junit -BuildRequires: apache-commons-collections -BuildRequires: apache-commons-logging -BuildRequires: apache-commons-lang3 -BuildRequires: glassfish-servlet-api -BuildRequires: jakarta-oro -BuildRequires: jaxen -BuildRequires: jdom -BuildRequires: bcel -BuildRequires: log4j12 -BuildRequires: apache-parent - -# It fails one of the arithmetic test cases with gcj -BuildRequires: java-devel >= 1:1.6.0 +%if %{with bootstrap} +BuildRequires: javapackages-bootstrap +%else +BuildRequires: maven-local +BuildRequires: mvn(commons-io:commons-io) +BuildRequires: mvn(junit:junit) +BuildRequires: mvn(org.apache.commons:commons-lang3) +BuildRequires: mvn(org.apache.felix:maven-bundle-plugin) +BuildRequires: mvn(org.apache.maven.plugins:maven-enforcer-plugin) +BuildRequires: mvn(org.apache.maven.plugins:maven-source-plugin) +BuildRequires: mvn(org.codehaus.mojo:extra-enforcer-rules) +BuildRequires: mvn(org.codehaus.mojo:javacc-maven-plugin) +BuildRequires: mvn(org.slf4j:slf4j-api) +%endif %description Velocity is a Java-based template engine. It permits anyone to use the @@ -64,144 +49,137 @@ template services for the Turbine web application framework. Velocity+Turbine provides a template service that will allow web applications to be developed according to a true MVC model. -%package manual -Summary: Manual for %{name} +%package javadoc +Summary: API documentation for %{name} -%description manual -Documentation for %{name}. - -%package javadoc -Summary: Javadoc for %{name} - -%description javadoc -Javadoc for %{name}. - -%package demo -Summary: Demo for %{name} -Requires: %{name} = %{version}-%{release} - -%description demo -Demonstrations and samples for %{name}. - -# ----------------------------------------------------------------------------- +%description javadoc +API documentation for %{name}. %prep -%setup -q +%autosetup -p1 -n velocity-engine-%{version} -# remove bundled libs/classes (except those used for testing) -find . -name '*.jar' ! -name 'test*.jar' -print -delete -find . -name '*.class' ! -name 'Foo.class' -print -delete +%mvn_alias : velocity:velocity +%mvn_alias : org.apache.velocity:velocity -# Remove dependency on avalon-logkit -rm -f src/java/org/apache/velocity/runtime/log/AvalonLogChute.java -rm -f src/java/org/apache/velocity/runtime/log/AvalonLogSystem.java -rm -f src/java/org/apache/velocity/runtime/log/VelocityFormatter.java +%pom_remove_parent +%pom_xpath_inject pom:project "org.apache.velocity" -# need porting to new servlet API. We would just add a lot of empty functions -rm src/test/org/apache/velocity/test/VelocityServletTestCase.java +%pom_disable_module spring-velocity-support +%pom_disable_module velocity-custom-parser-example +%pom_disable_module velocity-engine-examples +%pom_disable_module velocity-engine-scripting -# This test doesn't work with new hsqldb -rm src/test/org/apache/velocity/test/sql/DataSourceResourceLoaderTestCase.java +%pom_remove_plugin :maven-javadoc-plugin -cp %{SOURCE1} ./pom.xml +%pom_remove_plugin :templating-maven-plugin velocity-engine-core +sed 's/${project.version}/%{version}/' \ + velocity-engine-core/src/main/java-templates/org/apache/velocity/runtime/VelocityEngineVersion.java \ + >velocity-engine-core/src/main/java/org/apache/velocity/runtime/VelocityEngineVersion.java -# remove rest of avalon logkit refences -%patch0 -p1 +%pom_remove_plugin com.google.code.maven-replacer-plugin:replacer velocity-engine-core +%pom_remove_plugin :maven-shade-plugin velocity-engine-core -# Use log4j 1.2.17 -%patch1 -p1 - -# Use system jar files instead of downloading from net -%patch2 -p1 - -%patch3 -p1 - -# Use jdom instead of werken-xpath -%patch4 -p1 -%pom_remove_dep werken-xpath: - -# Skip Java 8 incompatible test -%patch5 -p1 - -# Disable Java8 doclint -%patch6 -p1 - -# Remove werken-xpath Import/Export refences in OSGi manifest file -%patch7 -p1 - -# Port to apache-commons-lang3 -%patch8 -p1 - -# Tests compare the string content of thrown exceptions which changed with jdk 11 -%patch9 -p1 - -rm -r src/test/org/apache/velocity/test/sql - -# ----------------------------------------------------------------------------- +%pom_xpath_remove "pom:dependency[pom:scope='test']" velocity-engine-core %build - -export CLASSPATH=$(build-classpath \ -antlr \ -apache-commons-collections \ -commons-lang3 \ -commons-logging \ -glassfish-servlet-api \ -junit \ -jakarta-oro \ -log4j:log4j:1.2.17 \ -jaxen \ -jdom \ -bcel \ -hsqldb \ -junit) -ant \ - -buildfile build/build.xml \ - -Dbuild.sysclasspath=first \ - -Djavac.target=1.6 \ - -Djavac.source=1.6 \ - jar javadocs test - -# fix line-endings in generated files -sed -i 's/\r//' docs/api/stylesheet.css docs/api/package-list - -# ----------------------------------------------------------------------------- +%mvn_build -f -- -Djavacc.visitor=false %install -%mvn_file : %{name} -%mvn_alias : %{name}:%{name} -%mvn_artifact pom.xml bin/%{name}-%{version}.jar -%mvn_install -J docs/api - -# zero-length file -rm -r test/issues/velocity-537/compare/velocity537.vm.cmp -# data -install -d -m 755 %{buildroot}%{_datadir}/%{name} -cp -pr examples test %{buildroot}%{_datadir}/%{name} - +%mvn_install %files -f .mfiles -%doc README.txt +%doc README.md %license LICENSE NOTICE -%files manual -%license LICENSE NOTICE -%doc docs/* - %files javadoc -f .mfiles-javadoc %license LICENSE NOTICE -%files demo -%license LICENSE NOTICE -%{_datadir}/%{name} - %changelog +* Fri Nov 29 2024 Mikolaj Izdebski - 2.3-14 +- Update javapackages test plan to f42 + +* Sat Jul 20 2024 Fedora Release Engineering - 2.3-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild + +* Fri May 31 2024 Mikolaj Izdebski - 2.3-6 +- Switch to a newer patch macro syntax + +* Tue Feb 27 2024 Jiri Vanek - 2.3-5 +- Rebuilt for java-21-openjdk as system jdk + +* Fri Feb 23 2024 Jiri Vanek - 2.3-4 +- bump of release for for java-21-openjdk as system jdk + +* Sat Jan 27 2024 Fedora Release Engineering - 2.3-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + +* Fri Sep 01 2023 Mikolaj Izdebski - 2.3-2 +- Convert License tag to SPDX format + +* Fri Aug 25 2023 Mikolaj Izdebski - 2.3-1 +- Update to upstream version 2.3 + +* Sat Jul 22 2023 Fedora Release Engineering - 1.7-41 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + +* Sat Jan 21 2023 Fedora Release Engineering - 1.7-40 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + +* Sat Jul 23 2022 Fedora Release Engineering - 1.7-39 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + +* Sat Feb 05 2022 Jiri Vanek - 1.7-38 +- Rebuilt for java-17-openjdk as system jdk + +* Sat Jan 22 2022 Fedora Release Engineering - 1.7-37 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Fri Jul 23 2021 Fedora Release Engineering - 1.7-36 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Mon May 17 2021 Mikolaj Izdebski - 1.7-35 +- Bootstrap build +- Non-bootstrap build + +* Wed Jan 27 2021 Fedora Release Engineering - 0:1.7-34 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Fri Sep 11 2020 Fabio Valentini - 0:1.7-33 +- Default to JDK logging and drop commons-logging and log4j12 implementations. + +* Thu Jul 30 2020 Fabio Valentini - 0:1.7-32 +- Port to commons-lang3. + +* Wed Jul 29 2020 Fedora Release Engineering - 0:1.7-31 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Tue Jul 14 2020 Jiri Vanek - 0:1.7-30 +- Rebuilt for JDK-11, see https://fedoraproject.org/wiki/Changes/Java11 + +* Mon Jul 13 2020 Mat Booth - 0:1.7-29 +- Ignore test case that fails on Java 11 + +* Sat Jul 11 2020 Jiri Vanek - 0:1.7-28 +- Rebuilt for JDK-11, see https://fedoraproject.org/wiki/Changes/Java11 + +* Fri May 15 2020 Mikolaj Izdebski - 1.7-27 +- Build with Maven + +* Fri Jan 31 2020 Fedora Release Engineering - 0:1.7-27 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + * Tue Nov 05 2019 Mikolaj Izdebski - 1.7-26 - Mass rebuild for javapackages-tools 201902 +* Sat Jul 27 2019 Fedora Release Engineering - 0:1.7-26 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + * Fri May 24 2019 Mikolaj Izdebski - 1.7-25 - Mass rebuild for javapackages-tools 201901 +* Sun Feb 03 2019 Fedora Release Engineering - 0:1.7-25 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + * Tue Jul 31 2018 Michael Simacek - 0:1.7-24 - Repack the tarball without binaries