rpms/valgrind
7
0
Fork 0
Code Issues Pull Requests Releases Activity

does-hunspell-works-under-valgrind: workaround the testcase

Browse Source 
echo "NEWSX" | hunspell -a with and w/o valgrind differed in
lower case. This could be workarounded by running such a command
under --tool=none.

Jan Kratochvil suggested the better workaround finding out
spelling suggestions somehow were based on the processor time used by
the process. And so overriding clock to simply always return zero means
the process cannot observe the cpu time used.
This commit is contained in:
Alexandra Hájková 2021-07-16 11:35:20 +02:00
parent dc7d3866cc
commit 9a0a8de052
1 changed files with 5 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
tests/does-hunspell-works-under-valgrind/runtest.sh
View File

@ -28,7 +28,7 @@
# Include rhts environment # Include rhts environment
. /usr/share/beakerlib/beakerlib.sh || exit 1 . /usr/share/beakerlib/beakerlib.sh || exit 1
SPELL_CHECKER="${SPELL_CHECKER:-hunspell}" SPELL_CHECKER="${SPELL_CHECKER:-hunspell}"
VALGRIND="${VALGRIND:-$(which valgrind)}" VALGRIND="${VALGRIND:-$(which valgrind)}"
PACKAGES="${PACKAGES:-$(rpm --qf '%{name}\n' -qf $(which $VALGRIND) | head -1)}" PACKAGES="${PACKAGES:-$(rpm --qf '%{name}\n' -qf $(which $VALGRIND) | head -1)}"
@ -48,42 +48,17 @@ rlJournalStart
rlPhaseStartTest rlPhaseStartTest
out="$TmpDir/spell_check.out" rlRun "echo \"NEWSX\"|hunspell -a;echo -e '#include <time.h>\nclock_t clock(void) { return 0; }'|gcc -o libclock.so -Wall -g -shared -fPIC -x c -;echo "NEWSX"|LD_PRELOAD=./libclock.so hunspell -a > out"
err="$TmpDir/spell_check.err"
vout="$TmpDir/spell_check.valgrind.out"
verr="$TmpDir/spell_check.valgrind.err"
spell_checker_command="" rlRun "echo \"NEWSX\"|hunspell -a;echo -e '#include <time.h>\nclock_t clock(void) { return 0; }'|gcc -o libclock.so -Wall -g -shared -fPIC -x c -;echo \"NEWSX\"|LD_PRELOAD=./libclock.so valgrind -q hunspell -a > valgrind_out"
spell_checker_command="echo \"hackerx\" | $SPELL_CHECKER -a > $out 2> $err"
# Remove dictionary to avoid possibility of different results with # Remove dictionary to avoid possibility of different results with
# already present dictionary. After this all commands start with # already present dictionary. After this all commands start with
# the clean sheet. # the clean sheet.
rlRun "rm -f $HOME/.hunspell_en_US" rlRun "rm -f $HOME/.hunspell_en_US"
rlRun "$spell_checker_command" 0-255 rlAssertNotDiffer "out" "valgrind_out"
[ "$?" -ne 0 ] && rlLogWarning "$(diff out valgrind_out)"
if [ "$?" -eq "0" ]; then
spell_checker_command="${spell_checker_command/$out/$vout}"
spell_checker_command="${spell_checker_command/$err/$verr}"
rlRun "rm -f $HOME/.hunspell_en_US"
rlRun "valgrind $spell_checker_command" 0-255
if [ "$?" -ne 0 ]; then
rlLogWarning "Valgrind check failed"
rlLogWarning "$(cat $verr)"
else
rlAssertNotDiffer "$out" "$vout"
[ "$?" -ne 0 ] && rlLogWarning "$(diff $out $vout)"
fi
else
((skipped++))
rlLogWarning "Regular check failed"
rlLogWarning "$(cat $err)"
fi
rlRun "rm -f $out $err $vout $verr"
rlPhaseEnd rlPhaseEnd
rlPhaseStartCleanup rlPhaseStartCleanup