rpms
/
tuna
7
0
Fork 0
Code Issues Pull Requests Releases Activity

tuna: Make it clear that include and isolate affect IRQs 

Make if clear in the online help and man page that
--include and --isolate affect IRQS

Resolves: rhbz#2022142

Signed-off-by: John Kacur <jkacur@redhat.com>
This commit is contained in:
John Kacur 2021-11-11 16:09:31 -05:00
parent 4a3048687c
commit c0ee44ede5
2 changed files with 63 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
tuna-Make-it-clear-that-include-and-isolate-affects-IRQs.patch Normal file
View File

@ -0,0 +1,55 @@
From 532739e58bc36df820a1742489c744e7589221d0 Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Wed, 10 Nov 2021 15:58:44 -0500
Subject: [PATCH] tuna: Make it clear that include and isolate affects IRQs in
help
Make it clear in the online help (-h) and in the manpage
that
-i --isolate
-I --include
affects IRQs as well as threads
Signed-off-by: John Kacur <jkacur@redhat.com>
---
docs/tuna.8 | 4 ++--
tuna-cmd.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/tuna.8 b/docs/tuna.8
index b6431be5e117..bd6299b5a771 100644
--- a/docs/tuna.8
+++ b/docs/tuna.8
@@ -26,10 +26,10 @@ Apply changes described in profile
List preloaded profiles
.TP
\fB\-i\fR, \fB\-\-isolate\fR
-Move all threads away from CPU\-LIST. Requires \fB\-c\fR or \fB-S\fR.
+Move all allowed threads and IRQs away from CPU\-LIST. Requires \fB\-c\fR or \fB-S\fR.
.TP
\fB\-I\fR, \fB\-\-include\fR
-Allow all threads to run on CPU\-LIST. Requires \fB\-c\fR or \fB-S\fR.
+Allow all allowed threads and IRQs to run on CPU\-LIST. Requires \fB\-c\fR or \fB-S\fR.
.TP
\fB\-m\fR, \fB\-\-move\fR
Move selected entities to CPU\-LIST. Requires \fB\-c\fR and either \fB-t\fR or \fB-q\fR.
diff --git a/tuna-cmd.py b/tuna-cmd.py
index 46ce86efa036..d209a2e89493 100755
--- a/tuna-cmd.py
+++ b/tuna-cmd.py
@@ -63,9 +63,9 @@ def usage():
_('Explicitly disable usage of perf in GUI for process view')))
print(fmt % ('-f, --filter',
_('Display filter the selected entities')))
- print(fmt % ('-i, --isolate', _('Move all threads away from %(cpulist)s') %
+ print(fmt % ('-i, --isolate', _('Move all allowed threads and IRQs away from %(cpulist)s') %
{"cpulist": _('CPU-LIST')}))
- print(fmt % ('-I, --include', _('Allow all threads to run on %(cpulist)s') %
+ print(fmt % ('-I, --include', _('Allow all allowed threads and IRQs to run on %(cpulist)s') %
{"cpulist": _('CPU-LIST')}))
print(fmt % ('-K, --no_kthreads',
_('Operations will not affect kernel threads')))
--
2.31.1

9
tuna.spec
View File

@ -1,6 +1,6 @@
Name: tuna
Version: 0.16
Release: 4%{?dist}
Release: 5%{?dist}
License: GPLv2
Summary: Application tuning GUI & command line utility
URL: https://git.kernel.org/pub/scm/utils/tuna/tuna.git
@ -16,6 +16,7 @@ Requires: python3-linux-procfs >= 0.6
# Patches
Patch1: tuna-Print-warning-if-setting-affinity-results-in-EBUSY.patch
Patch2: tuna-Add-distinction-between-spread-and-move-to-erro.patch
Patch3: tuna-Make-it-clear-that-include-and-isolate-affects-IRQs.patch
%description
Provides interface for changing scheduler and IRQ tunables, at whole CPU and at
@ -30,6 +31,7 @@ installed.
%setup -q
%patch1 -p1
%patch2 -p1
%patch3 -p1
%build
%py3_build
@ -71,6 +73,11 @@ done
%{_datadir}/polkit-1/actions/org.tuna.policy
%changelog
* Thu Nov 11 2021 John Kacur <jkacur@redhat.com> - 0.16-5
- Make it clear in online help and man pages that --include and --isolate
affect IRQs as well as threads
Resolves: rhbz#2022142
* Tue Nov 02 2021 Leah Leshchinsky <lleshchi@redhat.com> - 0.16-4
- Add distinction between spread and move to error message
Resolves: rhbz#2012243