Disable tuna apply

Resolves: RHEL-140840
Signed-off-by: John Kacur <jkacur@redhat.com>
This commit is contained in:
John Kacur 2026-01-12 15:58:37 -05:00
parent 63ee3cedcf
commit 9cfd3630da
3 changed files with 110 additions and 2 deletions

View File

@ -0,0 +1,54 @@
From 959a16cefa6df216e42864534bc1eab9fd4d02c9 Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Mon, 12 Jan 2026 15:23:05 -0500
Subject: [PATCH 1/2] tuna: Disable the tuna apply functionality
Currently tuned is the recommended way to apply a profile.
Since tuna apply is currently broken, disabling it.
Signed-off-by: John Kacur <jkacur@redhat.com>
---
tuna-cmd.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tuna-cmd.py b/tuna-cmd.py
index 886824a4013c..6208bd116cea 100755
--- a/tuna-cmd.py
+++ b/tuna-cmd.py
@@ -150,8 +150,8 @@ def gen_parser():
help="Fork a new process and run the COMMAND")
save = subparser.add_parser('save', description="Save kthreads sched tunables to FILENAME",
help="Save kthreads sched tunables to FILENAME")
- apply = subparser.add_parser('apply', description="Apply changes described in profile",
- help="Apply changes described in profile")
+ # apply = subparser.add_parser('apply', description="Apply changes described in profile",
+ # help="Apply changes described in profile")
show_threads = subparser.add_parser('show_threads', description='Show thread list', help='Show thread list')
show_irqs = subparser.add_parser('show_irqs', description='Show IRQ list', help='Show IRQ list')
show_configs = subparser.add_parser('show_configs', description='List preloaded profiles', help='List preloaded profiles')
@@ -205,7 +205,7 @@ def gen_parser():
save_group.add_argument('-N', '--nohz_full', **MODS['nohz_full'])
save.add_argument('-t', '--threads', **MODS['threads'])
- apply.add_argument('profilename', **POS['profilename'])
+ # apply.add_argument('profilename', **POS['profilename'])
show_threads_group1 = show_threads.add_mutually_exclusive_group(required=False)
show_threads_group1.add_argument('-c', '--cpus', **MODS['cpus'])
@@ -712,10 +712,10 @@ def main():
if 'nohz_full' in vars(args) and args.nohz_full:
args.cpu_list = nohz_full_to_cpu()
- if args.command in ['apply', 'a']:
- apply_config(args.profilename)
+ # if args.command in ['apply', 'a']:
+ # apply_config(args.profilename)
- elif args.command in ['include', 'I']:
+ if args.command in ['include', 'I']:
tuna.include_cpus(args.cpu_list, utils.get_nr_cpus())
elif args.command in ['isolate', 'i']:
--
2.52.0

View File

@ -0,0 +1,48 @@
From 09ba81b4a78d98ce8a8e289842571f19416cdaea Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Mon, 12 Jan 2026 15:24:07 -0500
Subject: [PATCH 2/2] tuna: Remove tuna apply from the man page
tuna apply has been disabled so remove it from the man page
Signed-off-by: John Kacur <jkacur@redhat.com>
---
docs/tuna.8 | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/docs/tuna.8 b/docs/tuna.8
index 6e30537e9509..8c15c2ef535c 100644
--- a/docs/tuna.8
+++ b/docs/tuna.8
@@ -169,17 +169,17 @@ optional arguments:
-t THREAD-LIST, --threads THREAD-LIST
THREAD-LIST affected by commands
.TP
-\fBtuna apply\fR
-usage: tuna-cmd.py apply [-h] profilename
-
-Apply changes described in profile
-
-positional arguments:
- profilename Apply changes described in this file
-
-optional arguments:
- -h, --help show this help message and exit
-
+.\"\fBtuna apply\fR
+.\"usage: tuna-cmd.py apply [-h] profilename
+.\"
+.\"Apply changes described in profile
+.\"
+.\"positional arguments:
+.\" profilename Apply changes described in this file
+.\"
+.\"optional arguments:
+.\" -h, --help show this help message and exit
+.\"
.TP
\fBtuna show_threads\fR
usage: tuna-cmd.py show_threads [-h] [-c CPU-LIST | -N | -S CPU-SOCKET-LIST]
--
2.52.0

View File

@ -2,7 +2,7 @@
Name: tuna
Version: 0.20
Release: 3%{?dist}
Release: 4%{?dist}
License: GPL-2.0-only AND LGPL-2.1-only
Summary: Application tuning GUI & command line utility
Source: https://www.kernel.org/pub/software/utils/%{name}/%{name}-%{version}.tar.xz
@ -18,6 +18,8 @@ BuildRequires: gettext
# Requires: python-inet_diag
# Patches
Patch1: tuna-Disable-the-tuna-apply-functionality.patch
Patch2: tuna-Remove-tuna-apply-from-the-man-page.patch
%description
Provides interface for changing scheduler and IRQ tunables, at whole CPU and at
@ -82,7 +84,11 @@ done
%{_datadir}/polkit-1/actions/org.tuna.policy
%changelog
* Tue Nov 11 2025 John Kacur <jkacur@redhat.com> - 0.020-3
* Mon Jan 12 2026 John Kacur <jkacur@redhat.com> - 0.20-4
- Disable tuna apply
Resolves: RHEL-140840
* Tue Nov 11 2025 John Kacur <jkacur@redhat.com> - 0.20-3
- Rebuild for the rebase
Resolves: RHEL-83080