ba60453d21
Toolbox is now written in Go, so this is no longer a noarch package.
Unlike idiomatic Go code-bases, Toolbox uses the Meson build system to
check for additional non-Go dependencies and install various auxilliary
files. This leads to some interesting problems.
The Go toolchain doesn't play well with passing compiler and linker
flags via environment variables. The linker flags require a second
level of quoting, which leaves the build system without a quote level
to assign the flags to an environment variable like GOFLAGS.
This is one reason why Fedora doesn't have a RPM macro with only the
flags. The %{gobuild} RPM macro includes the entire 'go build ...'
invocation.
Therefore, the entire 'go build ...' invocation is swapped out using a
set of downstream patches (one for PPC64 because it doesn't use
'-buildmode pie', and another for other CPU architectures) to match
the %{gobuild} RPM macro.
The Go toolchain also doesn't like the LDFLAGS environment variable as
exported by Fedora's %{meson} RPM macro.
For some reason, when built on Koji, the final binary gets created as
../src/src instead of ../src/toolbox, but it doesn't happen when
building locally with 'rpmbuild -ba ...'. Hence it's necessary to
explicitly specify the name of the output binary.
Finally, Fedora doesn't support Go modules when building Go programs.
This means that Go's semantic import versioning can't be used.
A conscious effort was made to minimize the use of exotic Go-specific
RPM macros to retain the legibility of the spec file. A proliferation
of such RPM macros is a hindrance for those who are not experts in the
ins and outs of packaging Go code in Fedora.
Some changes by Debarshi Ray.
https://src.fedoraproject.org/rpms/toolbox/pull-request/2
46 lines
1.8 KiB
Diff
46 lines
1.8 KiB
Diff
From e3cadcdeb59996eb28ee6499d43ebc4b9b656a21 Mon Sep 17 00:00:00 2001
|
|
From: Debarshi Ray <rishi@fedoraproject.org>
|
|
Date: Mon, 29 Jun 2020 17:57:47 +0200
|
|
Subject: [PATCH] build: Make the build flags match Fedora's %{gobuild} for
|
|
PPC64
|
|
|
|
The Go toolchain doesn't play well with passing compiler and linker
|
|
flags via environment variables. The linker flags require a second
|
|
level of quoting, which leaves the build system without a quote level
|
|
to assign the flags to an environment variable like GOFLAGS.
|
|
|
|
This is one reason why Fedora doesn't have a RPM macro with only the
|
|
flags. The %{gobuild} RPM macro includes the entire 'go build ...'
|
|
invocation.
|
|
|
|
The Go toolchain also doesn't like the LDFLAGS environment variable as
|
|
exported by Fedora's %{meson} RPM macro.
|
|
|
|
Note that these flags are only meant for the "ppc64" CPU architecture,
|
|
and should be kept updated to match Fedora's Go guidelines. Use
|
|
'rpm --eval "%{gobuild}"' to expand the %{gobuild} macro.
|
|
|
|
For some reason, when built on Koji, the final binary gets created as
|
|
../src/src instead of ../src/toolbox, but it doesn't happen when
|
|
building locally with 'rpmbuild -ba ...'. Hence it's necessary to
|
|
explicitly specify the name of the output binary.
|
|
---
|
|
src/go-build-wrapper | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/src/go-build-wrapper b/src/go-build-wrapper
|
|
index 9bc4e68a6f2a..d62d684b78d3 100755
|
|
--- a/src/go-build-wrapper
|
|
+++ b/src/go-build-wrapper
|
|
@@ -27,5 +27,6 @@ if ! cd "$1"; then
|
|
exit 1
|
|
fi
|
|
|
|
-go build -o "$2"
|
|
+unset LDFLAGS
|
|
+go build -compiler gc -tags="rpm_crashtraceback ${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n') -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" -a -v -x -o "$2/toolbox"
|
|
exit "$?"
|
|
--
|
|
2.25.4
|
|
|