From 6b47ff61936d2b602d29b229b079bda00dadad7e Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Thu, 2 Sep 2021 14:57:37 +0200 Subject: [PATCH] cmd/root: Suggest a way forward if coreos/toolbox was used github.com/coreos/toolbox bind mounts the entire /run from the host operating system into the toolbox container. Due to this, when run rootful, the /run/.containerenv created by Podman inside the container is also seen on the host. This confuses Toolbox into thinking that it's running inside a container, even when it's running on the host. This is an attempt to differentiate between a toolbox container and the host by looking at the 'container' environment variable, so that the user can be presented with a more helpful error message. https://bugzilla.redhat.com/show_bug.cgi?id=1998191 --- src/cmd/root.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/cmd/root.go b/src/cmd/root.go index 5e6f5874a469..139609592218 100644 --- a/src/cmd/root.go +++ b/src/cmd/root.go @@ -130,6 +130,16 @@ func preRun(cmd *cobra.Command, args []string) error { if toolboxPath == "" { if utils.IsInsideContainer() { + if containerType := os.Getenv("container"); containerType == "" { + var builder strings.Builder + fmt.Fprintf(&builder, "/run/.containerenv found on what looks like the host\n") + fmt.Fprintf(&builder, "If this is the host, then remove /run/.containerenv and try again.\n") + fmt.Fprintf(&builder, "Otherwise, contact your system administrator or file a bug.") + + errMsg := builder.String() + return errors.New(errMsg) + } + return errors.New("TOOLBOX_PATH not set") } -- 2.31.1