From b3f0d3b599d334d86dcb0433b14c8aecadfa7d83 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Tue, 17 May 2022 23:52:10 +0200 Subject: [PATCH] Add 'BuildRequires: golang(golang.org/x/crypto/ssh/terminal)' Not having golang.org/x/crypto/ssh/terminal explicitly listed as a BuildRequires isn't breaking the build at the moment. However, since it's a direct dependency, and Toolbx is written in Go, it's good to explicitly list it due to the statically linked nature of Go binaries. It will make it easier to gauge the fallout from a security bug. There's no need to do a build just for this. --- toolbox.spec | 1 + 1 file changed, 1 insertion(+) diff --git a/toolbox.spec b/toolbox.spec index 0c0fd9d..b583773 100644 --- a/toolbox.spec +++ b/toolbox.spec @@ -33,6 +33,7 @@ BuildRequires: golang(github.com/sirupsen/logrus) >= 1.4.2 # BuildRequires: golang(github.com/stretchr/testify) >= 1.7.0 BuildRequires: golang(github.com/spf13/cobra) >= 0.0.5 BuildRequires: golang(github.com/spf13/viper) >= 1.3.2 +BuildRequires: golang(golang.org/x/crypto/ssh/terminal) BuildRequires: golang(golang.org/x/sys/unix) BuildRequires: meson >= 0.58.0 BuildRequires: pkgconfig(bash-completion)