import toolbox-0.0.99.2^1.git660b6970e998-1.module+el8.5.0+12014+438a5746

2021-07-29 05:21:39 +00:00 · 2021-07-29 05:21:39 +00:00 · 7e64decf2e
commit 7e64decf2e
5 changed files with 230 additions and 0 deletions
--- a/.gitignore
+++ b/.gitignore
@ -0,0 +1 @@
+SOURCES/toolbox-0.0.99.2^1.git660b6970e998-vendored.tar.xz
--- a/.toolbox.metadata
+++ b/.toolbox.metadata
@ -0,0 +1 @@
+53c96750cb48c825a54dea680922e46dc4b123ca SOURCES/toolbox-0.0.99.2^1.git660b6970e998-vendored.tar.xz
--- a/SOURCES/toolbox-Make-the-build-flags-match-RHEL-s-gobuild-for-PPC64.patch
+++ b/SOURCES/toolbox-Make-the-build-flags-match-RHEL-s-gobuild-for-PPC64.patch
@ -0,0 +1,40 @@
+From a245af969792bafcfa86090c856a06cb23061816 Mon Sep 17 00:00:00 2001
+From: Debarshi Ray <rishi@fedoraproject.org>
+Date: Mon, 29 Jun 2020 17:57:47 +0200
+Subject: [PATCH] build: Make the build flags match RHEL's %{gobuild} for PPC64
+
+The Go toolchain doesn't play well with passing compiler and linker
+flags via environment variables. The linker flags require a second
+level of quoting, which leaves the build system without a quote level
+to assign the flags to an environment variable like GOFLAGS.
+
+This is one reason why RHEL doesn't have a RPM macro with only the
+flags. The %{gobuild} RPM macro includes the entire 'go build ...'
+invocation.
+
+The Go toolchain also doesn't like the LDFLAGS environment variable as
+exported by RHEL's %{meson} RPM macro, and RHEL's RPM toolchain doesn't
+like the compressed DWARF data generated by the Go toolchain.
+
+Note that these flags are only meant for the "ppc64" CPU architecture,
+and should be kept updated to match RHEL's Go guidelines. Use
+'rpm --eval "%{gobuild}"' to expand the %{gobuild} macro.
+---
+ src/go-build-wrapper | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/go-build-wrapper b/src/go-build-wrapper
+index 0d27120da052..ef1a03af750a 100755
+--- a/src/go-build-wrapper
+++ b/src/go-build-wrapper
+@@ -27,5 +27,6 @@ if ! cd "$1"; then
+     exit 1
+ fi
+ 
+-go build -trimpath -ldflags "-extldflags '-Wl,--wrap,pthread_sigmask $4' -linkmode external -X github.com/containers/toolbox/pkg/version.currentVersion=$3" -o "$2/toolbox"
+unset LDFLAGS
+go build -compiler gc -tags="rpm_crashtraceback ${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -compressdwarf=false -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n') -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--wrap,pthread_sigmask $4' -linkmode external -X github.com/containers/toolbox/pkg/version.currentVersion=$3" -a -v -x -o "$2/toolbox"
+ exit "$?"
+-- 
+2.31.1
+
--- a/SOURCES/toolbox-Make-the-build-flags-match-RHEL-s-gobuild.patch
+++ b/SOURCES/toolbox-Make-the-build-flags-match-RHEL-s-gobuild.patch
@ -0,0 +1,40 @@
+From 05722d2861c23554b9741c059e853da9ab38282e Mon Sep 17 00:00:00 2001
+From: Debarshi Ray <rishi@fedoraproject.org>
+Date: Mon, 29 Jun 2020 17:57:47 +0200
+Subject: [PATCH] build: Make the build flags match RHEL's %{gobuild}
+
+The Go toolchain doesn't play well with passing compiler and linker
+flags via environment variables. The linker flags require a second
+level of quoting, which leaves the build system without a quote level
+to assign the flags to an environment variable like GOFLAGS.
+
+This is one reason why RHEL doesn't have a RPM macro with only the
+flags. The %{gobuild} RPM macro includes the entire 'go build ...'
+invocation.
+
+The Go toolchain also doesn't like the LDFLAGS environment variable as
+exported by RHEL's %{meson} RPM macro, and RHEL's RPM toolchain doesn't
+like the compressed DWARF data generated by the Go toolchain.
+
+Note that these flags are meant for every CPU architecture other than
+PPC64, and should be kept updated to match RHEL's Go guidelines. Use
+'rpm --eval "%{gobuild}"' to expand the %{gobuild} macro.
+---
+ src/go-build-wrapper | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/go-build-wrapper b/src/go-build-wrapper
+index 0d27120da052..f08f3218560a 100755
+--- a/src/go-build-wrapper
+++ b/src/go-build-wrapper
+@@ -27,5 +27,6 @@ if ! cd "$1"; then
+     exit 1
+ fi
+ 
+-go build -trimpath -ldflags "-extldflags '-Wl,--wrap,pthread_sigmask $4' -linkmode external -X github.com/containers/toolbox/pkg/version.currentVersion=$3" -o "$2/toolbox"
+unset LDFLAGS
+go build -buildmode pie -compiler gc -tags="rpm_crashtraceback ${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -compressdwarf=false -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n') -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--wrap,pthread_sigmask $4' -linkmode external -X github.com/containers/toolbox/pkg/version.currentVersion=$3" -a -v -x -o "$2/toolbox"
+ exit "$?"
+-- 
+2.31.1
+
--- a/SPECS/toolbox.spec
+++ b/SPECS/toolbox.spec
@ -0,0 +1,148 @@
+# RHEL's RPM toolchain doesn't like the compressed DWARF data generated by the
+# Go toolchain.
+%global _dwz_low_mem_die_limit 0
+%global _find_debuginfo_dwz_opts %{nil}
+
+Name:          toolbox
+Version:       0.0.99.2^1.git660b6970e998
+
+%global goipath github.com/containers/%{name}
+%gometa
+
+Release:       1%{?dist}
+Summary:       Unprivileged development environment
+
+License:       ASL 2.0
+URL:           https://github.com/containers/%{name}
+
+# https://github.com/containers/%%{name}/releases/download/%%{version}/%%{name}-%%{version}.tar.xz
+# A vendored tarball was created from the upstream tarball:
+# $ cd src
+# $ go mod vendor
+Source0:       %{name}-%{version}-vendored.tar.xz
+
+# RHEL specific
+Patch100:      toolbox-Make-the-build-flags-match-RHEL-s-gobuild.patch
+Patch101:      toolbox-Make-the-build-flags-match-RHEL-s-gobuild-for-PPC64.patch
+
+# https://bugzilla.redhat.com/show_bug.cgi?id=1905383
+ExcludeArch:   %{ix86}
+
+BuildRequires: golang >= 1.13
+BuildRequires: go-md2man
+BuildRequires: meson
+BuildRequires: pkgconfig(bash-completion)
+BuildRequires: systemd
+
+Requires:      podman >= 1.4.0
+
+
+%description
+Toolbox is a tool for Linux operating systems, which allows the use of
+containerized command line environments. It is built on top of Podman and
+other standard container technologies from OCI.
+
+
+%package       tests
+Summary:       Tests for %{name}
+
+Requires:      %{name}%{?_isa} = %{version}-%{release}
+
+%description   tests
+The %{name}-tests package contains system tests for %{name}.
+
+
+%prep
+%setup -q
+
+%ifnarch ppc64
+%patch100 -p1
+%else
+%patch101 -p1
+%endif
+
+# %%gomkdir is absent from RHEL 8.
+GOBUILDDIR="$(pwd)/_build"
+GOSOURCEDIR="$(pwd)"
+if [[ ! -e "$GOBUILDDIR/bin" ]] ; then
+  install -m 0755 -vd "$GOBUILDDIR/bin"
+fi
+if [[ ! -e "$GOBUILDDIR/src/%{goipath}" ]] ; then
+  install -m 0755 -vd "$(dirname $GOBUILDDIR/src/%{goipath})"
+  ln -fs "$GOSOURCEDIR" "$GOBUILDDIR/src/%{goipath}"
+fi
+cd "$GOBUILDDIR/src/%{goipath}"
+
+
+%build
+export GO111MODULE=off
+GOBUILDDIR="$(pwd)/_build"
+export GOPATH="$GOBUILDDIR:%{gopath}"
+export CGO_CFLAGS="%{optflags} -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64"
+ln -s src/cmd cmd
+ln -s src/pkg pkg
+ln -s src/vendor vendor
+%meson --buildtype=plain -Dprofile_dir=%{_sysconfdir}/profile.d
+%meson_build
+
+
+%install
+%meson_install
+
+
+%files
+%doc CODE-OF-CONDUCT.md NEWS README.md SECURITY.md
+%license COPYING
+%{_bindir}/%{name}
+%{_datadir}/bash-completion
+%{_mandir}/man1/%{name}.1*
+%{_mandir}/man1/%{name}-*.1*
+%config(noreplace) %{_sysconfdir}/containers/%{name}.conf
+%{_sysconfdir}/profile.d/%{name}.sh
+%{_tmpfilesdir}/%{name}.conf
+
+%files tests
+%{_datadir}/%{name}
+
+
+%changelog
+* Wed Jul 28 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.99.2^1.git660b6970e998-1
+- Add support for configuration files
+Resolves: #1940082
+- Related: #1934415
+
+* Mon Jul 26 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.99.2-4
+- Instead of offering to log into a registry, just mention 'podman login'
+- Related: #1934415
+
+* Sat Jul 10 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.99.2-3
+- Expose the host's entire / in the container at /run/host
+- Related: #1934415
+
+* Mon Jul 05 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.99.2-2
+- Actually apply the patch to make 'toolbox' create or fall back to a
+  container if possible
+- Support logging into a registry if necessary
+- Related: #1934415
+
+* Fri Jul 02 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.99.2-1
+- Update to 0.0.99.2
+- Make 'toolbox' create or fall back to a container if possible
+Resolves: #1914687
+- Related: #1934415
+
+* Tue Jan 12 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.99-1
+- Update to 0.0.99
+- Related: #1883490
+
+* Tue Jan 12 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.98.1-3
+- remove bats as it's not present in RHEL
+- Related: #1883490
+
+* Mon Jan 11 2021 Jindrich Novy <jnovy@redhat.com> - 0.0.98.1-2
+- harden the toolbox binary
+- minor fixes
+- Related: #1883490
+
+* Fri Jan 08 2021 Debarshi Ray <rishi@fedoraproject.org> - 0.0.98.1-1
+- Rebase to github.com/containers/toolbox
				`@ -0,0 +1 @@`
				`SOURCES/toolbox-0.0.99.2^1.git660b6970e998-vendored.tar.xz`
				`@ -0,0 +1 @@`
				`53c96750cb48c825a54dea680922e46dc4b123ca SOURCES/toolbox-0.0.99.2^1.git660b6970e998-vendored.tar.xz`