--- pegasus/src/Pegasus/Server/HTTPAuthenticatorDelegator.cpp.local-or-remote-auth 2006-03-10 18:18:37.000000000 -0500 +++ pegasus/src/Pegasus/Server/HTTPAuthenticatorDelegator.cpp 2006-04-05 20:35:40.000000000 -0400 @@ -384,6 +384,9 @@ } } + // Let Authenticators know whether this user is Local or Remote: + httpMessage->authInfo->setRemoteUser( httpMessage->fromRemoteHost ); + // // Handle authentication: // --- pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorUnix.cpp.local-or-remote-auth 2006-01-30 11:18:28.000000000 -0500 +++ pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorUnix.cpp 2006-04-05 20:40:40.000000000 -0400 @@ -48,6 +48,8 @@ #include #endif +#include + #if defined (PEGASUS_USE_PAM_STANDALONE_PROC) #include #include @@ -131,7 +133,8 @@ Boolean PAMBasicAuthenticator::authenticate( const String& userName, - const String& password) + const String& password, + Boolean isRemoteUser) { PEG_METHOD_ENTER(TRC_AUTHENTICATION, "PAMBasicAuthenticator::authenticate()"); @@ -139,7 +142,7 @@ Boolean authenticated; #if !defined(PEGASUS_USE_PAM_STANDALONE_PROC) - authenticated = _authenticateByPAM(userName, password); + authenticated = _authenticateByPAM(userName, password, isRemoteUser); #else // // Mutex to Serialize Authentication calls. @@ -147,8 +150,9 @@ Tracer::trace(TRC_AUTHENTICATION, Tracer::LEVEL4, "Authentication Mutex lock."); AutoMutex lock(_authSerializeMutex); - authenticated = _pamBasicAuthenticatorStandAlone.authenticate( - userName, password); + authenticated = + _pamBasicAuthenticatorStandAlone->authenticate(userName, + password); #endif PEG_METHOD_EXIT(); @@ -157,7 +161,8 @@ Boolean PAMBasicAuthenticator::_authenticateByPAM( const String& userName, - const String& password) + const String& password, + Boolean isRemoteUser) { PEG_METHOD_ENTER(TRC_AUTHENTICATION, "PAMBasicAuthenticator::_authenticateByPAM()"); @@ -167,6 +172,7 @@ pam_handle_t *phandle; char *name; APP_DATA mydata; + int retcode; // // Store the password for PAM authentication @@ -180,13 +186,31 @@ // Tracer::trace(TRC_AUTHENTICATION, Tracer::LEVEL4, // "PAMBasicAuthenticator::_authenticateByPAM() - userName = %s; userPassword = %s", // (const char *)userName.getCString(), (const char *)password.getCString()); + + // NOTE: if any pam call should log anything, our syslog socket will be redirected + // to the AUTH facility, so we need to redirect it back after each pam call. // //Call pam_start since you need to before making any other PAM calls // - if ( ( pam_start(service, + + if ( (retcode = pam_start(service, (const char *)userName.getCString(), &pconv, &phandle) ) != PAM_SUCCESS ) { + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog( LOG_ERR, "pam_start failed: %s", pam_strerror(phandle, retcode)); + PEG_METHOD_EXIT(); + return (authenticated); + } + + + if ( (retcode = pam_set_item(phandle, PAM_TTY, isRemoteUser ? "wbemNetwork" : "wbemLocal")) != PAM_SUCCESS ) + { + pam_end(phandle, 0); + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog( LOG_ERR, "pam_set_item(PAM_TTY=wbem) failed: %s", pam_strerror(phandle, retcode)); PEG_METHOD_EXIT(); return (authenticated); } @@ -194,7 +218,7 @@ // //Call pam_authenticate to authenticate the user // - if ( ( pam_authenticate(phandle, 0) ) == PAM_SUCCESS ) + if ( ( retcode = pam_authenticate(phandle, 0) ) == PAM_SUCCESS ) { Tracer::trace(TRC_AUTHENTICATION, Tracer::LEVEL4, "pam_authenticate successful."); @@ -203,22 +227,40 @@ //checking for password and account expiration, as well as verifying access //hour restrictions. // - if ( ( pam_acct_mgmt(phandle, 0) ) == PAM_SUCCESS ) + + if ( ( retcode = pam_acct_mgmt(phandle, 0) ) == PAM_SUCCESS ) { Tracer::trace(TRC_AUTHENTICATION, Tracer::LEVEL4, "pam_acct_mgmt successful."); authenticated = true; - } + }else + { + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog(LOG_ERR, "pam_acct_mgmt failed: %s",pam_strerror(phandle, retcode)); + } + }else + { + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog(LOG_ERR, "pam_authenticate failed: %s",pam_strerror(phandle, retcode)); } - // //Call pam_end to end our PAM work // pam_end(phandle, 0); + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); - PEG_METHOD_EXIT(); + if ( ! authenticated ) + syslog(LOG_ERR, "PAM authentication failed for %s user: %s", + isRemoteUser ? "remote" : "local", + (const char*)userName.getCString() + ); + PEG_METHOD_EXIT(); return (authenticated); + } Boolean PAMBasicAuthenticator::validateUser(const String& userName) @@ -233,6 +275,7 @@ pam_handle_t *phandle; char *name; APP_DATA mydata; + int retcode; const char *service = "wbem"; pconv.conv = PAMBasicAuthenticator::pamValidateUserCallback; @@ -241,21 +284,43 @@ // // Call pam_start since you need to before making any other PAM calls // - if ( pam_start(service, - (const char *)userName.getCString(), &pconv, &phandle) != PAM_SUCCESS) - { + if ( (retcode = + pam_start(service,(const char *)userName.getCString(), &pconv, &phandle) + ) != PAM_SUCCESS + ) + { + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog( LOG_ERR, "pam_start() failed: %s", pam_strerror(phandle, retcode)); PEG_METHOD_EXIT(); return (authenticated); } + if ( (retcode = pam_set_item(phandle, PAM_TTY, "wbemLocal")) != PAM_SUCCESS ) + { + pam_end(phandle, 0); + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog( LOG_ERR, "pam_set_item(PAM_TTY=wbemLocal) failed: %s", pam_strerror(phandle, retcode)); + PEG_METHOD_EXIT(); + return (authenticated); + } // // Call pam_acct_mgmt, to check if the user account is valid. This includes // checking for account expiration, as well as verifying access // hour restrictions. // - if ( pam_acct_mgmt(phandle, 0) == PAM_SUCCESS ) - { + if ( (retcode = pam_acct_mgmt(phandle, 0)) == PAM_SUCCESS ) + { authenticated = true; + }else + { + pam_end(phandle, 0); + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + syslog( LOG_ERR, "pam_acct_mgmt() failed: %s", pam_strerror(phandle, retcode)); + PEG_METHOD_EXIT(); + return (authenticated); } // @@ -263,6 +328,9 @@ // pam_end(phandle, 0); + closelog(); + openlog("cimserver", LOG_PID, LOG_DAEMON); + #else // // Mutex to Serialize Authentication calls. --- pegasus/src/Pegasus/Security/Authentication/BasicAuthenticator.h.local-or-remote-auth 2006-01-30 11:18:28.000000000 -0500 +++ pegasus/src/Pegasus/Security/Authentication/BasicAuthenticator.h 2006-04-05 20:35:40.000000000 -0400 @@ -67,7 +67,8 @@ */ virtual Boolean authenticate( const String& userName, - const String& password) = 0; + const String& password, + Boolean isRemoteUser) = 0; /** Construct and return the HTTP Basic authentication challenge header @return A string containing the authentication challenge header. --- pegasus/src/Pegasus/Security/Authentication/BasicAuthenticationHandler.cpp.local-or-remote-auth 2006-01-30 11:18:28.000000000 -0500 +++ pegasus/src/Pegasus/Security/Authentication/BasicAuthenticationHandler.cpp 2006-04-05 20:35:40.000000000 -0400 @@ -138,7 +138,7 @@ authInfo->setAuthenticatedUser(userName); authInfo->setAuthenticatedPassword(password); #else - authenticated = _basicAuthenticator->authenticate(userName, password); + authenticated = _basicAuthenticator->authenticate(userName, password, authInfo->isRemoteUser()); if (authenticated) { --- pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorStub.cpp.local-or-remote-auth 2006-01-30 11:18:28.000000000 -0500 +++ pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorStub.cpp 2006-04-05 20:35:40.000000000 -0400 @@ -92,7 +92,8 @@ Boolean PAMBasicAuthenticator::authenticate( const String& userName, - const String& password) + const String& password, + Boolean isRemoteUser) { PEG_METHOD_ENTER(TRC_AUTHENTICATION, "PAMBasicAuthenticator::authenticate()"); --- pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticator.h.local-or-remote-auth 2006-01-30 11:18:28.000000000 -0500 +++ pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticator.h 2006-04-05 20:35:40.000000000 -0400 @@ -73,7 +73,8 @@ */ Boolean authenticate( const String& userName, - const String& password); + const String& password, + Boolean isRemoteUser); /** Verify PAM account management for the requesting user. @param userName String containing the user name @@ -102,7 +103,8 @@ Boolean _authenticateByPAM( const String& userName, - const String& password); + const String& password, + Boolean isRemoteUser); void _createPAMStandalone(); @@ -158,7 +160,8 @@ */ Boolean authenticate( const String& userName, - const String& password); + const String& password, + Boolean isRemoteUser); /** Verify whether the user is valid. @param userName String containing the user name @@ -220,7 +223,8 @@ Boolean _authenticateByPAM( const String& userName, - const String& password); + const String& password, + Boolean isRemoteUser); #if defined(PEGASUS_USE_PAM_STANDALONE_PROC) PAMBasicAuthenticatorStandAlone _pamBasicAuthenticatorStandAlone; --- pegasus/src/Pegasus/Common/AuthenticationInfoRep.cpp.local-or-remote-auth 2006-01-30 11:16:46.000000000 -0500 +++ pegasus/src/Pegasus/Common/AuthenticationInfoRep.cpp 2006-04-05 20:35:40.000000000 -0400 @@ -57,7 +57,8 @@ _privileged(false), _authType(String::EMPTY), _authStatus(NEW_REQUEST), - _exportConnection(false) + _exportConnection(false), + _remoteUser(true) { PEG_METHOD_ENTER( TRC_AUTHENTICATION, "AuthenticationInfoRep::AuthenticationInfoRep"); @@ -180,5 +181,14 @@ PEG_METHOD_EXIT(); } +void AuthenticationInfoRep::setRemoteUser(Boolean remoteUser) +{ + PEG_METHOD_ENTER(TRC_AUTHENTICATION, + "AuthenticationInfoRep::setRemoteUser"); + + _remoteUser = remoteUser; + + PEG_METHOD_EXIT(); +} PEGASUS_NAMESPACE_END --- pegasus/src/Pegasus/Common/HTTPMessage.cpp.local-or-remote-auth 2006-01-30 11:17:04.000000000 -0500 +++ pegasus/src/Pegasus/Common/HTTPMessage.cpp 2006-04-05 20:35:40.000000000 -0400 @@ -119,7 +119,8 @@ queueId(queueId_), authInfo(0), acceptLanguagesDecoded(false), - contentLanguagesDecoded(false) + contentLanguagesDecoded(false), + fromRemoteHost(true) { if (cimException_) cimException = *cimException_; --- pegasus/src/Pegasus/Common/AuthenticationInfo.h.local-or-remote-auth 2006-01-30 11:16:46.000000000 -0500 +++ pegasus/src/Pegasus/Common/AuthenticationInfo.h 2006-04-05 20:35:40.000000000 -0400 @@ -331,6 +331,22 @@ _rep->setClientCertificateChain(clientCertificate); } + /** Indicate whether the user is Remote + */ + Boolean isRemoteUser() const + { + _checkRep(); + return _rep->isRemoteUser(); + } + + /** Set the Remote User flag + */ + void setRemoteUser(Boolean remoteUser) + { + _checkRep(); + _rep->setRemoteUser(remoteUser); + } + private: AuthenticationInfo(AuthenticationInfoRep* rep) : _rep(rep) --- pegasus/src/Pegasus/Common/HTTPConnection.cpp.local-or-remote-auth 2006-02-28 21:21:37.000000000 -0500 +++ pegasus/src/Pegasus/Common/HTTPConnection.cpp 2006-04-05 20:35:40.000000000 -0400 @@ -1828,6 +1828,30 @@ "_requestCount = %d", _requestCount.get()); message->dest = _outputMessageQueue->getQueueId(); // SendForget(message); + + // Allow authenticators to differentiate Remote and Local users: + struct sockaddr_in sin_peer, sin_svr; // don't need to worry about IPv6 yet ... + socklen_t slen1=sizeof(struct sockaddr_in), slen2=sizeof(struct sockaddr_in); + uint32_t sock = _socket.get()->getSocket() ; + memset(&sin_peer,'\0',slen1); + memset(&sin_svr, '\0',slen2); + if ( ( ::getpeername( sock, (struct sockaddr*)&sin_peer, &slen1) == 0 ) + ||( ::getsockname( sock, (struct sockaddr*)&sin_svr, &slen2) == 0 ) + ) + { + if( sin_peer.sin_family == AF_INET ) + { + if( ((ntohl( sin_peer.sin_addr.s_addr ) >> 24) & 0xff) == 127 ) + // message was sent FROM localhost interface + message->fromRemoteHost = false; + } + if( sin_svr.sin_family == AF_INET ) + { + if( ((ntohl( sin_svr.sin_addr.s_addr ) >> 24) & 0xff) == 127 ) + // message was sent TO localhost interface + message->fromRemoteHost = false; + } + } // // Set the entry status to BUSY. --- pegasus/src/Pegasus/Common/AuthenticationInfoRep.h.local-or-remote-auth 2006-01-30 11:16:46.000000000 -0500 +++ pegasus/src/Pegasus/Common/AuthenticationInfoRep.h 2006-04-05 20:37:59.000000000 -0400 @@ -143,6 +143,14 @@ void setExportConnection(Boolean exportConnection); + Boolean isRemoteUser() const + { + return _remoteUser; + } + + void setRemoteUser(Boolean remoteUser); + + //PEP187 Array getClientCertificateChain() { @@ -173,7 +181,8 @@ #endif Boolean _exportConnection; - Array _clientCertificate; + Array _clientCertificate; + Boolean _remoteUser; }; PEGASUS_NAMESPACE_END --- pegasus/src/Pegasus/Common/HTTPMessage.h.local-or-remote-auth 2006-01-30 11:17:04.000000000 -0500 +++ pegasus/src/Pegasus/Common/HTTPMessage.h 2006-04-05 20:35:40.000000000 -0400 @@ -80,7 +80,8 @@ ContentLanguageList contentLanguages; Boolean acceptLanguagesDecoded; Boolean contentLanguagesDecoded; - CIMException cimException; + Boolean fromRemoteHost; + CIMException cimException; void parse( String& startLine,