Fix a regression in LUN creation and ACL mapping

Resolves: RHEL-23294

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
This commit is contained in:
Maurizio Lombardi 2024-01-30 13:08:45 +01:00
parent 3ecf901b97
commit 442b73e32b
2 changed files with 37 additions and 2 deletions

View File

@ -0,0 +1,31 @@
From 02831aca57444862b9546d2d8a02e59d6ec4aaf1 Mon Sep 17 00:00:00 2001
From: Maurizio Lombardi <mlombard@redhat.com>
Date: Tue, 30 Jan 2024 13:03:08 +0100
Subject: [PATCH] Fix mapping the new LUN to the node ACL
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
targetcli/ui_target.py | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/targetcli/ui_target.py b/targetcli/ui_target.py
index 2c46765f9d1a..65df61f96185 100644
--- a/targetcli/ui_target.py
+++ b/targetcli/ui_target.py
@@ -1151,10 +1151,9 @@ class UILUNs(UINode):
possible_mlun += 1
mapped_lun = possible_mlun
- else:
- mlun = MappedLUN(acl, mapped_lun, lun_object, write_protect=False)
- self.shell.log.info("Created LUN %d->%d mapping in node ACL %s"
- % (mlun.tpg_lun.lun, mlun.mapped_lun, acl.node_wwn))
+ mlun = MappedLUN(acl, mapped_lun, lun_object, write_protect=False)
+ self.shell.log.info("Created LUN %d->%d mapping in node ACL %s"
+ % (mlun.tpg_lun.lun, mlun.mapped_lun, acl.node_wwn))
self.parent.refresh()
return self.new_node(ui_lun)
--
2.39.3

View File

@ -4,7 +4,7 @@ Name: targetcli
License: ASL 2.0
Summary: An administration shell for storage targets
Version: 2.1.57
Release: 1%{?dist}
Release: 2%{?dist}
URL: https://github.com/open-iscsi/%{oname}
Source: %{url}/archive/v%{version}/%{oname}-%{version}.tar.gz
# Proposed upstream
@ -13,7 +13,7 @@ BuildArch: noarch
BuildRequires: python3-devel, python3-setuptools, systemd-rpm-macros
Requires: python3-rtslib, target-restore, python3-configshell, python3-six, python3-dbus
Requires: python3-gobject-base
Patch0: 0001-Fix-mapping-the-new-LUN-to-the-node-ACL.patch
%description
An administration shell for configuring iSCSI, FCoE, and other
@ -23,6 +23,7 @@ users will also need to install and use fcoe-utils.
%prep
%setup -q -n %{oname}-%{version}
%patch0 -p1
%build
%py3_build
@ -47,6 +48,9 @@ install -m 644 systemd/* %{buildroot}%{_unitdir}/
%dir %{_sysconfdir}/target/backup
%changelog
* Tue Jan 30 2024 Maurizio Lombardi <mlombard@redhat.com> - 2.1.57-2
- Fix a regression in LUN creation and ACL mapping Jira: RHEL-23294
* Mon Oct 30 2023 Maurizio Lombardi <mlombard@redhat.com> - 2.1.57-1
- Update to the latest version