From 4562dee4d1661734be3c119e12a88fa7df1850f4 Mon Sep 17 00:00:00 2001
From: Jan Macku <jamacku@redhat.com>
Date: Tue, 15 Oct 2024 14:34:12 +0200
Subject: [PATCH] systemd-252-48

Resolves: RHEL-36531
---
 ...By-default.target-is-not-a-good-idea.patch | 33 +++++++++++++++++++
 systemd.spec                                  |  6 +++-
 2 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 1043-man-using-WantedBy-default.target-is-not-a-good-idea.patch

diff --git a/1043-man-using-WantedBy-default.target-is-not-a-good-idea.patch b/1043-man-using-WantedBy-default.target-is-not-a-good-idea.patch
new file mode 100644
index 0000000..4a20942
--- /dev/null
+++ b/1043-man-using-WantedBy-default.target-is-not-a-good-idea.patch
@@ -0,0 +1,33 @@
+From ebb65ff6498d81a846aa9d583b9a970562c3ae02 Mon Sep 17 00:00:00 2001
+From: Lukas Nykryn <lnykryn@redhat.com>
+Date: Tue, 1 Oct 2024 11:30:18 +0200
+Subject: [PATCH] man: using WantedBy=default.target is not a good idea
+
+We had several users, that wrote their unit files with
+WantedBy=default.target because it should be started "every time".
+But for example in Fedora/CentOS/RHEL, this often breaks for
+example selinux relabels (where we just want to do a relabel and reboot).
+
+(cherry picked from commit 67b6404b80cf8078f3d9ec6d4c2f34ac25b15077)
+
+Resolves: RHEL-36531
+---
+ man/systemd.special.xml | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/man/systemd.special.xml b/man/systemd.special.xml
+index 1620895511..0c1f03ecf3 100644
+--- a/man/systemd.special.xml
++++ b/man/systemd.special.xml
+@@ -229,6 +229,11 @@
+             names like <varname>single</varname>, <varname>rescue</varname>, <varname>1</varname>,
+             <varname>3</varname>, <varname>5</varname>, …; see
+             <citerefentry><refentrytitle>systemd</refentrytitle><manvolnum>1</manvolnum></citerefentry>.</para>
++
++            <para>For typical unit files please set <literal>WantedBy=</literal> to a regular target (like
++            <filename>multi-user.target</filename> or <filename>graphical.target</filename>),
++            instead of <filename>default.target</filename>, since such a service will also be run on special
++            boots like on system update, emergency boot…</para>
+           </listitem>
+         </varlistentry>
+         <varlistentry>
diff --git a/systemd.spec b/systemd.spec
index 8d04ee2..f5ce81f 100644
--- a/systemd.spec
+++ b/systemd.spec
@@ -21,7 +21,7 @@
 Name:           systemd
 Url:            https://systemd.io
 Version:        252
-Release:        47%{?dist}
+Release:        48%{?dist}
 # For a breakdown of the licensing, see README
 License:        LGPLv2+ and MIT and GPLv2+
 Summary:        System and Service Manager
@@ -1125,6 +1125,7 @@ Patch1039: 1039-efi-add-helper-API-for-detecting-confidential-virtua.patch
 Patch1040: 1040-efi-don-t-pull-kernel-cmdline-from-SMBIOS-in-a-confi.patch
 Patch1041: 1041-Fix-detection-of-TDX-confidential-VM-on-Azure-platfo.patch
 Patch1042: 1042-ukify-Skip-test-on-architectures-without-UEFI.patch
+Patch1043: 1043-man-using-WantedBy-default.target-is-not-a-good-idea.patch
 
 # Downstream-only patches (9000–9999)
 
@@ -2001,6 +2002,9 @@ systemd-hwdb update &>/dev/null || :
 %{_prefix}/lib/dracut/modules.d/70rhel-net-naming-sysattrs/*
 
 %changelog
+* Tue Oct 15 2024 systemd maintenance team <systemd-maint@redhat.com> - 252-48
+- man: using WantedBy=default.target is not a good idea (RHEL-36531)
+
 * Tue Sep 10 2024 systemd maintenance team <systemd-maint@redhat.com> - 252-47
 - get rid of SELinux policy module (RHEL-58179)