systemd/0408-test-bus-policy-silence-coverity.patch

39 lines
1.0 KiB
Diff
Raw Normal View History

2014-10-04 02:43:52 +00:00
From 5e90b6a978d15efedc5b5cc4a3d2d922a0ecd2a9 Mon Sep 17 00:00:00 2001
From: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Sun, 28 Sep 2014 18:46:15 +0200
Subject: [PATCH] test-bus-policy: silence coverity
Check if strjoin worked and also use _cleanup_free_ since we are
here.
Found with Coverity. Fixes CID#1241962
---
src/bus-proxyd/test-bus-policy.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/bus-proxyd/test-bus-policy.c b/src/bus-proxyd/test-bus-policy.c
index 900e4d2b06..7bcebef905 100644
--- a/src/bus-proxyd/test-bus-policy.c
+++ b/src/bus-proxyd/test-bus-policy.c
@@ -46,18 +46,17 @@
static int test_policy_load(Policy *p, const char *name)
{
- char *path;
+ _cleanup_free_ char *path = NULL;
int r = 0;
path = strjoin(TEST_DIR, "/bus-policy/", name, NULL);
+ assert_se(path);
if (access(path, R_OK) == 0)
policy_load(p, STRV_MAKE(path));
else
r = -ENOENT;
- free(path);
-
return r;
}