27 lines
1.0 KiB
Diff
27 lines
1.0 KiB
Diff
|
From af6eac25456d4ca7e8233e00aec7531e640f17af Mon Sep 17 00:00:00 2001
|
||
|
|
From: Lennart Poettering <lennart@poettering.net>
|
||
|
|
Date: Fri, 5 Apr 2019 15:31:34 +0200
|
||
|
|
Subject: [PATCH] lgtm: warn about strerror() use
|
||
|
|
|
||
|
|
(cherry picked from commit 9ff46eded2b99d244455467eb55c0ff3f51c5362)
|
||
|
|
|
||
|
|
Related: #2017033
|
||
|
|
---
|
||
|
|
.lgtm/cpp-queries/PotentiallyDangerousFunction.ql | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql b/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
|
||
|
|
index cd0284b37a..96712cf1c6 100644
|
||
|
|
--- a/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
|
||
|
|
+++ b/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
|
||
|
|
@@ -38,6 +38,9 @@ predicate potentiallyDangerousFunction(Function f, string message) {
|
||
|
|
) or (
|
||
|
|
f.getQualifiedName() = "ntohs" and
|
||
|
|
message = "Call to ntohs() is confusing. Use be16toh() instead."
|
||
|
|
+ ) or (
|
||
|
|
+ f.getQualifiedName() = "strerror" and
|
||
|
|
+ message = "Call to strerror() is not thread-safe. Use strerror_r() or printf()'s %m format string instead."
|
||
|
|
)
|
||
|
|
}
|
||
|
|
|