From a0e3759b733a5b5db82bea2ef35e1519ea8a9b1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Fri, 16 Oct 2020 15:33:42 +0200 Subject: [PATCH 02/19] kcm: avoid name confusion in GET_CRED_UUID_LIST handlers The function name did not follow best practices and it got easily confused with `kcm_op_get_cred_by_uuid_getbyname_done`. ``` kcm_op_get_cred_uuid_getbyname_done kcm_op_get_cred_by_uuid_getbyname_done ``` --- src/responder/kcm/kcmsrv_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/responder/kcm/kcmsrv_ops.c b/src/responder/kcm/kcmsrv_ops.c index 1e8e4d6a3b4feba5bac3eb0a5fa6a22a588ba985..7fc3b0a5c4e123a398ef103f3ce92b45bc68f5cf 100644 --- a/src/responder/kcm/kcmsrv_ops.c +++ b/src/responder/kcm/kcmsrv_ops.c @@ -1072,7 +1072,7 @@ static void kcm_op_get_principal_getbyname_done(struct tevent_req *subreq) } /* (name) -> (uuid, ...) */ -static void kcm_op_get_cred_uuid_getbyname_done(struct tevent_req *subreq); +static void kcm_op_get_cred_uuid_list_getbyname_done(struct tevent_req *subreq); static struct tevent_req * kcm_op_get_cred_uuid_list_send(TALLOC_CTX *mem_ctx, @@ -1106,7 +1106,7 @@ kcm_op_get_cred_uuid_list_send(TALLOC_CTX *mem_ctx, ret = ENOMEM; goto immediate; } - tevent_req_set_callback(subreq, kcm_op_get_cred_uuid_getbyname_done, req); + tevent_req_set_callback(subreq, kcm_op_get_cred_uuid_list_getbyname_done, req); return req; immediate: @@ -1115,7 +1115,7 @@ immediate: return req; } -static void kcm_op_get_cred_uuid_getbyname_done(struct tevent_req *subreq) +static void kcm_op_get_cred_uuid_list_getbyname_done(struct tevent_req *subreq) { errno_t ret; struct kcm_ccache *cc; -- 2.25.4