Resolves: RHEL-78061 - 'sssd_kcm' leaks memory
This commit is contained in:
parent
cf82e80b44
commit
96a29f20a8
58
0002-KCM-another-memory-leak-fixed.patch
Normal file
58
0002-KCM-another-memory-leak-fixed.patch
Normal file
@ -0,0 +1,58 @@
|
|||||||
|
From 9e72bc242b600158d7920b2b98644efa42fd1ffa Mon Sep 17 00:00:00 2001
|
||||||
|
From: Alexey Tikhonov <atikhono@redhat.com>
|
||||||
|
Date: Wed, 12 Feb 2025 11:30:22 +0100
|
||||||
|
Subject: [PATCH] KCM: another memory leak fixed
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
```
|
||||||
|
...
|
||||||
|
talloc_new: src/responder/kcm/kcmsrv_ccache.c:405 contains 0 bytes in 1 blocks (ref 0) 0x563feaabc0a0
|
||||||
|
talloc_new: src/responder/kcm/kcmsrv_ccache.c:405 contains 0 bytes in 1 blocks (ref 0) 0x563feaa84f90
|
||||||
|
talloc_new: src/responder/kcm/kcmsrv_ccache.c:405 contains 0 bytes in 1 blocks (ref 0) 0x563feaabf520
|
||||||
|
...
|
||||||
|
```
|
||||||
|
|
||||||
|
Reviewed-by: Alejandro López <allopez@redhat.com>
|
||||||
|
---
|
||||||
|
src/responder/kcm/kcmsrv_ccache.c | 8 +++++---
|
||||||
|
1 file changed, 5 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/src/responder/kcm/kcmsrv_ccache.c b/src/responder/kcm/kcmsrv_ccache.c
|
||||||
|
index f614156cc..bf8daffd0 100644
|
||||||
|
--- a/src/responder/kcm/kcmsrv_ccache.c
|
||||||
|
+++ b/src/responder/kcm/kcmsrv_ccache.c
|
||||||
|
@@ -407,7 +407,7 @@ krb5_creds **kcm_cc_unmarshal(TALLOC_CTX *mem_ctx,
|
||||||
|
|
||||||
|
tmp_ctx = talloc_new(NULL);
|
||||||
|
if (tmp_ctx == NULL) {
|
||||||
|
- goto done;
|
||||||
|
+ goto fail;
|
||||||
|
}
|
||||||
|
|
||||||
|
for (cred = kcm_cc_get_cred(cc); cred != NULL; cred = kcm_cc_next_cred(cred)) {
|
||||||
|
@@ -420,7 +420,7 @@ krb5_creds **kcm_cc_unmarshal(TALLOC_CTX *mem_ctx,
|
||||||
|
cred_list[i] = kcm_cred_to_krb5(krb_context, cred);
|
||||||
|
if (cred_list[i] == NULL) {
|
||||||
|
DEBUG(SSSDBG_CRIT_FAILURE, "Failed to convert kcm cred to krb5\n");
|
||||||
|
- goto done;
|
||||||
|
+ goto fail;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -429,8 +429,10 @@ krb5_creds **kcm_cc_unmarshal(TALLOC_CTX *mem_ctx,
|
||||||
|
|
||||||
|
talloc_steal(mem_ctx, cred_list);
|
||||||
|
|
||||||
|
+ talloc_free(tmp_ctx);
|
||||||
|
return cred_list;
|
||||||
|
-done:
|
||||||
|
+
|
||||||
|
+fail:
|
||||||
|
talloc_free(tmp_ctx);
|
||||||
|
return NULL;
|
||||||
|
#endif
|
||||||
|
--
|
||||||
|
2.47.0
|
||||||
|
|
@ -57,7 +57,7 @@
|
|||||||
|
|
||||||
Name: sssd
|
Name: sssd
|
||||||
Version: 2.10.2
|
Version: 2.10.2
|
||||||
Release: 2%{?dist}
|
Release: 3%{?dist}
|
||||||
Summary: System Security Services Daemon
|
Summary: System Security Services Daemon
|
||||||
License: GPL-3.0-or-later
|
License: GPL-3.0-or-later
|
||||||
URL: https://github.com/SSSD/sssd/
|
URL: https://github.com/SSSD/sssd/
|
||||||
@ -66,6 +66,7 @@ Source1: sssd.sysusers
|
|||||||
|
|
||||||
### Patches ###
|
### Patches ###
|
||||||
Patch0001: 0001-KCM-fix-memory-leak.patch
|
Patch0001: 0001-KCM-fix-memory-leak.patch
|
||||||
|
Patch0002: 0002-KCM-another-memory-leak-fixed.patch
|
||||||
|
|
||||||
### Dependencies ###
|
### Dependencies ###
|
||||||
|
|
||||||
@ -1116,6 +1117,9 @@ fi
|
|||||||
%systemd_postun_with_restart sssd.service
|
%systemd_postun_with_restart sssd.service
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Wed Feb 12 2025 Alexey Tikhonov <atikhono@redhat.com> - 2.10.2-3
|
||||||
|
- Resolves: RHEL-78061 - 'sssd_kcm' leaks memory
|
||||||
|
|
||||||
* Mon Feb 10 2025 Alexey Tikhonov <atikhono@redhat.com> - 2.10.2-2
|
* Mon Feb 10 2025 Alexey Tikhonov <atikhono@redhat.com> - 2.10.2-2
|
||||||
- Resolves: RHEL-78061 - 'sssd_kcm' leaks memory
|
- Resolves: RHEL-78061 - 'sssd_kcm' leaks memory
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user