From 570b15e0ea71950ff14ddc2bf667e9e361720939 Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Thu, 24 Sep 2020 12:13:44 +0100 Subject: [PATCH vd_agent_linux 15/17] vdagentd: Limit number of agents per session to 1 Signed-off-by: Frediano Ziglio Acked-by: Uri Lublin --- src/vdagentd/vdagentd.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index bb39340..5ef547e 100644 --- a/src/vdagentd/vdagentd.c +++ b/src/vdagentd/vdagentd.c @@ -955,6 +955,20 @@ static gboolean remove_active_xfers(gpointer key, gpointer value, gpointer conn) return 0; } +/* Check if this connection matches the passed session */ +static int connection_matches_session(UdscsConnection *conn, void *priv) +{ + const char *session = priv; + const struct agent_data *agent_data = g_object_get_data(G_OBJECT(conn), "agent_data"); + + if (!agent_data || !agent_data->session || + strcmp(agent_data->session, session) != 0) { + return 0; + } + + return 1; +} + /* Check a given process has a given UID */ static bool check_uid_of_pid(pid_t pid, uid_t uid) { @@ -1007,6 +1021,16 @@ static void agent_connect(UdscsConnection *conn) udscs_server_destroy_connection(server, conn); return; } + + // Check there are no other connection for this session + // Note that "conn" is not counted as "agent_data" is still not attached to it + if (udscs_server_for_all_clients(server, connection_matches_session, + agent_data->session) > 0) { + syslog(LOG_ERR, "An agent is already connected for this session"); + agent_data_destroy(agent_data); + udscs_server_destroy_connection(server, conn); + return; + } } g_object_set_data_full(G_OBJECT(conn), "agent_data", agent_data, -- 2.26.2