From 81d8175d9d6a8297b10cead6c951bf560f61be4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 28 Apr 2015 14:30:28 +0200 Subject: [PATCH spice-gtk] audio: channel-new handler to be after default handlers Client usually connect to channel-new to connect their handlers, such as open-fd. The audio channel-new handler will call channel_connect() on audio channels, which may call open-fd. However, open-fd can be emitted before the client had a chance to connect their handlers (from the channel-new callback). Connecting after the default handler solves this case. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=747649 --- gtk/spice-audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c index 7784c8b..ce191e1 100644 --- a/gtk/spice-audio.c +++ b/gtk/spice-audio.c @@ -267,7 +267,7 @@ SpiceAudio *spice_audio_new(SpiceSession *session, GMainContext *context, return NULL; spice_g_signal_connect_object(session, "notify::enable-audio", G_CALLBACK(session_enable_audio), self, 0); - spice_g_signal_connect_object(session, "channel-new", G_CALLBACK(channel_new), self, 0); + spice_g_signal_connect_object(session, "channel-new", G_CALLBACK(channel_new), self, G_CONNECT_AFTER); update_audio_channels(self, session); return self; -- 2.1.0