rpms/seabios
6
0
Fork 0
Code Issues Pull Requests Releases Activity

* Tue Nov 26 2024 Miroslav Rezanina <mrezanin@redhat.com> - 1.16.3-3

Browse Source 
- seabios-pciinit-don-t-misalign-large-BARs.patch [RHEL-67846]
- Resolves: RHEL-67846
  (amdgpu failed to initialize when multiple AMD MI210 GPUs assigned and firmware is seabios [rhel-9])
This commit is contained in:
Miroslav Rezanina 2024-11-26 02:48:52 -05:00
parent 9b553c773b
commit d4cb356929
2 changed files with 67 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
seabios-pciinit-don-t-misalign-large-BARs.patch Normal file
View File

@ -0,0 +1,59 @@
From 7d2072de0bcaadc13a6d1e054fa075d64fffc904 Mon Sep 17 00:00:00 2001
From: Daniil Tatianin <d-tatianin@yandex-team.ru>
Date: Thu, 11 Apr 2024 22:51:35 +0300
Subject: [PATCH] pciinit: don't misalign large BARs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
RH-Author: Gerd Hoffmann <kraxel@redhat.com>
RH-MergeRequest: 7: pciinit: don't misalign large BARs
RH-Jira: RHEL-67846
RH-Acked-by: Oliver Steffen <osteffen@redhat.com>
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
RH-Commit: [1/1] a6bce3cb0308b7d07804c5563160bfd9478c5d1f (kraxel.rh/centos-src-seabios)
Previously we would unconditionally lower the alignment for large BARs
in case their alignment was greater than "pci_mem64_top >> 11", this
would make it impossible to use these devices by the kernel:
[ 13.821108] pci 0000:9c:00.0: can't claim BAR 1 [mem 0x66000000000-0x67fffffffff 64bit pref]: no compatible bridge window
[ 13.823492] pci 0000:9d:00.0: can't claim BAR 1 [mem 0x64000000000-0x65fffffffff 64bit pref]: no compatible bridge window
[ 13.824218] pci 0000:9e:00.0: can't claim BAR 1 [mem 0x62000000000-0x63fffffffff 64bit pref]: no compatible bridge window
[ 13.828322] pci 0000:8a:00.0: can't claim BAR 1 [mem 0x6e000000000-0x6ffffffffff 64bit pref]: no compatible bridge window
[ 13.830691] pci 0000:8b:00.0: can't claim BAR 1 [mem 0x6c000000000-0x6dfffffffff 64bit pref]: no compatible bridge window
[ 13.832218] pci 0000:8c:00.0: can't claim BAR 1 [mem 0x6a000000000-0x6bfffffffff 64bit pref]: no compatible bridge window
Fix it by only overwriting the alignment in case it's actually greater
than the desired by the BAR window.
Fixes: 96a8d130a8c ("be less conservative with the 64bit pci io window")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(cherry picked from commit e5f2e4c69643bc3cd385306a9e5d29e11578148c)
Resolves: RHEL-67846
---
src/fw/pciinit.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
index 6b13cd5b..bb44dc29 100644
--- a/src/fw/pciinit.c
+++ b/src/fw/pciinit.c
@@ -970,9 +970,11 @@ static int pci_bios_check_devices(struct pci_bus *busses)
int resource_optional = 0;
if (hotplug_support == HOTPLUG_PCIE)
resource_optional = pcie_cap && (type == PCI_REGION_TYPE_IO);
+
+ u64 top_align = pci_mem64_top >> 11;
if (hotplug_support && pci_pad_mem64 && is64
- && (type == PCI_REGION_TYPE_PREFMEM))
- align = pci_mem64_top >> 11;
+ && (type == PCI_REGION_TYPE_PREFMEM) && (top_align > align))
+ align = top_align;
if (align > sum && hotplug_support && !resource_optional)
sum = align; /* reserve min size for hot-plug */
if (size > sum) {
--
2.39.3

9
seabios.spec
View File

@ -1,6 +1,6 @@
Name: seabios
Version: 1.16.3
Release: 2%{?dist}
Release: 3%{?dist}
Summary: Open-source legacy BIOS implementation
License: LGPLv3
@ -19,6 +19,8 @@ Source21: config.vga-bochs-display
Patch1: seabios-add-hwerr_printf-function-for-threads.patch
# For RHEL-7110 - [seabios] Can't boot from a disk with 4K sector size
Patch2: seabios-display-error-message-for-blocksizes-512.patch
# For RHEL-67846 - amdgpu failed to initialize when multiple AMD MI210 GPUs assigned and firmware is seabios [rhel-9]
Patch3: seabios-pciinit-don-t-misalign-large-BARs.patch
BuildRequires: make
BuildRequires: gcc
@ -135,6 +137,11 @@ install -m 0644 binaries/vgabios*.bin $RPM_BUILD_ROOT%{_datadir}/seavgabios
%{_datadir}/seavgabios/vgabios*.bin
%changelog
* Tue Nov 26 2024 Miroslav Rezanina <mrezanin@redhat.com> - 1.16.3-3
- seabios-pciinit-don-t-misalign-large-BARs.patch [RHEL-67846]
- Resolves: RHEL-67846
(amdgpu failed to initialize when multiple AMD MI210 GPUs assigned and firmware is seabios [rhel-9])
* Wed Jan 10 2024 Miroslav Rezanina <mrezanin@redhat.com> - 1.16.3-2
- seabios-add-hwerr_printf-function-for-threads.patch [RHEL-7110]
- seabios-display-error-message-for-blocksizes-512.patch [RHEL-7110]