From 722fbfa355db26e9cf28f4573ced199aa72446c7 Mon Sep 17 00:00:00 2001
From: Vitezslav Crhonek <vcrhonek@redhat.com>
Date: Tue, 4 Sep 2012 13:07:38 +0200
Subject: [PATCH] Fix issues found by fedora-review utility in the spec file

---
 sblim-cmpi-base.spec | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/sblim-cmpi-base.spec b/sblim-cmpi-base.spec
index fb7ef8c..782f96e 100644
--- a/sblim-cmpi-base.spec
+++ b/sblim-cmpi-base.spec
@@ -1,6 +1,6 @@
 Name:           sblim-cmpi-base
 Version:        1.6.1
-Release:        7%{?dist}
+Release:        8%{?dist}
 Summary:        SBLIM CMPI Base Providers
 
 Group:          Applications/System
@@ -11,7 +11,6 @@ Patch0:         sblim-cmpi-base-1.6.0-missing-fclose.patch
 Patch1:         sblim-cmpi-base-1.6.0-methods-enable.patch
 Patch2:         sblim-cmpi-base-1.6.0-provider-register-sfcb-init.patch
 Patch3:         sblim-cmpi-base-1.6.1-double-fclose.patch
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires:       cim-server sblim-indication_helper
 BuildRequires:  sblim-cmpi-devel sblim-indication_helper-devel
 
@@ -56,7 +55,6 @@ sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
 make
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 cp -fp *OSBase_UnixProcess.h $RPM_BUILD_ROOT/%{_includedir}/sblim
 chmod 644 $RPM_BUILD_ROOT/%{_includedir}/sblim/*OSBase_UnixProcess.h
@@ -64,12 +62,7 @@ chmod 644 $RPM_BUILD_ROOT/%{_includedir}/sblim/*OSBase_UnixProcess.h
 rm -f $RPM_BUILD_ROOT/%{_libdir}/*a
 rm -f $RPM_BUILD_ROOT/%{_libdir}/cmpi/*a
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
 %files
-%defattr(-,root,root,-)
 %docdir %{_datadir}/doc/%{name}-%{version}
 %{_datadir}/doc/%{name}-%{version}
 %{_datadir}/%{name}
@@ -77,12 +70,10 @@ rm -rf $RPM_BUILD_ROOT
 %{_libdir}/cmpi/*.so*
 
 %files devel
-%defattr(-,root,root,-)
 %{_includedir}/*
 %{_libdir}/*.so
 
 %files test
-%defattr(-,root,root,-)
 %dir %{_datadir}/sblim-testsuite/cim
 %dir %{_datadir}/sblim-testsuite/system
 %dir %{_datadir}/sblim-testsuite/system/linux
@@ -92,8 +83,8 @@ rm -rf $RPM_BUILD_ROOT
 %{_datadir}/sblim-testsuite/system/linux/*.sh
 %{_datadir}/sblim-testsuite/system/linux/*.pl
 
-%define SCHEMA %{_datadir}/%{name}/Linux_Base.mof %{_datadir}/%{name}/Linux_BaseIndication.mof
-%define REGISTRATION %{_datadir}/%{name}/Linux_BaseIndication.registration
+%global SCHEMA %{_datadir}/%{name}/Linux_Base.mof %{_datadir}/%{name}/Linux_BaseIndication.mof
+%global REGISTRATION %{_datadir}/%{name}/Linux_BaseIndication.registration
 
 %pre
 function unregister()
@@ -185,6 +176,9 @@ fi
 %postun -p /sbin/ldconfig
 
 %changelog
+* Tue Sep 04 2012 Vitezslav Crhonek <vcrhonek@redhat.com> - 1.6.1-8
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.6.1-7
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild