From b26c0a881c5a71ee310a942ffd65960974eabea8 Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Fri, 12 Jul 2019 17:29:23 +0200 Subject: [PATCH 063/187] netlogon: Fix potential use of uninitialized variable The _netr_NetrEnumerateTrustedDomains()->dcerpc_lsa_open_policy2() error path checks the policy handle and closes it if non-empty. The policy handle may be uninitialized in this code-path - fix this. Signed-off-by: David Disseldorp Reviewed-by: Andreas Schneider Reviewed-by: Andrew Bartlett (cherry picked from commit 93d424528f1c3d0d50ebd8a784f4624b2721d416) --- source3/rpc_server/netlogon/srv_netlog_nt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c index 791aa7acaff..08bce367bf0 100644 --- a/source3/rpc_server/netlogon/srv_netlog_nt.c +++ b/source3/rpc_server/netlogon/srv_netlog_nt.c @@ -419,6 +419,7 @@ NTSTATUS _netr_NetrEnumerateTrustedDomains(struct pipes_struct *p, int i; uint32_t max_size = (uint32_t)-1; + ZERO_STRUCT(pol); DEBUG(6,("_netr_NetrEnumerateTrustedDomains: %d\n", __LINE__)); status = rpcint_binding_handle(p->mem_ctx, -- 2.23.0