From b3170f77fac597bf50f0a857c1fa29f88a19036e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dan=20Hor=C3=A1k?= Date: Fri, 14 Nov 2025 08:28:08 +0000 Subject: [PATCH] tests: add check whether empty parameters are accepted by zipl --- tests/zipl-empty-params/main.fmf | 17 +++++++++ tests/zipl-empty-params/runtest.sh | 56 ++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+) create mode 100644 tests/zipl-empty-params/main.fmf create mode 100755 tests/zipl-empty-params/runtest.sh diff --git a/tests/zipl-empty-params/main.fmf b/tests/zipl-empty-params/main.fmf new file mode 100644 index 0000000..4824496 --- /dev/null +++ b/tests/zipl-empty-params/main.fmf @@ -0,0 +1,17 @@ +summary: zipl-empty-params +description: | + Check if zipl works with empty parameters in zipl.conf +link: https://bugzilla.redhat.com/show_bug.cgi?id=2113884 +contact: Daniel Horák +component: + - s390utils-core +test: ./runtest.sh +framework: beakerlib +require: + - s390utils-core +duration: 5m +enabled: true +adjust: + - when: arch != s390x + enabled: false + because: This test applies only to s390x systems. diff --git a/tests/zipl-empty-params/runtest.sh b/tests/zipl-empty-params/runtest.sh new file mode 100755 index 0000000..e40bd90 --- /dev/null +++ b/tests/zipl-empty-params/runtest.sh @@ -0,0 +1,56 @@ +#!/bin/bash +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Description: Check if zipl works with empty parameters in zipl.conf +# Author: Dan Horák +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2025 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +# Include Beaker environment +. /usr/share/beakerlib/beakerlib.sh || exit 1 + +PACKAGE="s390utils-core" + +rlJournalStart + rlPhaseStartSetup + rlAssertRpm $PACKAGE + rlRun "TmpDir=\$(mktemp -d)" 0 "Creating tmp directory" + rlRun "pushd $TmpDir" + rlPhaseEnd + + rlPhaseStartTest "Check if zipl works with empty kernel parameter line" + [ -f /etc/zipl.conf ] && cp /etc/zipl.conf . || cp /usr/lib/s390-tools/zipl.conf . + version=$(uname -r) + cat >> ./zipl.conf << EOF + +[empty] +target=/boot +image=/boot/vmlinuz-$version +ramdisk=/boot/initramfs-$version.img +EOF + rlRun "zipl -V --dry-run -c ./zipl.conf" + rlPhaseEnd + + rlPhaseStartCleanup + rlRun "popd" + rlRun "rm -r $TmpDir" 0 "Removing tmp directory" + rlPhaseEnd +rlJournalPrintText +rlJournalEnd