From 0ecf8272bf8130089a2d0c7e9f30b19c4d99b452 Mon Sep 17 00:00:00 2001 From: John Kacur Date: Fri, 5 May 2023 17:19:16 -0400 Subject: [PATCH] Correct commandline example Resolves: rhbz#2189440 jiraProject == RHELPLAN-155623 Signed-off-by: John Kacur --- ...on-rtla-Correct-command-line-example.patch | 37 +++++++++++++++++++ rtla.spec | 9 ++++- 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 Documentation-rtla-Correct-command-line-example.patch diff --git a/Documentation-rtla-Correct-command-line-example.patch b/Documentation-rtla-Correct-command-line-example.patch new file mode 100644 index 0000000..467c3f3 --- /dev/null +++ b/Documentation-rtla-Correct-command-line-example.patch @@ -0,0 +1,37 @@ +From 877d95dcfd0a56102d4b97a9691115f5fb5e9ea3 Mon Sep 17 00:00:00 2001 +From: Pierre Gondois +Date: Thu, 6 Oct 2022 10:44:09 +0200 +Subject: [PATCH] Documentation: rtla: Correct command line example + +The '-t/-T' parameters seem to have been swapped: +-t/--trace[=file]: save the stopped trace +to [file|timerlat_trace.txt] +-T/--thread us: stop trace if the thread latency +is higher than the argument in us + +Swap them back. + +Signed-off-by: Pierre Gondois +Acked-by: Daniel Bristot de Oliveira +Link: https://lore.kernel.org/r/20221006084409.3882542-1-pierre.gondois@arm.com +Signed-off-by: Jonathan Corbet +--- + Documentation/tools/rtla/rtla-timerlat-top.rst | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Documentation/tools/rtla/rtla-timerlat-top.rst b/Documentation/tools/rtla/rtla-timerlat-top.rst +index 1c321de1c171..7c4e4b109493 100644 +--- a/Documentation/rtla-timerlat-top.rst ++++ b/Documentation/rtla-timerlat-top.rst +@@ -39,7 +39,7 @@ higher than *30 us*. It is also set to stop the session if a *Thread* timer + latency higher than *30 us* is hit. Finally, it is set to save the trace + buffer if the stop condition is hit:: + +- [root@alien ~]# rtla timerlat top -s 30 -t 30 -T ++ [root@alien ~]# rtla timerlat top -s 30 -T 30 -t + Timer Latency + 0 00:00:59 | IRQ Timer Latency (us) | Thread Timer Latency (us) + CPU COUNT | cur min avg max | cur min avg max +-- +2.40.0 + diff --git a/rtla.spec b/rtla.spec index 39cc2ae..154d790 100644 --- a/rtla.spec +++ b/rtla.spec @@ -1,6 +1,6 @@ Name: rtla Version: 5.14.0 -Release: 4%{?dist} +Release: 5%{?dist} Summary: Real-Time Linux Analysis tools License: GPLv2 @@ -19,6 +19,7 @@ Requires: libtracefs >= 1.3.1 # Patches Patch1: rtla-Fix-exit-status-when-returning-from-calls-to-usage.patch +Patch2: Documentation-rtla-Correct-command-line-example.patch %description The rtla meta-tool includes a set of commands that aims to analyze @@ -30,6 +31,7 @@ about the properties and root causes of unexpected results. %prep %setup -q -n %{name}-%{version} %patch1 -p1 +%patch2 -p1 %build @@ -65,6 +67,11 @@ make DESTDIR=%{buildroot} -C Documentation install %changelog +* Fri May 05 2023 John Kacur - 5.14.0-5 +- Correct commandline example +Resolves: rhbz#2189440 +jiraProject == RHELPLAN-155623 + * Thu Jan 26 2023 John Kacur - 5.14.0-4 - Add a gating test for rtla Resolves: rhbz#2164877