From 7aba0df2cc6072da955ee0ad8bf907dc10cec468 Mon Sep 17 00:00:00 2001 From: Scott Wood Date: Mon, 6 Apr 2020 17:14:05 -0500 Subject: [PATCH 03/17] modules: Don't abort if a workload isn't running Each module is responsible for respawning the load when it finishes. The only thing that the additional check at the rtevalModulePrototype level accomplishes is introducing a race condition that will kill rteval if a load ends after _WorkloadTask() checks, but before the check in the caller. Signed-off-by: Scott Wood Signed-off-by: John Kacur --- rteval/modules/__init__.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/rteval/modules/__init__.py b/rteval/modules/__init__.py index 0feb8a916179..5ae7cd488406 100644 --- a/rteval/modules/__init__.py +++ b/rteval/modules/__init__.py @@ -189,9 +189,6 @@ class rtevalModulePrototype(threading.Thread): if self.shouldStop(): break - if not self.WorkloadAlive(): - self._log(Log.DEBUG, "%s workload stopped running." % self._module_type) - break time.sleep(self.__sleeptime) self.__timestamps["runloop_stop"] = datetime.now() -- 2.21.3