- Patch to fix non-coherent-filename regression for source packages.

This commit is contained in:
Ville Skyttä 2010-03-06 18:09:37 +00:00
parent 1468d1ba3f
commit f0b8d54da9
2 changed files with 26 additions and 1 deletions

View File

@ -0,0 +1,19 @@
Index: TagsCheck.py
===================================================================
--- TagsCheck.py (revision 1737)
+++ TagsCheck.py (revision 1738)
@@ -803,8 +803,12 @@
j += 1
i += 1
- expected = pkg.header.sprintf(
- rpm.expandMacro("%{_build_name_fmt}")).split("/")[-1]
+ expfmt = rpm.expandMacro("%{_build_name_fmt}")
+ if pkg.isSource():
+ # _build_name_fmt often (always?) ends up not outputting src/nosrc
+ # as arch for source packages, do it ourselves
+ expfmt = re.sub(r'(?i)%\{?ARCH\b\}?', pkg.arch, expfmt)
+ expected = pkg.header.sprintf(expfmt).split("/")[-1]
basename = os.path.basename(pkg.filename)
if basename != expected:
printWarning(pkg, 'non-coherent-filename', basename, expected)

View File

@ -1,6 +1,6 @@
Name: rpmlint Name: rpmlint
Version: 0.95 Version: 0.95
Release: 1%{?dist} Release: 2%{?dist}
Summary: Tool for checking common errors in RPM packages Summary: Tool for checking common errors in RPM packages
Group: Development/Tools Group: Development/Tools
@ -10,6 +10,8 @@ Source0: http://rpmlint.zarb.org/download/%{name}-%{version}.tar.bz2
Source1: %{name}.config Source1: %{name}.config
Source2: %{name}-CHANGES.package.old Source2: %{name}-CHANGES.package.old
Source3: %{name}-etc.config Source3: %{name}-etc.config
# http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1738/trunk/TagsCheck.py
Patch0: %{name}-0.95-srcfilename.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch BuildArch: noarch
@ -39,6 +41,7 @@ and source packages as well as spec files can be checked.
%prep %prep
%setup -q %setup -q
%patch0
sed -i -e /MenuCheck/d Config.py sed -i -e /MenuCheck/d Config.py
cp -p config config.example cp -p config config.example
install -pm 644 %{SOURCE2} CHANGES.package.old install -pm 644 %{SOURCE2} CHANGES.package.old
@ -78,6 +81,9 @@ rm -rf $RPM_BUILD_ROOT
%changelog %changelog
* Sat Mar 6 2010 Ville Skyttä <ville.skytta@iki.fi> - 0.95-2
- Patch to fix non-coherent-filename regression for source packages.
* Wed Mar 3 2010 Ville Skyttä <ville.skytta@iki.fi> - 0.95-1 * Wed Mar 3 2010 Ville Skyttä <ville.skytta@iki.fi> - 0.95-1
- Update to 0.95; fixes #564585, #567285, #568498, and #570086. - Update to 0.95; fixes #564585, #567285, #568498, and #570086.