rpms/rpmlint
7
0
Fork 0
Code Issues Pull Requests Releases Activity

disable various errors/warnings for debug/devel packages

Browse Source 
Several filter expressions for `*-debuginfo` and `*-debugsource`
packages had leading space which prevented them from matching as
intended.  Remove those spaces.

Ignore no-binary error for `*-debugsource` and `*-devel` packages.
Neither should be required to contain binaries or be noarch.

Remove unnecessary `no-cleaning-of-buildroot` and `files-attr-not-set`
filters.  These are no longer present upstream.  The buildroot check was
removed in b1a8a422 (Remove obsolete check no-cleaning-of-buildroot,
2022-06-22), released in rpmlint-2.4.0.  The file attr check was removed
in 221ce4b2 (remove files-attr-not-set check, 2015-05-19), released in
rpmlint-1.9.
This commit is contained in:
Todd Zullinger 2022-10-07 23:19:55 -04:00
parent 9c506b5c4f
commit 670d708754
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fedora.toml
View File

@ -233,7 +233,8 @@ Filters = [
# ' executable-marked-as-config-file', # ' executable-marked-as-config-file',
# ' log-files-without-logrotate', # ' log-files-without-logrotate',
# ' hardcoded-prefix-tag', # ' hardcoded-prefix-tag',
' -debug(info|source).* no-documentation', '-debug(info|source).* no-documentation',
'-debugsource.* no-binary',
# ' multiple-specfiles', # ' multiple-specfiles',
# ' no-default-runlevel ', # ' no-default-runlevel ',
# ' setgid-binary ', # ' setgid-binary ',
@ -265,8 +266,9 @@ Filters = [
# Fedora specific stuff that we don't want # Fedora specific stuff that we don't want
' ghost-files-without-postin', ' ghost-files-without-postin',
' no-provides ', ' no-provides ',
' -debuginfo.* /usr/lib/debug/', '-debuginfo.* /usr/lib/debug/',
' -debugsource.* /usr/src/debug/', '-debugsource.* /usr/src/debug/',
'-devel.* no-binary',
'^gpg-pubkey:', '^gpg-pubkey:',
' doc-file-dependency .* /bin/sh$', ' doc-file-dependency .* /bin/sh$',
'explicit-lib-dependency (liberation-fonts|libertas-.*-firmware|libvirt$|.*-(java|python|utils)$)', 'explicit-lib-dependency (liberation-fonts|libertas-.*-firmware|libvirt$|.*-(java|python|utils)$)',
@ -275,12 +277,6 @@ Filters = [
'dangling-\S*symlink /usr/share/doc/HTML/\S+/common .+/common$', 'dangling-\S*symlink /usr/share/doc/HTML/\S+/common .+/common$',
'hidden-file-or-dir .*/man5/\.k5login\.5[^/]+$', 'hidden-file-or-dir .*/man5/\.k5login\.5[^/]+$',
'blender.+ (wrong-script-interpreter|non-executable-script) .+/blender/.+\.py.*BPY.*', 'blender.+ (wrong-script-interpreter|non-executable-script) .+/blender/.+\.py.*BPY.*',
# Fedora 12 and newer no longer need a buildroot defined, to have the buildroot cleaned at the beginning
# of %install, and do not need to define a %clean section unless the default is invalid.
' no-cleaning-of-buildroot ',
# Only EL4 needs the files-attr-not-set check, because rpm 4.4 and newer no longer need a %defattr line
# (it automatically provides one).
'files-attr-not-set',
# Don't bother with the non-ghost-in-run checks, /var/lock and /var/run are # Don't bother with the non-ghost-in-run checks, /var/lock and /var/run are
# symlinks to /run/lock and /run respectively, and /run is a tmpfs # symlinks to /run/lock and /run respectively, and /run is a tmpfs
'non-ghost-in-run', 'non-ghost-in-run',

5
rpmlint.spec
View File

@ -3,7 +3,7 @@
Name: rpmlint Name: rpmlint
Version: 2.4.0 Version: 2.4.0
Release: 2%{?dist} Release: 3%{?dist}
Summary: Tool for checking common errors in RPM packages Summary: Tool for checking common errors in RPM packages
License: GPL-2.0-or-later License: GPL-2.0-or-later
URL: https://github.com/rpm-software-management/rpmlint URL: https://github.com/rpm-software-management/rpmlint
@ -76,6 +76,9 @@ cp -a %{SOURCE1} %{SOURCE3} %{SOURCE4} %{SOURCE5} %{buildroot}%{_sysconfdir}/xdg
%{_bindir}/rpmlint %{_bindir}/rpmlint
%changelog %changelog
* Fri Oct 07 2022 Todd Zullinger <tmz@pobox.com> - 2.4.0-3
- disable various errors/warnings for debug/devel packages
* Wed Oct 05 2022 Miro Hrončok <mhroncok@redhat.com> - 2.4.0-2 * Wed Oct 05 2022 Miro Hrončok <mhroncok@redhat.com> - 2.4.0-2
- remove the license list, depend on rpmlint-fedora-license-data instead - remove the license list, depend on rpmlint-fedora-license-data instead