Commit Graph

16 Commits

Author SHA1 Message Date
Tom Stellard
e0e0971163 Rename _pkg_extra_* macros to _distro_extra_* macros
The two intended uses cases for the _pkg_extra_* macros were to
make it easier for packagers to add new compile flags for use
with their package and also to make it easier to do distro wide
experiments with new flags.

However, it was pointed out on the mailing list[1] that you
can't satisfy both of these uses cases at the same time with
just one set of macros.  For example, if a packager uses
_pkg_extra_* macros to add flags specific to their own
package, then someone using _pkg_extra_* macros to
apply a new flag distro wide would override the package
specific flag.

I feel like the distro-wide use case is much more important,
so rather than create two sets of new flags, one for each use
case, I think it's best to rename the _pkg_extra_* macros
to _distro_extra_* and document that they are only meant
to be used for adding distro-wide flags and packagers should
not use this macro.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/TOG5RHWPS3VYMM52HFGZOUJVRCGZ7VXB/
2023-02-28 15:26:26 +00:00
Tom Stellard
1988722cbb Add %pkg_extra_* macros
https://fedoraproject.org/wiki/Changes/RPMMacrosForBuildFlags
2023-02-07 14:31:38 +00:00
Davide Cavalca
26c1ceaece Do not include frame pointers on ppc64le for now 2023-01-17 13:40:35 -08:00
Miro Hrončok
771fcecf48 CI: Don't use % in --define (it might have side effects) 2023-01-13 11:05:31 +01:00
Stephen Gallagher
7f02b5c439
Add tests for difference in RHEL and Fedora frame pointers
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
2023-01-12 10:36:48 -05:00
Davide Cavalca
990cc89b1b Do not include frame pointers on i686 and s390x for now 2023-01-10 12:53:06 -08:00
Davide Cavalca
f789437d98 tests: add test harness for %_include_frame_pointers 2023-01-06 10:57:49 -08:00
Tom Stellard
f77dcdec18 Fix passing of CFLAGS to brp-llvm-compile-lto-elf
This was accidentally broken by d9c7e4eef8.
2022-06-14 07:21:24 -07:00
Tom Stellard
4f02aa74c5 Add test case for rhbz#2083296 2022-05-27 15:39:20 +00:00
Tom Stellard
1f3e0863cc Convert tests to tmt
Also pull the gcc-fedora-flags test from rpms/gcc and pull the
clang-fedora-flags from rpms/clang.
2022-05-27 15:38:54 +00:00
Tom Stellard
200350d957 tests/no-new-dependencies: Add /bin/sh to requires.txt
There appears to be new rpm behavior which adds

Requires(interp): /bin/sh

to this package, so we need to account for this in requires.txt.
We already have /usr/bin/sh in requires.txt, so this is not a
new dependency.
2022-04-20 16:50:13 +00:00
Tom Stellard
9183c1c8d4 Call %set_build_flags before %build, %check, and %install stages
https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck
2022-01-14 20:57:22 +00:00
Zbigniew Jędrzejewski-Szmek
bc87a0d123 test/gcc-fedora-flags: modernize quoting 2022-01-13 14:05:59 +01:00
Miro Hrončok
f895eeaa56 Fedora CI: Test that no unexpected dependency was added 2021-11-16 19:37:24 +01:00
Miro Hrončok
71f61e78a9 CI: Rebuild redhat-rpm-config to assert we did not break the world 2021-10-19 22:54:13 +00:00
Tom Stellard
de1fe58a50 Add some gating CI tests 2021-01-19 22:17:21 +00:00