add another safety for people that write urls without protocols → quite a lot of indenting changes

macros.forge

@@ -77,6 +77,11 @@ end
 -- Set spec variable values for each known software publishing service
 if (forgeurl ~= "") then
   local forge          = string.match(forgeurl, "^[^:]+://([^/]+)/")
+  if (forge == nil) then
+    if not silent then
+      rpm.expand("%{error:URLs must include a protocol such as https:// and a path starting with / !\\n}")
+    end
+  else
     if (string.match(forge, "^gitlab[%.-]") or string.match(forge, "[%.-]gitlab[%.]")) then
       forgeurl = string.match(forgeurl, "https://[^/]+/[^/]+/[^/#?]+")
       if (forgeurl == nil) then
@@ -194,6 +199,8 @@ if (forgeurl ~= "") then
         end
         local shortcommit = string.sub(commit, 1, 12)
         safeset("archiveext", "tar.bz2")
+        -- Default to git even though BitBucket allows choosing between several SCMs
+        -- Set scm to hg for example before calling the macro if your project does not use git
         safeset("scm", "git")
         local owner = string.match(forgeurl, "^[^:]+://[^/]+/([^/]+)")
         local repo  = string.match(forgeurl, "^[^:]+://[^/]+/[^/]+/([^/]+)")
@@ -206,16 +213,19 @@ if (forgeurl ~= "") then
         end
       end
     end
+    if (forge == "pagure.io") then
+      if not silent then
+        rpm.expand("%{error:https://pagure.io/pagure/issue/861 needs to be resolved before the “pagure.io”\\nsoftware publishing service can be supported.\\n}")
+      end
+    end
     -- Final tests to check forgeurl was successfuly parsed
     if not silent then
-    if (forge == "pagure.io") then
-      rpm.expand("%{warn:https://pagure.io/pagure/issue/861 needs to be resolved before the “pagure.io”\\nsoftware publishing service can be supported.\\n}")
-    end
       if (rpm.expand("%{?archivename}") == "") or (rpm.expand("%{?archiveurl}") == "") then
         rpm.expand("%{error:Automation for the “" .. forge .. "”\\nsoftware publishing service is not implemented yet.\\nPlease extend the %%forgemeta macro!\\n}")
       end
     end
   end
+end
 -- Set defaults if forgeurl is missing or does not parse
 local archivename = rpm.expand("%{?archivename}")
 safeset("archiveext",       "tar.gz")