On Fri, 29 Jul 2005, Ulrich Drepper wrote:

> Please find attached the hopefully final changes for the compile flags.
>  It's a patch against redhat-rpm-config-8.0.36-1.src.rpm.  The changes are:
>
> ~ enable stack protector with minimal size 4 (default is 8, too high
>   IMO).  Vlad ran some tests on SPEC.  SPEC is highly CPU intensive,
>   unlike 90%+ of the distribution.  Even in those tests the performance
>   decrease was below 1%, probably even in the noise.  Especially the
>   decrease of the minimum size to 4 made no measurable impact.
>
> ~ remove the -fsigned-char flag for ppc.  glibc has not been compiled
>   with the flag anyway, so if anything changes, we eliminate some bugs.
>   The only theoretical issue would be if a library we ship uses CHAR_MAX
>   in an interface.  I personally haven't seen this for good reasons.
>   The only interface I know is localeconv(3) in glibc and this interface
>   is now corrected.
>
> ~ minor fix for SPARC
This commit is contained in:
Elliot Lee 2005-08-01 17:44:57 +00:00
parent f20fd09542
commit 1986646f85
3 changed files with 14 additions and 11 deletions

2
macros
View File

@ -152,7 +152,7 @@ unset DISPLAY\
%__find_provides /usr/lib/rpm/redhat/find-provides
%__find_requires /usr/lib/rpm/redhat/find-requires
%__global_cflags -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
%__global_cflags -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
# Disable lookups
%_hkp_keyserver %{nil}

View File

@ -1,6 +1,6 @@
Summary: Red Hat specific rpm configuration files.
Name: redhat-rpm-config
Version: 8.0.36
Version: 8.0.37
Release: 1
License: GPL
Group: Development/System
@ -35,6 +35,9 @@ rm -rf ${RPM_BUILD_ROOT}
%{_prefix}/lib/rpm/redhat
%changelog
* Mon Aug 01 2005 Elliot Lee <sopwith@redhat.com> - 8.0.37-1
- Patch from Uli: enable stack protector, fix sparc & ppc cflags
* Thu Jun 16 2005 Elliot Lee <sopwith@redhat.com> - 8.0.36-1
- Fix the fix

18
rpmrc
View File

@ -16,20 +16,20 @@ optflags: alphaev6 %{__global_cflags} -mieee -mcpu=ev6
optflags: alphaev67 %{__global_cflags} -mieee -mcpu=ev67
optflags: sparc %{__global_cflags} -m32 -mcpu=v7 -mtune=ultrasparc
optflags: sparcv8 %{__global_cflags} -m32 -mcpu=ultrasparc -mv8
optflags: sparcv8 %{__global_cflags} -m32 -mcpu=v8
optflags: sparcv9 %{__global_cflags} -m32 -mcpu=ultrasparc
optflags: sparc64 %{__global_cflags} -m64 -mcpu=ultrasparc
optflags: m68k %{__global_cflags}
optflags: ppc %{__global_cflags} -m32 -fsigned-char
optflags: ppciseries %{__global_cflags} -m32 -fsigned-char
optflags: ppcpseries %{__global_cflags} -m32 -fsigned-char
optflags: ppc64 %{__global_cflags} -m64 -fsigned-char -mminimal-toc
optflags: ppc64iseries %{__global_cflags} -m64 -fsigned-char -mminimal-toc
optflags: ppc64pseries %{__global_cflags} -m64 -fsigned-char -mminimal-toc
optflags: ppc8260 %{__global_cflags} -m32 -fsigned-char
optflags: ppc8560 %{__global_cflags} -m32 -fsigned-char
optflags: ppc %{__global_cflags} -m32
optflags: ppciseries %{__global_cflags} -m32
optflags: ppcpseries %{__global_cflags} -m32
optflags: ppc64 %{__global_cflags} -m64 -mminimal-toc
optflags: ppc64iseries %{__global_cflags} -m64 -mminimal-toc
optflags: ppc64pseries %{__global_cflags} -m64 -mminimal-toc
optflags: ppc8260 %{__global_cflags} -m32
optflags: ppc8560 %{__global_cflags} -m32
optflags: parisc %{__global_cflags} -mpa-risc-1-0
optflags: hppa1.0 %{__global_cflags} -mpa-risc-1-0