- specfile cleanup for review

This commit is contained in:
Martin Bacovsky 2007-02-15 07:44:58 +00:00
parent 8fe2bac5f3
commit c708ddb5ed

View File

@ -2,17 +2,21 @@
#%(if test -d /etc/init.d/. ; then echo /etc/init.d ; else echo /etc/rc.d/init.d ; fi) #%(if test -d /etc/init.d/. ; then echo /etc/init.d ; else echo /etc/rc.d/init.d ; fi)
%define RADVD_UID 75 %define RADVD_UID 75
Summary: A Router Advertisement daemon Summary: A Router Advertisement daemon
Name: radvd Name: radvd
Version: 1.0 Version: 1.0
Release: 2%{?dist} Release: 3%{?dist}
# The code includes the advertising clause, so it's GPL-incompatible # The code includes the advertising clause, so it's GPL-incompatible
License: BSD-style License: BSD-style
Group: System Environment/Daemons Group: System Environment/Daemons
Source: http://www.litech.org/radvd/radvd-%{version}.tar.gz Source: http://www.litech.org/radvd/dist/%{name}-%{version}.tar.gz
PreReq: chkconfig, /usr/sbin/useradd, /sbin/service, initscripts URL: http://www.litech.org/radvd/
BuildRoot: %{_tmppath}/%{name}-root Requires(postun): chkconfig, /usr/sbin/userdel, initscripts
BuildRequires: flex, byacc Requires(preun): chkconfig, initscripts
Requires(post): chkconfig
Requires(pre): /usr/sbin/useradd
BuildRequires: flex, byacc
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
%description %description
radvd is the router advertisement daemon for IPv6. It listens to router radvd is the router advertisement daemon for IPv6. It listens to router
@ -26,7 +30,7 @@ Install radvd if you are setting up IPv6 network and/or Mobile IPv6
services. services.
%prep %prep
%setup %setup -q
%build %build
export CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE -fPIE" export CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE -fPIE"
@ -41,7 +45,8 @@ make
%install %install
[ $RPM_BUILD_ROOT != "/" ] && rm -rf $RPM_BUILD_ROOT [ $RPM_BUILD_ROOT != "/" ] && rm -rf $RPM_BUILD_ROOT
%makeinstall make DESTDIR=$RPM_BUILD_ROOT install
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig
mkdir -p $RPM_BUILD_ROOT%{initdir} mkdir -p $RPM_BUILD_ROOT%{initdir}
mkdir -p $RPM_BUILD_ROOT/var/run/radvd mkdir -p $RPM_BUILD_ROOT/var/run/radvd
@ -75,11 +80,11 @@ fi
/usr/sbin/useradd -c "radvd user" -r -M -s /sbin/nologin -u %{RADVD_UID} -d / radvd 2>/dev/null || : /usr/sbin/useradd -c "radvd user" -r -M -s /sbin/nologin -u %{RADVD_UID} -d / radvd 2>/dev/null || :
%files %files
%defattr(-,root,root) %defattr(-,root,root,-)
%doc COPYRIGHT README CHANGES INTRO.html TODO %doc COPYRIGHT README CHANGES INTRO.html TODO
%config(noreplace) %{_sysconfdir}/radvd.conf %config(noreplace) %{_sysconfdir}/radvd.conf
%config(noreplace) /etc/sysconfig/radvd %config(noreplace) /etc/sysconfig/radvd
%config %{initdir}/radvd %{initdir}/radvd
%dir %attr(-,radvd,radvd) /var/run/radvd/ %dir %attr(-,radvd,radvd) /var/run/radvd/
%doc radvd.conf.example %doc radvd.conf.example
%{_mandir}/*/* %{_mandir}/*/*
@ -87,6 +92,9 @@ fi
%{_sbindir}/radvdump %{_sbindir}/radvdump
%changelog %changelog
* Wed Feb 14 2007 Martin Bacovsky <mbacovsk@redhat.com> - 1.0-3.fc7
- specfile cleanup for review
* Thu Feb 1 2007 Martin Bacovsky <mbacovsk@redhat.com> - 1.0-2.fc7 * Thu Feb 1 2007 Martin Bacovsky <mbacovsk@redhat.com> - 1.0-2.fc7
- linking with -pie flag turned on again - linking with -pie flag turned on again
@ -235,8 +243,8 @@ the like, really).
- Create a single package(source) for glibc21 and glibc22 (automatic - Create a single package(source) for glibc21 and glibc22 (automatic
Requires can handle this just fine). Requires can handle this just fine).
- use %%{_mandir} and friends - use %%{_mandir} and friends
- add more flesh to %doc - add more flesh to %%doc
- streamline %config file %attrs - streamline %%config file %%attrs
- streamline init.d file a bit: - streamline init.d file a bit:
* add a default chkconfig: (default to disable for security etc. reasons; * add a default chkconfig: (default to disable for security etc. reasons;
also, the default config isn't generic enough..) also, the default config isn't generic enough..)