60 lines
2.0 KiB
Diff
60 lines
2.0 KiB
Diff
From b9c555343b6567159effe1b3eb736fd1e02257bd Mon Sep 17 00:00:00 2001
|
|
From: Kevin Wolf <kwolf@redhat.com>
|
|
Date: Wed, 10 Oct 2018 20:22:01 +0100
|
|
Subject: test-bdrv-drain: Test AIO_WAIT_WHILE() in completion callback
|
|
|
|
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
Message-id: <20181010202213.7372-23-kwolf@redhat.com>
|
|
Patchwork-id: 82611
|
|
O-Subject: [RHEL-8 qemu-kvm PATCH 32/44] test-bdrv-drain: Test AIO_WAIT_WHILE() in completion callback
|
|
Bugzilla: 1637976
|
|
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
|
This is a regression test for a deadlock that occurred in block job
|
|
completion callbacks (via job_defer_to_main_loop) because the AioContext
|
|
lock was taken twice: once in job_finish_sync() and then again in
|
|
job_defer_to_main_loop_bh(). This would cause AIO_WAIT_WHILE() to hang.
|
|
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
Reviewed-by: Fam Zheng <famz@redhat.com>
|
|
(cherry picked from commit ae23dde9dd486e57e152a0ebc9802caddedc45fc)
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
---
|
|
tests/test-bdrv-drain.c | 10 ++++++++++
|
|
1 file changed, 10 insertions(+)
|
|
|
|
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
|
|
index 3cf3ba3..05f3b55 100644
|
|
--- a/tests/test-bdrv-drain.c
|
|
+++ b/tests/test-bdrv-drain.c
|
|
@@ -774,6 +774,15 @@ typedef struct TestBlockJob {
|
|
bool should_complete;
|
|
} TestBlockJob;
|
|
|
|
+static int test_job_prepare(Job *job)
|
|
+{
|
|
+ TestBlockJob *s = container_of(job, TestBlockJob, common.job);
|
|
+
|
|
+ /* Provoke an AIO_WAIT_WHILE() call to verify there is no deadlock */
|
|
+ blk_flush(s->common.blk);
|
|
+ return 0;
|
|
+}
|
|
+
|
|
static int coroutine_fn test_job_run(Job *job, Error **errp)
|
|
{
|
|
TestBlockJob *s = container_of(job, TestBlockJob, common.job);
|
|
@@ -804,6 +813,7 @@ BlockJobDriver test_job_driver = {
|
|
.drain = block_job_drain,
|
|
.run = test_job_run,
|
|
.complete = test_job_complete,
|
|
+ .prepare = test_job_prepare,
|
|
},
|
|
};
|
|
|
|
--
|
|
1.8.3.1
|
|
|