41 lines
1.4 KiB
Diff
41 lines
1.4 KiB
Diff
From 9a23075cef1ac6e73a95a489ac72f41c573ceb9b Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
|
|
Date: Tue, 10 Jun 2025 13:36:44 +0100
|
|
Subject: [PATCH] chardev/char-socket: skip automatic zero-init of large array
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The 'tcp_chr_read' method has a 4k byte array used for copying
|
|
data between the socket and device. Skip the automatic zero-init
|
|
of this array to eliminate the performance overhead in the I/O
|
|
hot path.
|
|
|
|
The 'buf' array will be fully initialized when reading data off
|
|
the network socket.
|
|
|
|
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Message-id: 20250610123709.835102-7-berrange@redhat.com
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
---
|
|
chardev/char-socket.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
|
|
index e8dd2931dc..1e8313915b 100644
|
|
--- a/chardev/char-socket.c
|
|
+++ b/chardev/char-socket.c
|
|
@@ -497,7 +497,7 @@ static gboolean tcp_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque)
|
|
{
|
|
Chardev *chr = CHARDEV(opaque);
|
|
SocketChardev *s = SOCKET_CHARDEV(opaque);
|
|
- uint8_t buf[CHR_READ_BUF_LEN];
|
|
+ QEMU_UNINITIALIZED uint8_t buf[CHR_READ_BUF_LEN];
|
|
int len, size;
|
|
|
|
if ((s->state != TCP_CHARDEV_STATE_CONNECTED) ||
|
|
--
|
|
2.47.3
|
|
|