106 lines
3.6 KiB
Diff
106 lines
3.6 KiB
Diff
From 4ab25b33831fa207500179bd30f29388d81e4cce Mon Sep 17 00:00:00 2001
|
|
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Date: Tue, 5 Dec 2023 13:20:10 -0500
|
|
Subject: [PATCH 093/101] job: remove outdated AioContext locking comments
|
|
|
|
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
RH-MergeRequest: 214: Remove AioContext lock
|
|
RH-Jira: RHEL-15965
|
|
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
RH-Commit: [24/26] 15ff2928be82d6905c22619458487fbb72d6044a (kmwolf/centos-qemu-kvm)
|
|
|
|
The AioContext lock no longer exists.
|
|
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
Message-ID: <20231205182011.1976568-14-stefanha@redhat.com>
|
|
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
---
|
|
include/qemu/job.h | 20 --------------------
|
|
1 file changed, 20 deletions(-)
|
|
|
|
diff --git a/include/qemu/job.h b/include/qemu/job.h
|
|
index e502787dd8..9ea98b5927 100644
|
|
--- a/include/qemu/job.h
|
|
+++ b/include/qemu/job.h
|
|
@@ -67,8 +67,6 @@ typedef struct Job {
|
|
|
|
/**
|
|
* The completion function that will be called when the job completes.
|
|
- * Called with AioContext lock held, since many callback implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
BlockCompletionFunc *cb;
|
|
|
|
@@ -264,9 +262,6 @@ struct JobDriver {
|
|
*
|
|
* This callback will not be invoked if the job has already failed.
|
|
* If it fails, abort and then clean will be called.
|
|
- *
|
|
- * Called with AioContext lock held, since many callbacs implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
int (*prepare)(Job *job);
|
|
|
|
@@ -277,9 +272,6 @@ struct JobDriver {
|
|
*
|
|
* All jobs will complete with a call to either .commit() or .abort() but
|
|
* never both.
|
|
- *
|
|
- * Called with AioContext lock held, since many callback implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
void (*commit)(Job *job);
|
|
|
|
@@ -290,9 +282,6 @@ struct JobDriver {
|
|
*
|
|
* All jobs will complete with a call to either .commit() or .abort() but
|
|
* never both.
|
|
- *
|
|
- * Called with AioContext lock held, since many callback implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
void (*abort)(Job *job);
|
|
|
|
@@ -301,9 +290,6 @@ struct JobDriver {
|
|
* .commit() or .abort(). Regardless of which callback is invoked after
|
|
* completion, .clean() will always be called, even if the job does not
|
|
* belong to a transaction group.
|
|
- *
|
|
- * Called with AioContext lock held, since many callbacs implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
void (*clean)(Job *job);
|
|
|
|
@@ -318,17 +304,12 @@ struct JobDriver {
|
|
* READY).
|
|
* (If the callback is NULL, the job is assumed to terminate
|
|
* without I/O.)
|
|
- *
|
|
- * Called with AioContext lock held, since many callback implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
bool (*cancel)(Job *job, bool force);
|
|
|
|
|
|
/**
|
|
* Called when the job is freed.
|
|
- * Called with AioContext lock held, since many callback implementations
|
|
- * use bdrv_* functions that require to hold the lock.
|
|
*/
|
|
void (*free)(Job *job);
|
|
};
|
|
@@ -424,7 +405,6 @@ void job_ref_locked(Job *job);
|
|
* Release a reference that was previously acquired with job_ref_locked() or
|
|
* job_create(). If it's the last reference to the object, it will be freed.
|
|
*
|
|
- * Takes AioContext lock internally to invoke a job->driver callback.
|
|
* Called with job lock held.
|
|
*/
|
|
void job_unref_locked(Job *job);
|
|
--
|
|
2.39.3
|
|
|