382f65f59d
- kvm-tests-qtest-netdev-test-stream-and-dgram-backends.patch [bz#2169232] - kvm-net-stream-add-a-new-option-to-automatically-reconne.patch [bz#2169232] - kvm-linux-headers-Update-to-v6.1.patch [bz#2158704] - kvm-util-userfaultfd-Add-uffd_open.patch [bz#2158704] - kvm-util-userfaultfd-Support-dev-userfaultfd.patch [bz#2158704] - kvm-io-Add-support-for-MSG_PEEK-for-socket-channel.patch [bz#2169732] - kvm-migration-check-magic-value-for-deciding-the-mapping.patch [bz#2169732] - kvm-target-s390x-arch_dump-Fix-memory-corruption-in-s390.patch [bz#2168172] - Resolves: bz#2169232 (RFE: reconnect option for stream socket back-end) - Resolves: bz#2158704 (RFE: Prefer /dev/userfaultfd over userfaultfd(2) syscall) - Resolves: bz#2169732 (Multifd migration fails under a weak network/socket ordering race) - Resolves: bz#2168172 ([s390x] qemu-kvm coredumps when SE crashes)
506 lines
15 KiB
Diff
506 lines
15 KiB
Diff
From 39d5761fe1f546e764dedf2ea32c55d8f5222696 Mon Sep 17 00:00:00 2001
|
|
From: Laurent Vivier <lvivier@redhat.com>
|
|
Date: Wed, 18 Jan 2023 13:04:05 +0100
|
|
Subject: [PATCH 1/8] tests/qtest: netdev: test stream and dgram backends
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
RH-Author: Laurent Vivier <lvivier@redhat.com>
|
|
RH-MergeRequest: 148: net: stream: add a new option to automatically reconnect
|
|
RH-Bugzilla: 2169232
|
|
RH-Acked-by: Eugenio Pérez <eperezma@redhat.com>
|
|
RH-Acked-by: Cindy Lu <lulu@redhat.com>
|
|
RH-Acked-by: MST <mst@redhat.com>
|
|
RH-Acked-by: David Gibson (Red Hat) <dgibson@redhat.com>
|
|
RH-Commit: [1/2] 75c71b47eea072e14651a96612d402b50d2b8f1e (lvivier/qemu-kvm-centos)
|
|
|
|
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
|
|
Acked-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Message-Id: <20230118120405.1876329-1-lvivier@redhat.com>
|
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
(cherry picked from commit c95031a19f0d7f418a597243f6f84b031a858997)
|
|
---
|
|
tests/qtest/meson.build | 2 +
|
|
tests/qtest/netdev-socket.c | 448 ++++++++++++++++++++++++++++++++++++
|
|
2 files changed, 450 insertions(+)
|
|
create mode 100644 tests/qtest/netdev-socket.c
|
|
|
|
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
|
|
index 9df3f9f8b9..2e7c6fe5e3 100644
|
|
--- a/tests/qtest/meson.build
|
|
+++ b/tests/qtest/meson.build
|
|
@@ -27,6 +27,7 @@ qtests_generic = [
|
|
'test-hmp',
|
|
'qos-test',
|
|
'readconfig-test',
|
|
+ 'netdev-socket',
|
|
]
|
|
if config_host.has_key('CONFIG_MODULES')
|
|
qtests_generic += [ 'modules-test' ]
|
|
@@ -299,6 +300,7 @@ qtests = {
|
|
'tpm-tis-device-swtpm-test': [io, tpmemu_files, 'tpm-tis-util.c'],
|
|
'tpm-tis-device-test': [io, tpmemu_files, 'tpm-tis-util.c'],
|
|
'vmgenid-test': files('boot-sector.c', 'acpi-utils.c'),
|
|
+ 'netdev-socket': files('netdev-socket.c', '../unit/socket-helpers.c'),
|
|
}
|
|
|
|
gvnc = dependency('gvnc-1.0', required: false)
|
|
diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
|
|
new file mode 100644
|
|
index 0000000000..6ba256e173
|
|
--- /dev/null
|
|
+++ b/tests/qtest/netdev-socket.c
|
|
@@ -0,0 +1,448 @@
|
|
+/*
|
|
+ * QTest testcase for netdev stream and dgram
|
|
+ *
|
|
+ * Copyright (c) 2022 Red Hat, Inc.
|
|
+ *
|
|
+ * SPDX-License-Identifier: GPL-2.0-or-later
|
|
+ */
|
|
+
|
|
+#include "qemu/osdep.h"
|
|
+#include "qemu/sockets.h"
|
|
+#include <glib/gstdio.h>
|
|
+#include "../unit/socket-helpers.h"
|
|
+#include "libqtest.h"
|
|
+
|
|
+#define CONNECTION_TIMEOUT 5
|
|
+
|
|
+#define EXPECT_STATE(q, e, t) \
|
|
+do { \
|
|
+ char *resp = NULL; \
|
|
+ g_test_timer_start(); \
|
|
+ do { \
|
|
+ g_free(resp); \
|
|
+ resp = qtest_hmp(q, "info network"); \
|
|
+ if (t) { \
|
|
+ strrchr(resp, t)[0] = 0; \
|
|
+ } \
|
|
+ if (g_str_equal(resp, e)) { \
|
|
+ break; \
|
|
+ } \
|
|
+ } while (g_test_timer_elapsed() < CONNECTION_TIMEOUT); \
|
|
+ g_assert_cmpstr(resp, ==, e); \
|
|
+ g_free(resp); \
|
|
+} while (0)
|
|
+
|
|
+static gchar *tmpdir;
|
|
+
|
|
+static int inet_get_free_port_socket_ipv4(int sock)
|
|
+{
|
|
+ struct sockaddr_in addr;
|
|
+ socklen_t len;
|
|
+
|
|
+ memset(&addr, 0, sizeof(addr));
|
|
+ addr.sin_family = AF_INET;
|
|
+ addr.sin_addr.s_addr = INADDR_ANY;
|
|
+ addr.sin_port = 0;
|
|
+ if (bind(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
|
|
+ return -1;
|
|
+ }
|
|
+
|
|
+ len = sizeof(addr);
|
|
+ if (getsockname(sock, (struct sockaddr *)&addr, &len) < 0) {
|
|
+ return -1;
|
|
+ }
|
|
+
|
|
+ return ntohs(addr.sin_port);
|
|
+}
|
|
+
|
|
+static int inet_get_free_port_socket_ipv6(int sock)
|
|
+{
|
|
+ struct sockaddr_in6 addr;
|
|
+ socklen_t len;
|
|
+
|
|
+ memset(&addr, 0, sizeof(addr));
|
|
+ addr.sin6_family = AF_INET6;
|
|
+ addr.sin6_addr = in6addr_any;
|
|
+ addr.sin6_port = 0;
|
|
+ if (bind(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
|
|
+ return -1;
|
|
+ }
|
|
+
|
|
+ len = sizeof(addr);
|
|
+ if (getsockname(sock, (struct sockaddr *)&addr, &len) < 0) {
|
|
+ return -1;
|
|
+ }
|
|
+
|
|
+ return ntohs(addr.sin6_port);
|
|
+}
|
|
+
|
|
+static int inet_get_free_port_multiple(int nb, int *port, bool ipv6)
|
|
+{
|
|
+ int sock[nb];
|
|
+ int i;
|
|
+
|
|
+ for (i = 0; i < nb; i++) {
|
|
+ sock[i] = socket(ipv6 ? AF_INET6 : AF_INET, SOCK_STREAM, 0);
|
|
+ if (sock[i] < 0) {
|
|
+ break;
|
|
+ }
|
|
+ port[i] = ipv6 ? inet_get_free_port_socket_ipv6(sock[i]) :
|
|
+ inet_get_free_port_socket_ipv4(sock[i]);
|
|
+ if (port[i] == -1) {
|
|
+ break;
|
|
+ }
|
|
+ }
|
|
+
|
|
+ nb = i;
|
|
+ for (i = 0; i < nb; i++) {
|
|
+ closesocket(sock[i]);
|
|
+ }
|
|
+
|
|
+ return nb;
|
|
+}
|
|
+
|
|
+static int inet_get_free_port(bool ipv6)
|
|
+{
|
|
+ int nb, port;
|
|
+
|
|
+ nb = inet_get_free_port_multiple(1, &port, ipv6);
|
|
+ g_assert_cmpint(nb, ==, 1);
|
|
+
|
|
+ return port;
|
|
+}
|
|
+
|
|
+static void test_stream_inet_ipv4(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ int port;
|
|
+
|
|
+ port = inet_get_free_port(false);
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,server=true,addr.type=inet,"
|
|
+ "addr.ipv4=on,addr.ipv6=off,"
|
|
+ "addr.host=127.0.0.1,addr.port=%d", port);
|
|
+
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,server=false,id=st0,addr.type=inet,"
|
|
+ "addr.ipv4=on,addr.ipv6=off,"
|
|
+ "addr.host=127.0.0.1,addr.port=%d", port);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=stream,tcp:127.0.0.1:%d\r\n",
|
|
+ port);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ /* the port is unknown, check only the address */
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:127.0.0.1", ':');
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+}
|
|
+
|
|
+static void test_stream_inet_ipv6(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ int port;
|
|
+
|
|
+ port = inet_get_free_port(true);
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,server=true,addr.type=inet,"
|
|
+ "addr.ipv4=off,addr.ipv6=on,"
|
|
+ "addr.host=::1,addr.port=%d", port);
|
|
+
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,server=false,id=st0,addr.type=inet,"
|
|
+ "addr.ipv4=off,addr.ipv6=on,"
|
|
+ "addr.host=::1,addr.port=%d", port);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=stream,tcp:::1:%d\r\n",
|
|
+ port);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ /* the port is unknown, check only the address */
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:::1", ':');
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+}
|
|
+
|
|
+static void test_stream_unix(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ gchar *path;
|
|
+
|
|
+ path = g_strconcat(tmpdir, "/stream_unix", NULL);
|
|
+
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,server=true,"
|
|
+ "addr.type=unix,addr.path=%s,",
|
|
+ path);
|
|
+
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,server=false,"
|
|
+ "addr.type=unix,addr.path=%s",
|
|
+ path);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ EXPECT_STATE(qts0, expect, 0);
|
|
+ g_free(expect);
|
|
+ g_free(path);
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+}
|
|
+
|
|
+#ifdef CONFIG_LINUX
|
|
+static void test_stream_unix_abstract(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ gchar *path;
|
|
+
|
|
+ path = g_strconcat(tmpdir, "/stream_unix_abstract", NULL);
|
|
+
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,server=true,"
|
|
+ "addr.type=unix,addr.path=%s,"
|
|
+ "addr.abstract=on",
|
|
+ path);
|
|
+
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,server=false,"
|
|
+ "addr.type=unix,addr.path=%s,addr.abstract=on",
|
|
+ path);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ EXPECT_STATE(qts0, expect, 0);
|
|
+ g_free(expect);
|
|
+ g_free(path);
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+}
|
|
+#endif
|
|
+
|
|
+#ifndef _WIN32
|
|
+static void test_stream_fd(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ int sock[2];
|
|
+ int ret;
|
|
+
|
|
+ ret = socketpair(AF_LOCAL, SOCK_STREAM, 0, sock);
|
|
+ g_assert_true(ret == 0);
|
|
+
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,addr.type=fd,addr.str=%d",
|
|
+ sock[0]);
|
|
+
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,unix:\r\n", 0);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev stream,id=st0,addr.type=fd,addr.str=%d",
|
|
+ sock[1]);
|
|
+
|
|
+ EXPECT_STATE(qts1, "st0: index=0,type=stream,unix:\r\n", 0);
|
|
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,unix:\r\n", 0);
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+
|
|
+ closesocket(sock[0]);
|
|
+ closesocket(sock[1]);
|
|
+}
|
|
+#endif
|
|
+
|
|
+static void test_dgram_inet(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ int port[2];
|
|
+ int nb;
|
|
+
|
|
+ nb = inet_get_free_port_multiple(2, port, false);
|
|
+ g_assert_cmpint(nb, ==, 2);
|
|
+
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,"
|
|
+ "local.type=inet,local.host=127.0.0.1,local.port=%d,"
|
|
+ "remote.type=inet,remote.host=127.0.0.1,remote.port=%d",
|
|
+ port[0], port[1]);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=dgram,"
|
|
+ "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
|
|
+ port[0], port[1]);
|
|
+ EXPECT_STATE(qts0, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,"
|
|
+ "local.type=inet,local.host=127.0.0.1,local.port=%d,"
|
|
+ "remote.type=inet,remote.host=127.0.0.1,remote.port=%d",
|
|
+ port[1], port[0]);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=dgram,"
|
|
+ "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
|
|
+ port[1], port[0]);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+}
|
|
+
|
|
+#ifndef _WIN32
|
|
+static void test_dgram_mcast(void)
|
|
+{
|
|
+ QTestState *qts;
|
|
+
|
|
+ qts = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,"
|
|
+ "remote.type=inet,remote.host=230.0.0.1,remote.port=1234");
|
|
+
|
|
+ EXPECT_STATE(qts, "st0: index=0,type=dgram,mcast=230.0.0.1:1234\r\n", 0);
|
|
+
|
|
+ qtest_quit(qts);
|
|
+}
|
|
+
|
|
+static void test_dgram_unix(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ gchar *path0, *path1;
|
|
+
|
|
+ path0 = g_strconcat(tmpdir, "/dgram_unix0", NULL);
|
|
+ path1 = g_strconcat(tmpdir, "/dgram_unix1", NULL);
|
|
+
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
|
|
+ "remote.type=unix,remote.path=%s",
|
|
+ path0, path1);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
|
|
+ path0, path1);
|
|
+ EXPECT_STATE(qts0, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
|
|
+ "remote.type=unix,remote.path=%s",
|
|
+ path1, path0);
|
|
+
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
|
|
+ path1, path0);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ unlink(path0);
|
|
+ g_free(path0);
|
|
+ unlink(path1);
|
|
+ g_free(path1);
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+}
|
|
+
|
|
+static void test_dgram_fd(void)
|
|
+{
|
|
+ QTestState *qts0, *qts1;
|
|
+ char *expect;
|
|
+ int ret;
|
|
+ int sv[2];
|
|
+
|
|
+ ret = socketpair(PF_UNIX, SOCK_DGRAM, 0, sv);
|
|
+ g_assert_cmpint(ret, !=, -1);
|
|
+
|
|
+ qts0 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,local.type=fd,local.str=%d",
|
|
+ sv[0]);
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[0]);
|
|
+ EXPECT_STATE(qts0, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ qts1 = qtest_initf("-nodefaults -M none "
|
|
+ "-netdev dgram,id=st0,local.type=fd,local.str=%d",
|
|
+ sv[1]);
|
|
+
|
|
+
|
|
+ expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[1]);
|
|
+ EXPECT_STATE(qts1, expect, 0);
|
|
+ g_free(expect);
|
|
+
|
|
+ qtest_quit(qts1);
|
|
+ qtest_quit(qts0);
|
|
+
|
|
+ closesocket(sv[0]);
|
|
+ closesocket(sv[1]);
|
|
+}
|
|
+#endif
|
|
+
|
|
+int main(int argc, char **argv)
|
|
+{
|
|
+ int ret;
|
|
+ bool has_ipv4, has_ipv6, has_afunix;
|
|
+ g_autoptr(GError) err = NULL;
|
|
+
|
|
+ socket_init();
|
|
+ g_test_init(&argc, &argv, NULL);
|
|
+
|
|
+ if (socket_check_protocol_support(&has_ipv4, &has_ipv6) < 0) {
|
|
+ g_error("socket_check_protocol_support() failed\n");
|
|
+ }
|
|
+
|
|
+ tmpdir = g_dir_make_tmp("netdev-socket.XXXXXX", &err);
|
|
+ if (tmpdir == NULL) {
|
|
+ g_error("Can't create temporary directory in %s: %s",
|
|
+ g_get_tmp_dir(), err->message);
|
|
+ }
|
|
+
|
|
+ if (has_ipv4) {
|
|
+ qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
|
|
+ qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
|
|
+#ifndef _WIN32
|
|
+ qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
|
|
+#endif
|
|
+ }
|
|
+ if (has_ipv6) {
|
|
+ qtest_add_func("/netdev/stream/inet/ipv6", test_stream_inet_ipv6);
|
|
+ }
|
|
+
|
|
+ socket_check_afunix_support(&has_afunix);
|
|
+ if (has_afunix) {
|
|
+#ifndef _WIN32
|
|
+ qtest_add_func("/netdev/dgram/unix", test_dgram_unix);
|
|
+#endif
|
|
+ qtest_add_func("/netdev/stream/unix", test_stream_unix);
|
|
+#ifdef CONFIG_LINUX
|
|
+ qtest_add_func("/netdev/stream/unix/abstract",
|
|
+ test_stream_unix_abstract);
|
|
+#endif
|
|
+#ifndef _WIN32
|
|
+ qtest_add_func("/netdev/stream/fd", test_stream_fd);
|
|
+ qtest_add_func("/netdev/dgram/fd", test_dgram_fd);
|
|
+#endif
|
|
+ }
|
|
+
|
|
+ ret = g_test_run();
|
|
+
|
|
+ g_rmdir(tmpdir);
|
|
+ g_free(tmpdir);
|
|
+
|
|
+ return ret;
|
|
+}
|
|
--
|
|
2.31.1
|
|
|