58 lines
2.2 KiB
Diff
58 lines
2.2 KiB
Diff
From 0bfbd2c49c01ee77d3b5a21bf9fe675916cbf0ed Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
|
|
Date: Tue, 10 Jun 2025 13:36:56 +0100
|
|
Subject: [PATCH 44/57] hw/misc/aspeed_hace: skip automatic zero-init of large
|
|
array
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
RH-MergeRequest: 382: Solve -ftrivial-auto-var-init performance regression with QEMU_UNINITIALIZED
|
|
RH-Jira: RHEL-99888
|
|
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
RH-Commit: [18/30] ec8510be6b23b26b3eecd6767e1deb0c0c50dd58 (stefanha/centos-stream-qemu-kvm)
|
|
|
|
The 'do_hash_operation' method has a 256 element iovec array used for
|
|
holding pointers to data that is to be hashed. Skip the automatic
|
|
zero-init of this array to eliminate the performance overhead in the
|
|
I/O hot path.
|
|
|
|
The 'iovec' array will be selectively initialized based on data that
|
|
needs to be hashed.
|
|
|
|
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Message-id: 20250610123709.835102-19-berrange@redhat.com
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
(cherry picked from commit 6992c886838282f36b20deee44b666bbfc573a8f)
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
|
Conflicts:
|
|
hw/misc/aspeed_hace.c
|
|
|
|
Context conflict due to missing commit b9ccbe212e24
|
|
("hw/misc/aspeed_hace: Extract accumulation-mode hash execution into
|
|
helper function") downstream. The commit is not a bug fix, so there is
|
|
no need to backport it.
|
|
---
|
|
hw/misc/aspeed_hace.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
|
|
index c06c04ddc6..d2118f1864 100644
|
|
--- a/hw/misc/aspeed_hace.c
|
|
+++ b/hw/misc/aspeed_hace.c
|
|
@@ -188,7 +188,7 @@ static int gen_acc_mode_iov(AspeedHACEState *s, struct iovec *iov, int id,
|
|
static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode,
|
|
bool acc_mode)
|
|
{
|
|
- struct iovec iov[ASPEED_HACE_MAX_SG];
|
|
+ QEMU_UNINITIALIZED struct iovec iov[ASPEED_HACE_MAX_SG];
|
|
g_autofree uint8_t *digest_buf = NULL;
|
|
size_t digest_len = 0;
|
|
int niov = 0;
|
|
--
|
|
2.39.3
|
|
|