92 lines
3.3 KiB
Diff
92 lines
3.3 KiB
Diff
From 5e7855d3c9d5a59d2c0ac05444428b058ca9abb8 Mon Sep 17 00:00:00 2001
|
|
From: Greg Kurz <groug@kaod.org>
|
|
Date: Wed, 26 May 2021 09:03:54 -0400
|
|
Subject: [PATCH 14/15] virtio-scsi: Configure all host notifiers in a single
|
|
MR transaction
|
|
|
|
RH-Author: Miroslav Rezanina <mrezanin@redhat.com>
|
|
RH-MergeRequest: 5: Synchronize RHEL-AV 8.5 release 18 to RHEL 9 Beta
|
|
RH-Commit: [11/12] f3c785c4b63aeb3a7b153f2fc17e86c983f98c23 (mrezanin/centos-src-qemu-kvm)
|
|
RH-Bugzilla: 1957194
|
|
RH-Acked-by: Danilo Cesar Lemes de Paula <ddepaula@redhat.com>
|
|
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
RH-Acked-by: Greg Kurz <gkurz@redhat.com>
|
|
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
|
This allows the virtio-scsi-pci device to batch the setup of all its
|
|
host notifiers. This significantly improves boot time of VMs with a
|
|
high number of vCPUs, e.g. from 6m5.563s down to 1m2.884s for a
|
|
pseries machine with 384 vCPUs.
|
|
|
|
Note that memory_region_transaction_commit() must be called before
|
|
virtio_bus_cleanup_host_notifier() because the latter might close
|
|
ioeventfds that the transaction still assumes to be around when it
|
|
commits.
|
|
|
|
Signed-off-by: Greg Kurz <groug@kaod.org>
|
|
Message-Id: <20210407143501.244343-5-groug@kaod.org>
|
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
(cherry picked from commit c4f5dcc4360a02085a633fd7a90b7ac395ca1ba4)
|
|
Signed-off-by: Greg Kurz <gkurz@redhat.com>
|
|
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
---
|
|
hw/scsi/virtio-scsi-dataplane.c | 16 ++++++++++++++++
|
|
1 file changed, 16 insertions(+)
|
|
|
|
diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c
|
|
index b2cb3d9dcc..28e003250a 100644
|
|
--- a/hw/scsi/virtio-scsi-dataplane.c
|
|
+++ b/hw/scsi/virtio-scsi-dataplane.c
|
|
@@ -152,6 +152,8 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev)
|
|
goto fail_guest_notifiers;
|
|
}
|
|
|
|
+ memory_region_transaction_begin();
|
|
+
|
|
rc = virtio_scsi_set_host_notifier(s, vs->ctrl_vq, 0);
|
|
if (rc != 0) {
|
|
goto fail_host_notifiers;
|
|
@@ -173,6 +175,8 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev)
|
|
vq_init_count++;
|
|
}
|
|
|
|
+ memory_region_transaction_commit();
|
|
+
|
|
aio_context_acquire(s->ctx);
|
|
virtio_queue_aio_set_host_notifier_handler(vs->ctrl_vq, s->ctx,
|
|
virtio_scsi_data_plane_handle_ctrl);
|
|
@@ -192,6 +196,11 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev)
|
|
fail_host_notifiers:
|
|
for (i = 0; i < vq_init_count; i++) {
|
|
virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), i, false);
|
|
+ }
|
|
+
|
|
+ memory_region_transaction_commit();
|
|
+
|
|
+ for (i = 0; i < vq_init_count; i++) {
|
|
virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i);
|
|
}
|
|
k->set_guest_notifiers(qbus->parent, vs->conf.num_queues + 2, false);
|
|
@@ -229,8 +238,15 @@ void virtio_scsi_dataplane_stop(VirtIODevice *vdev)
|
|
|
|
blk_drain_all(); /* ensure there are no in-flight requests */
|
|
|
|
+ memory_region_transaction_begin();
|
|
+
|
|
for (i = 0; i < vs->conf.num_queues + 2; i++) {
|
|
virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), i, false);
|
|
+ }
|
|
+
|
|
+ memory_region_transaction_commit();
|
|
+
|
|
+ for (i = 0; i < vs->conf.num_queues + 2; i++) {
|
|
virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i);
|
|
}
|
|
|
|
--
|
|
2.27.0
|
|
|