51 lines
1.8 KiB
Diff
51 lines
1.8 KiB
Diff
From ad0ae4edded2db9e7fea4c82cb22d47798b34528 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
|
|
Date: Tue, 10 Jun 2025 13:36:49 +0100
|
|
Subject: [PATCH 12/31] hw/audio/marvell_88w8618: skip automatic zero-init of
|
|
large array
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
RH-MergeRequest: 461: Solve -ftrivial-auto-var-init performance regression with QEMU_UNINITIALIZED
|
|
RH-Jira: RHEL-99887
|
|
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
RH-Commit: [11/30] 22754626ac42807e6306becab38fbaf564a84660
|
|
|
|
The 'mv88w8618_audio_callback' method has a 4k byte array used for
|
|
copying data between the audio backend and device. Skip the automatic
|
|
zero-init of this array to eliminate the performance overhead in
|
|
the I/O hot path.
|
|
|
|
The 'buf' array will be fully initialized when reading data from
|
|
device memory.
|
|
|
|
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Message-id: 20250610123709.835102-12-berrange@redhat.com
|
|
[Fixed hw/audio/gus in commit message --Stefan]
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
(cherry picked from commit 5b6cd5c5df4229972d8a0fd9dd9a089a1644d6ba)
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
---
|
|
hw/audio/marvell_88w8618.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
|
|
index cc285444bc..b7b4b27272 100644
|
|
--- a/hw/audio/marvell_88w8618.c
|
|
+++ b/hw/audio/marvell_88w8618.c
|
|
@@ -66,7 +66,7 @@ static void mv88w8618_audio_callback(void *opaque, int free_out, int free_in)
|
|
{
|
|
mv88w8618_audio_state *s = opaque;
|
|
int16_t *codec_buffer;
|
|
- int8_t buf[4096];
|
|
+ QEMU_UNINITIALIZED int8_t buf[4096];
|
|
int8_t *mem_buffer;
|
|
int pos, block_size;
|
|
|
|
--
|
|
2.39.3
|
|
|