57 lines
2.1 KiB
Diff
57 lines
2.1 KiB
Diff
From 52482dfcf0f97cd5db7a210497bdf45390cb7600 Mon Sep 17 00:00:00 2001
|
|
From: Paolo Bonzini <pbonzini@redhat.com>
|
|
Date: Fri, 18 Jul 2025 18:03:47 +0200
|
|
Subject: [PATCH 066/115] i386/tdx: Disable PIC for TDX VMs
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
RH-Author: Paolo Bonzini <pbonzini@redhat.com>
|
|
RH-MergeRequest: 391: TDX support, including attestation and device assignment
|
|
RH-Jira: RHEL-15710 RHEL-20798 RHEL-49728
|
|
RH-Acked-by: Yash Mankad <None>
|
|
RH-Acked-by: Peter Xu <peterx@redhat.com>
|
|
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
RH-Commit: [66/115] 8f3badca2c7cb18d3d10bb1208396f63b7aeb47b (bonzini/rhel-qemu-kvm)
|
|
|
|
Legacy PIC (8259) cannot be supported for TDX VMs since TDX module
|
|
doesn't allow directly interrupt injection. Using posted interrupts
|
|
for the PIC is not a viable option as the guest BIOS/kernel will not
|
|
do EOI for PIC IRQs, i.e. will leave the vIRR bit set.
|
|
|
|
Hence disable PIC for TDX VMs and error out if user wants PIC.
|
|
|
|
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
|
|
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
|
|
Link: https://lore.kernel.org/r/20250508150002.689633-38-xiaoyao.li@intel.com
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
(cherry picked from commit e7ef60892c80a9ce5b8504ceb13a81f4e0d4b3f7)
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
---
|
|
target/i386/kvm/tdx.c | 7 +++++++
|
|
1 file changed, 7 insertions(+)
|
|
|
|
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
|
|
index 9bd6843988..4f17e17308 100644
|
|
--- a/target/i386/kvm/tdx.c
|
|
+++ b/target/i386/kvm/tdx.c
|
|
@@ -381,6 +381,13 @@ static int tdx_kvm_init(ConfidentialGuestSupport *cgs, Error **errp)
|
|
return -EINVAL;
|
|
}
|
|
|
|
+ if (x86ms->pic == ON_OFF_AUTO_AUTO) {
|
|
+ x86ms->pic = ON_OFF_AUTO_OFF;
|
|
+ } else if (x86ms->pic == ON_OFF_AUTO_ON) {
|
|
+ error_setg(errp, "TDX VM doesn't support PIC");
|
|
+ return -EINVAL;
|
|
+ }
|
|
+
|
|
if (!tdx_caps) {
|
|
r = get_tdx_capabilities(errp);
|
|
if (r) {
|
|
--
|
|
2.50.1
|
|
|